[vwnc] [7.6] WinProcess code duplication

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[vwnc] [7.6] WinProcess code duplication

Boris Popov, DeepCove Labs (SNN)

This is obviously a low priority, but someone went all copy-paste happy on WinProcess,

 

WinProcess>>cshOne: aString

 ^self fork: self getCommandLineInterpreter arguments: (Array with: '/c' with: aString).

 

WinProcess>>executeSingleCommand: aString

 ^self fork: self getCommandLineInterpreter arguments: (Array with: '/c' with: aString).

 

WinProcess>>shOne: aString

 ^self fork: self getCommandLineInterpreter arguments: (Array with: '/c' with: aString).

 

Can we have a code critic check for identical methods with differing names on class/superclasses please?

 

Thanks!

-Boris

--
+1.604.689.0322
DeepCove Labs Ltd.
4th floor 595 Howe Street
Vancouver, Canada V6C 2T5
http://tinyurl.com/r7uw4

[hidden email]

CONFIDENTIALITY NOTICE

This email is intended only for the persons named in the message header. Unless otherwise indicated, it contains information that is private and confidential. If you have received it in error, please notify the sender and delete the entire message including any attachments.

Thank you.

 


_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
Reply | Threaded
Open this post in threaded view
|

Re: [vwnc] [7.6] WinProcess code duplication

Andres Valloud-6
AR 55203 for the code duplication...
 
Andres.


From: [hidden email] [mailto:[hidden email]] On Behalf Of Boris Popov
Sent: Tuesday, September 23, 2008 2:12 PM
To: [hidden email]
Subject: [vwnc] [7.6] WinProcess code duplication

This is obviously a low priority, but someone went all copy-paste happy on WinProcess,

 

WinProcess>>cshOne: aString

 ^self fork: self getCommandLineInterpreter arguments: (Array with: '/c' with: aString).

 

WinProcess>>executeSingleCommand: aString

 ^self fork: self getCommandLineInterpreter arguments: (Array with: '/c' with: aString).

 

WinProcess>>shOne: aString

 ^self fork: self getCommandLineInterpreter arguments: (Array with: '/c' with: aString).

 

Can we have a code critic check for identical methods with differing names on class/superclasses please?

 

Thanks!

-Boris

--
+1.604.689.0322
DeepCove Labs Ltd.
4th floor 595 Howe Street
Vancouver, Canada V6C 2T5
http://tinyurl.com/r7uw4

[hidden email]

CONFIDENTIALITY NOTICE

This email is intended only for the persons named in the message header. Unless otherwise indicated, it contains information that is private and confidential. If you have received it in error, please notify the sender and delete the entire message including any attachments.

Thank you.

 


_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc