[vwnc] [Bug] [7.6 up to jul08.5] TooltipAssistent tooltipGraphic not error safe

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[vwnc] [Bug] [7.6 up to jul08.5] TooltipAssistent tooltipGraphic not error safe

Thomas Brodt
Currently I change our code from FlyByHelp to ToolTipHelp. We extended
the old FlyByHelp to deal with BlockClosures as the new Tooltip also
does now. Our block got the controller of the view to calculate some
help text.
The new tooltip however gets the view instead of the controller which
results in errors in our blocks, so the code reaches the error handler
in class TooltipAssistent, which IMHO has a bug in its error handling.

This version of method tooltipGraphic in class TooltipAssistent returns
the Transcript if it catches an error.

tooltipGraphic
       
        ^[self tooltip ifNotNil: [:supplier | supplier asTooltipGraphicFor: view]]
                on: Error
                do:
                        [:ex |
                        Transcript
                                cr;
                                show: (#errTooltipGraphic << #dialogs >> 'Error building
tooltipGraphic: <1s>' expandMacrosWith: ex errorString);
                                flush]


So it should probably read like this to return nil instead:

tooltipGraphic
       
        ^[self tooltip ifNotNil: [:supplier | supplier asTooltipGraphicFor: view]]
                on: Error
                do:
                        [:ex |
                        Transcript
                                cr;
                                show: (#errTooltipGraphic << #dialogs >> 'Error building
tooltipGraphic: <1s>' expandMacrosWith: ex errorString);
                                flush.
                        ex return: nil]

Regards

Thomas

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc