[vwnc] ColorValue>>hex fixes

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[vwnc] ColorValue>>hex fixes

Boris Popov, DeepCove Labs (SNN)
I had to fix ColorValue>>hex today to get the following test case to
pass without blowing up,

Self assert: (((ColorValue.ColorNames keys asSortedCollection collect:
[:ea | ColorValue perform: ea]) collect: [:ea | ea hex])
isSameSequenceAs: #('000000' '0000FF' '7F3F3F' '7FFF00' '00FFFF'
'007F7F' '5F5F5F' '007F00' '7F007F' '7F0000' '7F7F7F' '00FF00' '7FFFFF'
'AAAAAA' 'FFFF7F' 'FF00FF' '00007F' '7F7F00' 'FF7F00' 'FF7FFF' '7FFF7F'
'FFBFBF' '9F1FDF' 'FF0000' '7F7FFF' 'FF7F7F' '00FF7F' '3F3F3F' 'D4D4D4'
'FFFFFF' 'FFFF00')).

I borrowed from ColorValue>>javascriptOn: and refactored it to call the
new method. Again, no idea if this is something Cincom folks or the core
group need to be interested in.

Cheers!

-Boris

--
+1.604.689.0322
DeepCove Labs Ltd.
4th floor 595 Howe Street
Vancouver, Canada V6C 2T5
http://tinyurl.com/r7uw4

[hidden email]

CONFIDENTIALITY NOTICE

This email is intended only for the persons named in the message
header. Unless otherwise indicated, it contains information that is
private and confidential. If you have received it in error, please
notify the sender and delete the entire message including any
attachments.

Thank you.


_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

ColorValue-javascriptOn.st (350 bytes) Download Attachment
ColorValue-printHexOn.st (634 bytes) Download Attachment
ColorValue-hex.st (268 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [vwnc] ColorValue>>hex fixes

Ralf Propach
There is already an AR#54117 about ColorValue>>hex,
so the problem is known.

Boris Popov wrote:

> I had to fix ColorValue>>hex today to get the following test case to
> pass without blowing up,
>
> Self assert: (((ColorValue.ColorNames keys asSortedCollection collect:
> [:ea | ColorValue perform: ea]) collect: [:ea | ea hex])
> isSameSequenceAs: #('000000' '0000FF' '7F3F3F' '7FFF00' '00FFFF'
> '007F7F' '5F5F5F' '007F00' '7F007F' '7F0000' '7F7F7F' '00FF00' '7FFFFF'
> 'AAAAAA' 'FFFF7F' 'FF00FF' '00007F' '7F7F00' 'FF7F00' 'FF7FFF' '7FFF7F'
> 'FFBFBF' '9F1FDF' 'FF0000' '7F7FFF' 'FF7F7F' '00FF7F' '3F3F3F' 'D4D4D4'
> 'FFFFFF' 'FFFF00')).
>
> I borrowed from ColorValue>>javascriptOn: and refactored it to call the
> new method. Again, no idea if this is something Cincom folks or the core
> group need to be interested in.
>
> Cheers!
>
> -Boris
>
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> vwnc mailing list
> [hidden email]
> http://lists.cs.uiuc.edu/mailman/listinfo/vwnc


--
Ralf Propach, [hidden email]
Tel: +49 231 975 99 38   Fax: +49 231 975 99 20
Georg Heeg eK (Dortmund)
Handelsregister: Amtsgericht Dortmund  A 12812
_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
Reply | Threaded
Open this post in threaded view
|

Re: [vwnc] ColorValue>>hex fixes

Boris Popov, DeepCove Labs (SNN)
Ralf,

Here's a more comprehensive test case and fixes I've made for your
review.

Cheers,

-Boris

--
+1.604.689.0322
DeepCove Labs Ltd.
4th floor 595 Howe Street
Vancouver, Canada V6C 2T5
http://tinyurl.com/r7uw4

[hidden email]

CONFIDENTIALITY NOTICE

This email is intended only for the persons named in the message
header. Unless otherwise indicated, it contains information that is
private and confidential. If you have received it in error, please
notify the sender and delete the entire message including any
attachments.

Thank you.

> -----Original Message-----
> From: Ralf Propach [mailto:[hidden email]]
> Sent: Monday, July 07, 2008 8:22 AM
> To: Boris Popov
> Cc: vwnc-list; Seaside - general discussion
> Subject: Re: [vwnc] ColorValue>>hex fixes
>
> There is already an AR#54117 about ColorValue>>hex,
> so the problem is known.
>
> Boris Popov wrote:
> > I had to fix ColorValue>>hex today to get the following test case to
> > pass without blowing up,
> >
> > Self assert: (((ColorValue.ColorNames keys asSortedCollection
collect:
> > [:ea | ColorValue perform: ea]) collect: [:ea | ea hex])
> > isSameSequenceAs: #('000000' '0000FF' '7F3F3F' '7FFF00' '00FFFF'
> > '007F7F' '5F5F5F' '007F00' '7F007F' '7F0000' '7F7F7F' '00FF00'
'7FFFFF'
> > 'AAAAAA' 'FFFF7F' 'FF00FF' '00007F' '7F7F00' 'FF7F00' 'FF7FFF'
'7FFF7F'
> > 'FFBFBF' '9F1FDF' 'FF0000' '7F7FFF' 'FF7F7F' '00FF7F' '3F3F3F'
'D4D4D4'
> > 'FFFFFF' 'FFFF00')).
> >
> > I borrowed from ColorValue>>javascriptOn: and refactored it to call
the
> > new method. Again, no idea if this is something Cincom folks or the
core
> > group need to be interested in.
> >
> > Cheers!
> >
> > -Boris
> >
> >
> >
> >
------------------------------------------------------------------------

> >
> > _______________________________________________
> > vwnc mailing list
> > [hidden email]
> > http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
>
>
> --
> Ralf Propach, [hidden email]
> Tel: +49 231 975 99 38   Fax: +49 231 975 99 20
> Georg Heeg eK (Dortmund)
> Handelsregister: Amtsgericht Dortmund  A 12812

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

ColorTesting.st (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [vwnc] ColorValue>>hex fixes

Ralf Propach
Boris Popov wrote:
> Ralf,
>
> Here's a more comprehensive test case and fixes I've made for your
> review.
>
> Cheers,
>
> -Boris
>

Thanks, Boris,

I have uploaded your email and your code to MARS,
but I will leave the actual review and integration to Cincom.

Ralf

--
Ralf Propach, [hidden email]
Tel: +49 231 975 99 38   Fax: +49 231 975 99 20
Georg Heeg eK (Dortmund)
Handelsregister: Amtsgericht Dortmund  A 12812
_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc