Smalltalk › Cincom › VisualWorks

[vwnc] Disabled package record cache

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

4 messages Options

Paul Baumann

[vwnc] Disabled package record cache

TimeProfiler review brought me to this method:

Store.Package>>aRecordWithID: anID
"Check my cache first then use super method."

| rec |
rec := Cache at: anID ifAbsent: [nil].
(rec notNil and: [rec class == self])
  ifFalse:
   [rec := super aRecordWithID: anID.
   "rec notNil ifTrue: [Cache at: anID put: rec]"].
^rec

Notice that use of the cache is commented out?

Paul Baumann

This message may contain confidential information and is intended for specific recipients unless explicitly noted otherwise. If you have reason to believe you are not an intended recipient of this message, please delete it and notify the sender. This message may not represent the opinion of IntercontinentalExchange, Inc. (ICE), its subsidiaries or affiliates, and does not constitute a contract or guarantee. Unencrypted electronic mail is not secure and the recipient of this message is expected to provide safeguards from viruses and pursue alternate means of communication where privacy or a binding message is desired.

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Holger Kleinsorgen-4

Re: [vwnc] Disabled package record cache

Paul Baumann wrote:

> *TimeProfiler review brought me to this method:*
>
> Store.Package>>aRecordWithID: anID
> "Check my cache first then use super method."
>
> | rec |
> rec := Cache at: anID ifAbsent: [nil].
> (rec notNil and: [rec class == self])
> ifFalse:
> [rec := super aRecordWithID: anID.
> * "rec notNil ifTrue: [Cache at: anID put: rec]"].*
> ^rec
>
> *Notice that use of the cache is commented out? *

Looks like VW 7.4.1. In VW 7.6, the implentation has changed and uses
cached records.
_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Alan Knight-2

Re: [vwnc] Disabled package record cache

In reply to this post by Paul Baumann

Yes. The easiest way to avoid that is to use 7.6, in which the cache is not disabled (but I believe it's more complicated than just uncommenting those lines). And in 7.7 those objects are no longer used for most purposes. It's also helpful if you specify the version you're using.

At 10:44 AM 2009-08-14, Paul Baumann wrote:

Content-Language: en-US
Content-Type: multipart/alternative;
boundary="_000_3FCC5C63F3371940900A2160FD399FD3E13FB43Fatbpixmx02CPEXc_"

TimeProfiler review brought me to this method:

Store.Package>>aRecordWithID: anID
"Check my cache first then use super method."

| rec |
rec := Cache at: anID ifAbsent: [nil].
(rec notNil and: [rec class == self])
ifFalse:
[rec := super aRecordWithID: anID.
"rec notNil ifTrue: [Cache at: anID put: rec]"].
^rec

Notice that use of the cache is commented out?

Paul Baumann

This message may contain confidential information and is intended for specific recipients unless explicitly noted otherwise. If you have reason to believe you are not an intended recipient of this message, please delete it and notify the sender. This message may not represent the opinion of IntercontinentalExchange, Inc. (ICE), its subsidiaries or affiliates, and does not constitute a contract or guarantee. Unencrypted electronic mail is not secure and the recipient of this message is expected to provide safeguards from viruses and pursue alternate means of communication where privacy or a binding message is desired.
_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Alan Knight [|], Engineering Manager, Cincom Smalltalk

[hidden email]

http://www.cincom.com/smalltalk

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Paul Baumann

Re: [vwnc] Disabled package record cache

In reply to this post by Paul Baumann

Of course, test performance screams once the cache is used. But if there was a reason for avoiding the cache so I'll do the same. I'll look into upgrading since you think there is more to it than uncommenting.

Thanks for the heads-up on 7.7. I'm glad it was caught for 7.6. We are back on 7.5 and feeling the need to upgrade.

Paul Baumann

From: Alan Knight [mailto:[hidden email]]
Sent: Friday, August 14, 2009 10:57 AM
To: Paul Baumann; VWNC
Subject: Re: [vwnc] Disabled package record cache
Importance: High

Content-Language: en-US
Content-Type: multipart/alternative;
boundary="_000_3FCC5C63F3371940900A2160FD399FD3E13FB43Fatbpixmx02CPEXc_"

TimeProfiler review brought me to this method:

Store.Package>>aRecordWithID: anID
"Check my cache first then use super method."

| rec |
rec := Cache at: anID ifAbsent: [nil].
(rec notNil and: [rec class == self])
ifFalse:
[rec := super aRecordWithID: anID.
"rec notNil ifTrue: [Cache at: anID put: rec]"].
^rec

Notice that use of the cache is commented out?

Paul Baumann

This message may contain confidential information and is intended for specific recipients unless explicitly noted otherwise. If you have reason to believe you are not an intended recipient of this message, please delete it and notify the sender. This message may not represent the opinion of IntercontinentalExchange, Inc. (ICE), its subsidiaries or affiliates, and does not constitute a contract or guarantee. Unencrypted electronic mail is not secure and the recipient of this message is expected to provide safeguards from viruses and pursue alternate means of communication where privacy or a binding message is desired.
_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Alan Knight [|], Engineering Manager, Cincom Smalltalk

[hidden email]

http://www.cincom.com/smalltalk