Smalltalk › Cincom › VisualWorks

[vwnc] Finding all senders ... bug??

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

14 messages Options

Dennis smith-4

[vwnc] Finding all senders ... bug??

I have a symbol #ALL all uppercase.
When I try and find senders to find all references, I get
#All
but no references to ALL -- there are quite a few.

--
Dennis Smith +1 416.798.7948
Cherniak Software Development Corporation Fax: +1 416.798.0948
509-2001 Sheppard Avenue East [hidden email]
Toronto, ON M2J 4Z8 sip:[hidden email]
Canada http://www.CherniakSoftware.com
Entrance off Yorkland Blvd south of Sheppard Ave east of the DVP

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Andres Valloud-6

Re: [vwnc] Finding all senders ... bug??

Dennis,

You may want to try the "Find References to Symbol..." menu item
instead. I am not sure if that is the name of the menu item in the
version you're using, however the behavior is different.

Andres.

-----Original Message-----
From: [hidden email] [mailto:[hidden email]] On
Behalf Of Dennis Smith
Sent: Tuesday, January 06, 2009 12:36 PM
To: VWNC,
Subject: [vwnc] Finding all senders ... bug??

I have a symbol #ALL all uppercase.
When I try and find senders to find all references, I get
#All
but no references to ALL -- there are quite a few.

--
Dennis Smith +1 416.798.7948
Cherniak Software Development Corporation Fax: +1 416.798.0948
509-2001 Sheppard Avenue East [hidden email]
Toronto, ON M2J 4Z8 sip:[hidden email]
Canada http://www.CherniakSoftware.com
Entrance off Yorkland Blvd south of Sheppard Ave east of the DVP

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Dennis smith-4

Re: [vwnc] Finding all senders ... bug??

No that at all -- the issue is that there are more than 500 things
matching "ALL" and the IncrementalSearchModule quits at 500.

Not very nice at all since there are numerous references to ALL but
it appears as if there are none!!! This could lead to someone
deleting something or making other changes thinking they have
the correct information, which they do not.

Valloud, Andres wrote:

> Dennis,
>
> You may want to try the "Find References to Symbol..." menu item
> instead. I am not sure if that is the name of the menu item in the
> version you're using, however the behavior is different.
>
> Andres.
>
> -----Original Message-----
> From: [hidden email] [mailto:[hidden email]] On
> Behalf Of Dennis Smith
> Sent: Tuesday, January 06, 2009 12:36 PM
> To: VWNC,
> Subject: [vwnc] Finding all senders ... bug??
>
> I have a symbol #ALL all uppercase.
> When I try and find senders to find all references, I get
> #All
> but no references to ALL -- there are quite a few.
>
>

--
Dennis Smith +1 416.798.7948
Cherniak Software Development Corporation Fax: +1 416.798.0948
509-2001 Sheppard Avenue East [hidden email]
Toronto, ON M2J 4Z8 sip:[hidden email]
Canada http://www.CherniakSoftware.com
Entrance off Yorkland Blvd south of Sheppard Ave east of the DVP

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Boris Popov, DeepCove Labs (SNN)

Re: [vwnc] Finding all senders ... bug??

Why don't you use Rewrite Tool on your bundle and just search for,

#ALL

This will certainly let you see more than 500 methods.

-Boris

--
+1.604.689.0322
DeepCove Labs Ltd.
4th floor 595 Howe Street
Vancouver, Canada V6C 2T5
http://tinyurl.com/r7uw4

[hidden email]

CONFIDENTIALITY NOTICE

This email is intended only for the persons named in the message header.
Unless otherwise indicated, it contains information that is private and
confidential. If you have received it in error, please notify the sender
and delete the entire message including any attachments.

Thank you.
-----Original Message-----
From: [hidden email] [mailto:[hidden email]] On
Behalf Of Dennis Smith
Sent: Tuesday, January 06, 2009 2:59 PM
To: Valloud, Andres
Cc: VWNC,
Subject: Re: [vwnc] Finding all senders ... bug??

No that at all -- the issue is that there are more than 500 things
matching "ALL" and the IncrementalSearchModule quits at 500.

Not very nice at all since there are numerous references to ALL but it
appears as if there are none!!! This could lead to someone deleting
something or making other changes thinking they have the correct
information, which they do not.

Valloud, Andres wrote:

Dennis smith-4

Re: [vwnc] Finding all senders ... bug??

My bigger concern is that there is indication that matches might exist
but not show -- had I not looked at the code I would not know known.

I figure if there are too many to show, one should show NONE, with some kind
of error message showing.
Then the number should be
- bigger
-- configurable
- changeable at run time
some or all of the above.

Boris Popov wrote:
> Why don't you use Rewrite Tool on your bundle and just search for,
>
> #ALL
>
> This will certainly let you see more than 500 methods.
>
> -Boris
>
>

--
Dennis Smith +1 416.798.7948
Cherniak Software Development Corporation Fax: +1 416.798.0948
509-2001 Sheppard Avenue East [hidden email]
Toronto, ON M2J 4Z8 sip:[hidden email]
Canada http://www.CherniakSoftware.com
Entrance off Yorkland Blvd south of Sheppard Ave east of the DVP

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Andres Valloud-6

Re: [vwnc] Finding all senders ... bug??

In reply to this post by Dennis smith-4

Hmmm, I think that's because those search modules append $* at the end
of the pattern by default. Sometimes I wish they didn't. If that was
the case, then typing 'ALL' would match only symbols 3 characters long
where the first one is $A, and the rest are $L.

On the other hand, I'd venture that most of the time one actually wants
a trailing $*... maybe the thing should show exact matches first
followed by partial match suggestions?

Andres.

-----Original Message-----
From: Dennis Smith [mailto:[hidden email]]
Sent: Tuesday, January 06, 2009 2:59 PM
To: Valloud, Andres
Cc: VWNC,
Subject: Re: [vwnc] Finding all senders ... bug??

No that at all -- the issue is that there are more than 500 things
matching "ALL" and the IncrementalSearchModule quits at 500.

Not very nice at all since there are numerous references to ALL but it
appears as if there are none!!! This could lead to someone deleting
something or making other changes thinking they have the correct
information, which they do not.

Valloud, Andres wrote:

Dennis smith-4

Re: [vwnc] Finding all senders ... bug??

I had in fact made a mod (which is why I did find the 500 issue).
I had modified the compare method to take a trailing $ as a terminator,
but when using it I never really liked it -- but don't know anything better.
Don't like adding a checkbox to the window much either.

So are really a couple of issues
    1. really need to let the poor user know that the list got truncated.
          My own version right now does not truncate, if it gets more than the
          max (I set mine to 2000, not 500) then it just shows
          <too many matches> -- nothing else, no first 2000 items at all.
    2. how to make the match shorter by allowing the user to prevent the
          trailing "*". I guess my trailing "$" is not all that bad but I had in fact
          forgotten it.

Valloud, Andres wrote:

Hmmm, I think that's because those search modules append $* at the end
of the pattern by default.  Sometimes I wish they didn't.  If that was
the case, then typing 'ALL' would match only symbols 3 characters long
where the first one is $A, and the rest are $L.

On the other hand, I'd venture that most of the time one actually wants
a trailing $*... maybe the thing should show exact matches first
followed by partial match suggestions?

Andres.

-----Original Message-----
From: Dennis Smith [[hidden email]] 
Sent: Tuesday, January 06, 2009 2:59 PM
To: Valloud, Andres
Cc: VWNC, 
Subject: Re: [vwnc] Finding all senders ... bug??

No that at all -- the issue is that there are more than 500 things
matching "ALL" and the IncrementalSearchModule quits at 500.

Not very nice at all since there are numerous references to ALL but it
appears as if there are none!!!  This could lead to someone deleting
something or making other changes thinking they have the correct
information, which they do not.


Valloud, Andres wrote:

Dennis,

You may want to try the "Find References to Symbol..." menu item 
instead.  I am not sure if that is the name of the menu item in the 
version you're using, however the behavior is different.

Andres. 

-----Original Message-----
From: [hidden email] [[hidden email]] On 
Behalf Of Dennis Smith
Sent: Tuesday, January 06, 2009 12:36 PM
To: VWNC,
Subject: [vwnc] Finding all senders ... bug??

I have a symbol  #ALL  all uppercase.
When I try and find senders to find all references, I get
    #All
but no references to ALL -- there are quite a few.

-- 
Dennis Smith                 		         +1 416.798.7948
Cherniak Software Development Corporation   Fax: +1 416.798.0948
509-2001 Sheppard Avenue East        [hidden email]
Toronto, ON M2J 4Z8              <a class="moz-txt-link-freetext" href="sip:dennis@CherniakSoftware.com">sip:dennis@...
Canada			         http://www.CherniakSoftware.com
Entrance off Yorkland Blvd south of Sheppard Ave east of the DVP

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Runar Jordahl

Re: [vwnc] Finding all senders ... bug??

In reply to this post by Dennis smith-4

If this problem is related to the fact that the dialog searches
symbols, and not only methods, the following blog entry might be of
interest:

http://www.cincomsmalltalk.com/userblogs/runarj/blogView?showComments=true&printTitle=VisualWorks_Incremental_Method_Search_Returns_False_Hits&entry=3327668738

Since writing the post, I improved the code. The code has been tested in 7.5.

findSelectorsMatching: aString
"Override to prevent showing symbols that are not selectors. Read
http://www.cincomsmalltalk.com/userblogs/runarj/blogView?showComments=true&printTitle=VisualWorks_Incremental_Method_Search_Returns_False_Hits&entry=3327668738
for details."

| results counter pattern |

aString isEmpty ifTrue: [^Array new].
results := OrderedCollection new: 100.
counter := 0.
pattern := aString last = $*
ifTrue: [
results addFirst: #*.
aString]
ifFalse: [aString , '*'].
Symbol allSubInstancesDo: [:each |
((self does: each lookLikeSelectorMatching: pattern) and: [
(Refactory.Browser.SelectorEnvironment
implementorsOf: each
in: Refactory.Browser.BrowserEnvironment new) isEmpty not]) ifTrue: [
results add: each.
counter := counter + 1.
counter > 500 ifTrue: [^results asSortedCollection]]].
^results asSortedCollection
_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Joachim Geidel

Re: [vwnc] Finding all senders ... bug??

In reply to this post by Andres Valloud-6

Re: [vwnc] Finding all senders ... bug?? I just tried it. Strangely enough, the behavior is different in my various images. In a vanilla VW 7.6 image, it's as described by Dennis, #ALL is not shown. In my VW 7.6 development image with various add-ons loaded, ALL appears right at the top of the list, as in this screenshot:

So the solution seems to be hidden somewhere in the parcels or contrib directories, or in the public repository... ;-) I have no idea which parcel did the trick. Andres, if you need it, I can send you a list of what’s loaded in my dev image.

Cheers,
Joachim Geidel

Am 07.01.09 04:37 schrieb Valloud, Andres:

> Hmmm, I think that's because those search modules append $* at the end
> of the pattern by default. Sometimes I wish they didn't. If that was
> the case, then typing 'ALL' would match only symbols 3 characters long
> where the first one is $A, and the rest are $L.
>
> On the other hand, I'd venture that most of the time one actually wants
> a trailing $*... maybe the thing should show exact matches first
> followed by partial match suggestions?
>
> Andres.
>
> -----Original Message-----
> From: Dennis Smith [[hidden email]]
> Sent: Tuesday, January 06, 2009 2:59 PM
> To: Valloud, Andres
> Cc: VWNC,
> Subject: Re: [vwnc] Finding all senders ... bug??
>
> No that at all -- the issue is that there are more than 500 things
> matching "ALL" and the IncrementalSearchModule quits at 500.
>
> Not very nice at all since there are numerous references to ALL but it
> appears as if there are none!!! This could lead to someone deleting
> something or making other changes thinking they have the correct
> information, which they do not.
>
>
> Valloud, Andres wrote:
>> Dennis,
>>
>> You may want to try the "Find References to Symbol..." menu item
>> instead. I am not sure if that is the name of the menu item in the
>> version you're using, however the behavior is different.
>>
>> Andres.
>>
>> -----Original Message-----
>> From: vwnc-bounces@... [[hidden email]] On
>> Behalf Of Dennis Smith
>> Sent: Tuesday, January 06, 2009 12:36 PM
>> To: VWNC,
>> Subject: [vwnc] Finding all senders ... bug??
>>
>> I have a symbol #ALL all uppercase.
>> When I try and find senders to find all references, I get
>> #All
>> but no references to ALL -- there are quite a few.
>>
>>

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Reinout Heeck

Re: [vwnc] Finding all senders ... bug??

In reply to this post by Dennis smith-4

Dennis Smith wrote:
> I had in fact made a mod (which is why I did find the 500 issue).
> I had modified the compare method to take a trailing $ as a terminator,
> but when using it I never really liked it -- but don't know anything better.
> Don't like adding a checkbox to the window much either.

Here's how I would like to see this handled:

When the dialog first opens I would like the input field to contain an
asterisk and the insertion point located in front of that asterisk.
The list remains empty - no search is fired off.

Only after I alter the content of the input field (insert a character or
delete the asterisk) for the first time will searches be fired that
populate the list.

To be clear: no implicit asterisks are in play in this scheme, what you
see in the input field is what you get -- no surprises.

----------------

Aside:

we augmented the browser to have such a input field above the packages
list (to reduce the list of shown packages to something manageable).
We found that in this use case it is advantageous to support an 'or'
operator. E.g:

'* config|* lineup'
'MyProject*|MyBaseExtensionsForProject*'

etc, etc...

R
-

>
> So are really a couple of issues
> 1. really need to let the poor user know that the list got truncated.
> My own version right now does not truncate, if it gets more
> than the
> max (I set mine to 2000, not 500) then it just shows
> <too many matches> -- nothing else, no first 2000 items at all.
> 2. how to make the match shorter by allowing the user to prevent the
> trailing "*". I guess my trailing "$" is not all that bad but
> I had in fact
> forgotten it.
>
> Valloud, Andres wrote:
>> Hmmm, I think that's because those search modules append $* at the end
>> of the pattern by default. Sometimes I wish they didn't. If that was
>> the case, then typing 'ALL' would match only symbols 3 characters long
>> where the first one is $A, and the rest are $L.
>>
>> On the other hand, I'd venture that most of the time one actually wants
>> a trailing $*... maybe the thing should show exact matches first
>> followed by partial match suggestions?
>>
>> Andres.
>>
>> -----Original Message-----
>> From: Dennis Smith [mailto:[hidden email]]
>> Sent: Tuesday, January 06, 2009 2:59 PM
>> To: Valloud, Andres
>> Cc: VWNC,
>> Subject: Re: [vwnc] Finding all senders ... bug??
>>
>> No that at all -- the issue is that there are more than 500 things
>> matching "ALL" and the IncrementalSearchModule quits at 500.
>>
>> Not very nice at all since there are numerous references to ALL but it
>> appears as if there are none!!! This could lead to someone deleting
>> something or making other changes thinking they have the correct
>> information, which they do not.
>>
>>
>> Valloud, Andres wrote:
>>
>>> Dennis,
>>>
>>> You may want to try the "Find References to Symbol..." menu item
>>> instead. I am not sure if that is the name of the menu item in the
>>> version you're using, however the behavior is different.
>>>
>>> Andres.
>>>
>>> -----Original Message-----
>>> From: [hidden email] [mailto:[hidden email]] On
>>> Behalf Of Dennis Smith
>>> Sent: Tuesday, January 06, 2009 12:36 PM
>>> To: VWNC,
>>> Subject: [vwnc] Finding all senders ... bug??
>>>
>>> I have a symbol #ALL all uppercase.
>>> When I try and find senders to find all references, I get
>>> #All
>>> but no references to ALL -- there are quite a few.
>>>
>>>
>>>
>>
>>
>
> --
> Dennis Smith +1 416.798.7948
> Cherniak Software Development Corporation Fax: +1 416.798.0948
> 509-2001 Sheppard Avenue East [hidden email]
> Toronto, ON M2J 4Z8 sip:[hidden email]
> Canada http://www.CherniakSoftware.com
> Entrance off Yorkland Blvd south of Sheppard Ave east of the DVP
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> vwnc mailing list
> [hidden email]
> http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Travis Griggs-3

Re: [vwnc] Finding all senders ... bug??

In reply to this post by Joachim Geidel

On Jan 7, 2009, at 12:29 AM, Joachim Geidel wrote:

> I just tried it. Strangely enough, the behavior is different in my
> various images. In a vanilla VW 7.6 image, it's as described by
> Dennis, #ALL is not shown. In my VW 7.6 development image with
> various add-ons loaded, ALL appears right at the top of the list, as
> in this screenshot:

I think the reason you see ALL at the top in 7.6+ is the introduction
and use of the UCA (Unicode Collation Algorithm).

As for other thread sentiments, the list should indicate somehow that
it is partial (55976 created).

--
Travis Griggs
Objologist
"An idea, like a ghost, must be spoken to a little before it will
explain itself." - Charles Dickens

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Joachim Geidel

Re: [vwnc] Finding all senders ... bug??

Umm, my fault. There is no reference to #ALL in visual.im, that's why it is
not in the list. There is a literal #ALL in a method of MessageTally
(Advanced Tools) which explains why it's found in my development images.
ALL shows up both in VW 7.6 and 7.7 when it is referenced in a method, but
the order is ALL - All - all in 7.6 and all - All - ALL in 7.7, which is
probably due to the introduction of the UCA.

As Dennis found, IncrementalSearchModule
class>>findReferencedSymbolsMatching: is responsible for the odd behavior.
The counterintuitive behavior is that it randomly selects 500 matches when
there are more.

Simply indicating that the list is partial is not sufficient IMO. The search
dialog only activates the OK button when a list entry is selected. This
means that you can't search for a sender of a selector which is not in the
list. Possible solutions:
- either drop the restriction to 500 elements,
- or activate the OK button also when there is a non-empty pattern without
wildcards, but no list entry selected (and search for the pattern instead of
the selection in the list in this case),
- or always look for exact matches first such that they are always in the
list.

Cheers,
Joachim Geidel

Am 07.01.09 19:58 schrieb Travis Griggs:

> On Jan 7, 2009, at 12:29 AM, Joachim Geidel wrote:
>
>> I just tried it. Strangely enough, the behavior is different in my
>> various images. In a vanilla VW 7.6 image, it's as described by
>> Dennis, #ALL is not shown. In my VW 7.6 development image with
>> various add-ons loaded, ALL appears right at the top of the list, as
>> in this screenshot:
>
>
> I think the reason you see ALL at the top in 7.6+ is the introduction
> and use of the UCA (Unicode Collation Algorithm).
>
> As for other thread sentiments, the list should indicate somehow that
> it is partial (55976 created).
>
> --
> Travis Griggs
> Objologist
> "An idea, like a ghost, must be spoken to a little before it will
> explain itself." - Charles Dickens
>
> _______________________________________________
> vwnc mailing list
> [hidden email]
> http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Andres Valloud-6

Re: [vwnc] Finding all senders ... bug??

Maybe part of the problem is that if you enter '*', then every symbol
matches and so processing the list can be burdensome... I don't quite
recall, but I thought the filtering was forked into another process. If
the size limit is dropped, maybe there should be some indication that
the searching is taking place? Also, to avoid starting to display many
many symbols when one starts typing with $e (most frequent letter in
English), perhaps one could apply a delay of (say) 0.5s between the last
keystroke and the fork?

Just thoughts... I am not sure how much of a mess this would make.

Side comment: is the UCA necessary for selectors? If not, is the list
sorting done with the UCA or with the previous sorting mechanism?
Perhaps a change here could speed stuff up...

Andres.

-----Original Message-----
From: [hidden email] [mailto:[hidden email]] On
Behalf Of Joachim Geidel
Sent: Wednesday, January 07, 2009 12:57 PM
To: Griggs, Travis; VWNC,
Subject: Re: [vwnc] Finding all senders ... bug??

Umm, my fault. There is no reference to #ALL in visual.im, that's why it
is not in the list. There is a literal #ALL in a method of MessageTally
(Advanced Tools) which explains why it's found in my development images.
ALL shows up both in VW 7.6 and 7.7 when it is referenced in a method,
but the order is ALL - All - all in 7.6 and all - All - ALL in 7.7,
which is probably due to the introduction of the UCA.

As Dennis found, IncrementalSearchModule
class>>findReferencedSymbolsMatching: is responsible for the odd
behavior.
The counterintuitive behavior is that it randomly selects 500 matches
when there are more.

Simply indicating that the list is partial is not sufficient IMO. The
search dialog only activates the OK button when a list entry is
selected. This means that you can't search for a sender of a selector
which is not in the list. Possible solutions:
- either drop the restriction to 500 elements,
- or activate the OK button also when there is a non-empty pattern
without wildcards, but no list entry selected (and search for the
pattern instead of the selection in the list in this case),
- or always look for exact matches first such that they are always in
the list.

Cheers,
Joachim Geidel

Am 07.01.09 19:58 schrieb Travis Griggs:

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Nowak, Helge

Re: [vwnc] Finding all senders ... bug??

In reply to this post by Reinout Heeck

+1

-----Ursprüngliche Nachricht-----
Von: [hidden email] [mailto:[hidden email]] Im Auftrag von Reinout Heeck
Gesendet: Mittwoch, 7. Januar 2009 13:59
An: vwnc >> "VWNC, "
Betreff: Re: [vwnc] Finding all senders ... bug??

Dennis Smith wrote:
> I had in fact made a mod (which is why I did find the 500 issue).
> I had modified the compare method to take a trailing $ as a
> terminator, but when using it I never really liked it -- but don't know anything better.
> Don't like adding a checkbox to the window much either.

Here's how I would like to see this handled:

When the dialog first opens I would like the input field to contain an asterisk and the insertion point located in front of that asterisk.
The list remains empty - no search is fired off.

Only after I alter the content of the input field (insert a character or
delete the asterisk) for the first time will searches be fired that
populate the list.

To be clear: no implicit asterisks are in play in this scheme, what you
see in the input field is what you get -- no surprises.

----------------

Aside:

we augmented the browser to have such a input field above the packages
list (to reduce the list of shown packages to something manageable).
We found that in this use case it is advantageous to support an 'or'
operator. E.g:

'* config|* lineup'
'MyProject*|MyBaseExtensionsForProject*'

etc, etc...

R
-