Smalltalk › Cincom › VisualWorks

[vwnc] Glorp proxy equality bug.

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

Steve Aldred-3

[vwnc] Glorp proxy equality bug.

Using the Glorp that comes with VW7.6..

If you try to compare two proxies the answer will always be false.

This is because in AbstractProxy we have

= anObject
"In VA we inherit this as identity. Need to override"
^self getValue = anObject.

when it should be reversed to force resolution of anObject when it is
also a proxy:

= anObject
"Comparison order reversed in order to ensure that comparing two
proxies works"
^anObject = self getValue

Attached is a package with the fix and also #~= which needs to do the
same thing for the same reason.

cheers
Steve A

<?xml version="1.0"?>

<st-source>
<time-stamp>From VisualWorksÂ® NonCommercial, 7.6 of March 3, 2008 on October 23, 2008 at 11:25:34 am</time-stamp>


<methods>
<class-id>Glorp.AbstractProxy</class-id> <category>accessing</category>

<body package="GlorpProxyEqualityFix" selector="=">= anObject
"Comparison order reversed in order to ensure that comparing two proxies works"
^anObject = self getValue</body>

<body package="GlorpProxyEqualityFix" selector="~=">~= anObject
"Comparison order reversed in order to ensure that comparing two proxies works"
^anObject ~= self getValue</body>
</methods>

</st-source>

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Alan Knight-2

Re: [vwnc] Glorp proxy equality bug.

Well, it will be false if the objects in question don't define any equality, and fall back to identity. Still, it seems reasonable enough.

~= I think ought to be implementable just as
(self = anObject) not
the way it could be defined for anything, it's just not supplied by proxy normally.

Created AR 55542 for it.

At 08:33 PM 10/22/2008, Steve Aldred wrote:

Using the Glorp that comes with VW7.6..

If you try to compare two proxies the answer will always be false.

This is because in AbstractProxy we have

= anObject
   "In VA we inherit this as identity. Need to override"
   ^self getValue = anObject.

when it should be reversed to force resolution of anObject when it is also a proxy:

= anObject
   "Comparison order reversed in order to ensure that comparing two proxies works"
   ^anObject = self getValue

Attached is a package with the fix and also #~= which needs to do the same thing for the same reason.

cheers
Steve A

<?xml version="1.0"?>

<st-source>
<time-stamp>From VisualWorksÂ® NonCommercial, 7.6 of March 3, 2008 on October 23, 2008 at 11:25:34 am</time-stamp>


<methods>
<class-id>Glorp.AbstractProxy</class-id> <category>accessing</category>

<body package="GlorpProxyEqualityFix" selector="=">= anObject
         "Comparison order reversed in order to ensure that comparing two proxies works"
        ^anObject = self getValue</body>

<body package="GlorpProxyEqualityFix" selector="~=">~= anObject
         "Comparison order reversed in order to ensure that comparing two proxies works"
        ^anObject ~= self getValue</body>
</methods>

</st-source>

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Alan Knight [|], Engineering Manager, Cincom Smalltalk

[hidden email]

http://www.cincom.com/smalltalk

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

Michael Lucas-Smith-2

Re: [vwnc] Glorp proxy equality bug.

In reply to this post by Steve Aldred-3

Cheers Steve,

This has been addressed differently in newer versions of Glorp,
available in public store.

Cheers,
Michael

Steve Aldred wrote:

> Using the Glorp that comes with VW7.6..
>
> If you try to compare two proxies the answer will always be false.
>
> This is because in AbstractProxy we have
>
> = anObject
> "In VA we inherit this as identity. Need to override"
> ^self getValue = anObject.
>
>
> when it should be reversed to force resolution of anObject when it is
> also a proxy:
>
> = anObject
> "Comparison order reversed in order to ensure that comparing two
> proxies works"
> ^anObject = self getValue
>
>
> Attached is a package with the fix and also #~= which needs to do the
> same thing for the same reason.
>
> cheers
> Steve A
> ------------------------------------------------------------------------
>
> _______________________________________________
> vwnc mailing list
> [hidden email]
> http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc