[vwnc] Need another HTTP AR

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[vwnc] Need another HTTP AR

Chris Winemiller
Cincom,

You need to enter another AR against an Opentalk.HTTPTransport bug that is in VW 7.6 (and was in VW 7.4.1, for that matter).

Bug description: BasicObjectAdaptor''s #receivingPackage:size:in: trigger event gets posted twice.

This trigger event gets posted twice when the image is responding to a "100-Continue" message.

The bug is in Opentalk.HTTPTransport (in the Opentalk-HTTP package), in the instance method readTransportPackage.  In there, the 100-Continue handling code must be changed from :

    ^httpPkg isResponse
        ifTrue: [    [    [    [ HttpException handleResponse: httpPkg
                        ] on: HttpInformationalError do: [ :ex |
                            "Handle the 100-Continue"
                            ex return: self receiveTransportPackage ]
                    ] on: HttpClientError, HttpServerError do: [ :ex |
                        ex return: httpPkg.
                        "marshaler handleResponseException: ex" ]

to:

    ^httpPkg isResponse
        ifTrue: [    [    [    [ HttpException handleResponse: httpPkg
                        ] on: HttpInformationalError do: [ :ex |
                            "Handle the 100-Continue"
                            ex return: self readTransportPackage ]
                    ] on: HttpClientError, HttpServerError do: [ :ex |
                        ex return: httpPkg.
                        "marshaler handleResponseException: ex" ]

I have applied this fix in my own images and verified corrected behavior.  My images use the Opentalk-HTTP package from VW 7.4.1, but I verified that this particular method in VW 7.6 is the same.

Please enter an AR for this.

Chris

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
Reply | Threaded
Open this post in threaded view
|

Re: [vwnc] Need another HTTP AR

kobetic
This was already reported via support. The AR is 54832 Opentalk.BasicObjectAdaptor posts its #receivingPackage:size:in: trigger event twice.

Thanks,

Martin

Chris Winemiller wrote:

> Cincom,
>
> You need to enter another AR against an Opentalk.HTTPTransport bug that
> is in VW 7.6 (and was in VW 7.4.1, for that matter).
>
> Bug description: BasicObjectAdaptor''s #receivingPackage:size:in:
> trigger event gets posted twice.
>
> This trigger event gets posted twice when the image is responding to a
> "100-Continue" message.
>
> The bug is in Opentalk.HTTPTransport (in the Opentalk-HTTP package), in
> the instance method *readTransportPackage*.  In there, the 100-Continue
> handling code must be changed from :
>
>     ^httpPkg isResponse
>         ifTrue: [    [    [    [ HttpException handleResponse: httpPkg
>                         ] on: HttpInformationalError do: [ :ex |
>                             "Handle the 100-Continue"
>                             ex return: self receiveTransportPackage ]
>                     ] on: HttpClientError, HttpServerError do: [ :ex |
>                         ex return: httpPkg.
>                         "marshaler handleResponseException: ex" ]
>
> to:
>
>     ^httpPkg isResponse
>         ifTrue: [    [    [    [ HttpException handleResponse: httpPkg
>                         ] on: HttpInformationalError do: [ :ex |
>                             "Handle the 100-Continue"
>                             ex return: self readTransportPackage ]
>                     ] on: HttpClientError, HttpServerError do: [ :ex |
>                         ex return: httpPkg.
>                         "marshaler handleResponseException: ex" ]
>
> I have applied this fix in my own images and verified corrected
> behavior.  My images use the Opentalk-HTTP package from VW 7.4.1, but I
> verified that this particular method in VW 7.6 is the same.
>
> Please enter an AR for this.
>
> Chris
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> vwnc mailing list
> [hidden email]
> http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
Reply | Threaded
Open this post in threaded view
|

Re: [vwnc] Need another HTTP AR

Chris Winemiller
Ah! OK.  Thanks.

Chris

Martin Kobetic wrote:

> This was already reported via support. The AR is 54832
> Opentalk.BasicObjectAdaptor posts its #receivingPackage:size:in:
> trigger event twice.
>
> Thanks,
>
> Martin
>
> Chris Winemiller wrote:
>> Cincom,
>>
>> You need to enter another AR against an Opentalk.HTTPTransport bug
>> that is in VW 7.6 (and was in VW 7.4.1, for that matter).
>>
>> Bug description: BasicObjectAdaptor''s #receivingPackage:size:in:
>> trigger event gets posted twice.
>>
>> This trigger event gets posted twice when the image is responding to
>> a "100-Continue" message.
>>
>> The bug is in Opentalk.HTTPTransport (in the Opentalk-HTTP package),
>> in the instance method *readTransportPackage*.  In there, the
>> 100-Continue handling code must be changed from :
>>
>>     ^httpPkg isResponse
>>         ifTrue: [    [    [    [ HttpException handleResponse: httpPkg
>>                         ] on: HttpInformationalError do: [ :ex |
>>                             "Handle the 100-Continue"
>>                             ex return: self receiveTransportPackage ]
>>                     ] on: HttpClientError, HttpServerError do: [ :ex |
>>                         ex return: httpPkg.
>>                         "marshaler handleResponseException: ex" ]
>>
>> to:
>>
>>     ^httpPkg isResponse
>>         ifTrue: [    [    [    [ HttpException handleResponse: httpPkg
>>                         ] on: HttpInformationalError do: [ :ex |
>>                             "Handle the 100-Continue"
>>                             ex return: self readTransportPackage ]
>>                     ] on: HttpClientError, HttpServerError do: [ :ex |
>>                         ex return: httpPkg.
>>                         "marshaler handleResponseException: ex" ]
>>
>> I have applied this fix in my own images and verified corrected
>> behavior.  My images use the Opentalk-HTTP package from VW 7.4.1, but
>> I verified that this particular method in VW 7.6 is the same.
>>
>> Please enter an AR for this.
>>
>> Chris

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc