[vwnc] RBCH: Sharing the controller
Locked
 
|
Hi,
I'd like to propose a change to RBCodeHighlighting. Michael Lucas-Smith and myself have been playing with adding spell-checking support to VW a while back, much along the same lines as RBCH does for code. However as we found out, RBCH as is isn't written to share the highlighting controller. So the options were to either have to pick one or the other for any given text pane or teach RBCH to share. So I've spent some time extracting the 'highlighting controller' bit out of RBCH and making it support multiple 'highlighters'. The result are the following packages: 1) TextEditorHighlighting which now owns the highlighting controller: The controller supports multiple highlighters, each will get a chance to do its highlighting on the editor text. The highlighters should be written so that they do their best to not trash any other highlighting that's already present in the text. The order in which the highlighters will be invoked is unspecified. A highlighter can be anything that can respond to the #highlight: callback, e.g. the app-model that hosts the highlighting controller. However to simplify cleanup it might be easier to subclass the provided Highlighter class. Your pre-unload action can then simply collect all instances of your highlighter and send preUnload to each. E.g. the Spellchecker-ToolsIntegration package adds SpellingHighlighter. To highlight spelling mistakes simply attach a highlighter as follows: SpellingHighlighter on: aHighlightingController. The post-load method then simply collects all instances of the spelling highlighter. SpellingHighlighter allInstances do: [ :h | h preUnload ] 2) A new version of the RBCodeHighlighting package, the "+ spellchecking" branch, currently at (7.7 - 2 + spellchecking 10) 3) Spellchecker-ToolsIntegration which adds a reusable SpellingHighlighter and uses it to check spelling in the comment tool. It will check spelling of everything including the keyword constituents of selectors (splitting on camel-case boundaries). This takes advantage of Michael's excellent Spellchecker2, which is amazingly good and compact at the same time (that's including the english dictionary). BTW, it's very easy to add the spellchecking support to your own tools, in fact I'm using it to spell-check this email as I'm writing it. So, what I'm ultimately after is that, similarly to Tom Hawker, I'd like to make a change in RBCH. Since the leadership of RBCH is a bit unclear at this point, it seems the best way forward is to poll/lobby the community on this list to see if there would be a lot of push-back integrating this in. Or who knows, maybe there will be an outright support :-). If there isn't an outcry against the change, I'll merge it into the trunk at which point it can be included in VW7.7 builds. Same would apply to Tom's changes. Please, let me know if there's a different process that I should be following instead. Thanks, Martin _______________________________________________ vwnc mailing list [hidden email] http://lists.cs.uiuc.edu/mailman/listinfo/vwnc |
|
|
Hi, Martin
nothing against, but I hope it will be possible to enable/disable every single feature, for at least 2 reason: 1) speed on some machine ad 2) not everywhere English is the native language... thanks Giorgio On Sun, Dec 7, 2008 at 4:30 PM, <[hidden email]> wrote: Hi, _______________________________________________ vwnc mailing list [hidden email] http://lists.cs.uiuc.edu/mailman/listinfo/vwnc |
Re: [vwnc] RBCH: Sharing the controller
|
|
In reply to this post by kobetic
Just a word regarding the spellchecker: I've tried the 63.4 branch of
RBCodeHighlighting with latest spellchecker packages. I think the spellchecker should not spellcheck the source-code. You often have words that are not english at all, but part of your application. Or appreviations or something. These things end up being underlined as they're incorrect. That's really distracting imho. If only strings and comments were spellchecked, this would be a great help. I don't want my source-code spellchecked for english. If it's spellchecked for Smalltalk that's perfect and helps much more, and that's exactly what the code highlighting was made for in first place ;-). just my 2ct. Karsten [hidden email] wrote: > Hi, > > I'd like to propose a change to RBCodeHighlighting. Michael Lucas-Smith and myself have been playing with adding spell-checking support to VW a while back, much along the same lines as RBCH does for code. However as we found out, RBCH as is isn't written to share the highlighting controller. So the options were to either have to pick one or the other for any given text pane or teach RBCH to share. So I've spent some time extracting the 'highlighting controller' bit out of RBCH and making it support multiple 'highlighters'. The result are the following packages: > > 1) TextEditorHighlighting which now owns the highlighting controller: > > The controller supports multiple highlighters, each will get a chance to do its highlighting on the editor text. The highlighters should be written so that they do their best to not trash any other highlighting that's already present in the text. The order in which the highlighters will be invoked is unspecified. > > A highlighter can be anything that can respond to the #highlight: callback, e.g. the app-model that hosts the highlighting controller. However to simplify cleanup it might be easier to subclass the provided Highlighter class. Your pre-unload action can then simply collect all instances of your highlighter and send preUnload to each. E.g. the Spellchecker-ToolsIntegration package adds SpellingHighlighter. To highlight spelling mistakes simply attach a highlighter as follows: > > SpellingHighlighter on: aHighlightingController. > > The post-load method then simply collects all instances of the spelling highlighter. > > SpellingHighlighter allInstances do: [ :h | h preUnload ] > > 2) A new version of the RBCodeHighlighting package, the "+ spellchecking" branch, currently at (7.7 - 2 + spellchecking 10) > > 3) Spellchecker-ToolsIntegration which adds a reusable SpellingHighlighter and uses it to check spelling in the comment tool. It will check spelling of everything including the keyword constituents of selectors (splitting on camel-case boundaries). This takes advantage of Michael's excellent Spellchecker2, which is amazingly good and compact at the same time (that's including the english dictionary). > > BTW, it's very easy to add the spellchecking support to your own tools, in fact I'm using it to spell-check this email as I'm writing it. > > So, what I'm ultimately after is that, similarly to Tom Hawker, I'd like to make a change in RBCH. Since the leadership of RBCH is a bit unclear at this point, it seems the best way forward is to poll/lobby the community on this list to see if there would be a lot of push-back integrating this in. Or who knows, maybe there will be an outright support :-). If there isn't an outcry against the change, I'll merge it into the trunk at which point it can be included in VW7.7 builds. Same would apply to Tom's changes. Please, let me know if there's a different process that I should be following instead. > > Thanks, > > Martin > > _______________________________________________ > vwnc mailing list > [hidden email] > http://lists.cs.uiuc.edu/mailman/listinfo/vwnc > > > -- Karsten Kusche - Dipl.Inf. - [hidden email] Tel: +49 3496 21 43 29 Georg Heeg eK - Köthen Handelsregister: Amtsgericht Dortmund A 12812 _______________________________________________ vwnc mailing list [hidden email] http://lists.cs.uiuc.edu/mailman/listinfo/vwnc |
|
|
In reply to this post by kobetic
"giorgio ferraris"<[hidden email]> wrote:
> Hi, Martin > nothing against, but I hope it will be possible to enable/disable every > single feature, for at least 2 reason: 1) speed on some machine ad 2) not > everywhere English is the native language... > > thanks > > Giorgio Hi Giorgio, Nothing changes in this regard. If you don't want code highlighting don't load RBCH (or use its built-in settings the same way as before). If you don't want spellchecking in comments, don't load Spellchecker-ToolsIntegration. Of course I could add a setting there, but at this point it seems redundant. Cheers, Martin _______________________________________________ vwnc mailing list [hidden email] http://lists.cs.uiuc.edu/mailman/listinfo/vwnc |
|
|
In reply to this post by kobetic
I should add that I did make sure all the packages I mentioned are un-loadable even with browsers open.
[hidden email] wrote: > Nothing changes in this regard. If you don't want code highlighting don't load RBCH (or use its built-in settings the same way as before). If you don't want spellchecking in comments, don't load Spellchecker-ToolsIntegration. Of course I could add a setting there, but at this point it seems redundant. _______________________________________________ vwnc mailing list [hidden email] http://lists.cs.uiuc.edu/mailman/listinfo/vwnc |
|
|
In reply to this post by kobetic
Hi Karsten,
That is different now, 63.4 was still quite experimental. I have to admit that I kinda like having my code spellchecked too, it's interesting to see how much is misspelled even in base VW, although arguably mostly in various embedded method comments. But we did get negative feedback on those early versions. So the latest Spellchecking-ToolsIntegration only checks package/class/... comments. I might add code spellcheck back eventually, but it will have to be a bit smarter and it would definitely be with a setting to turn it off. Martin Karsten<[hidden email]> wrote: > Just a word regarding the spellchecker: I've tried the 63.4 branch of > RBCodeHighlighting with latest spellchecker packages. I think the > spellchecker should not spellcheck the source-code. You often have words > that are not english at all, but part of your application. Or > appreviations or something. These things end up being underlined as > they're incorrect. That's really distracting imho. > > If only strings and comments were spellchecked, this would be a great > help. I don't want my source-code spellchecked for english. If it's > spellchecked for Smalltalk that's perfect and helps much more, and > that's exactly what the code highlighting was made for in first place ;-). > > just my 2ct. > Karsten > > > > [hidden email] wrote: > > Hi, > > > > I'd like to propose a change to RBCodeHighlighting. Michael Lucas-Smith and myself have been playing with adding spell-checking support to VW a while back, much along the same lines as RBCH does for code. However as we found out, RBCH as is isn't written to share the highlighting controller. So the options were to either have to pick one or the other for any given text pane or teach RBCH to share. So I've spent some time extracting the 'highlighting controller' bit out of RBCH and making it support multiple 'highlighters'. The result are the following packages: > > > > 1) TextEditorHighlighting which now owns the highlighting controller: > > > > The controller supports multiple highlighters, each will get a chance to do its highlighting on the editor text. The highlighters should be written so that they do their best to not trash any other highlighting that's already present in the text. The order in which the highlighters will be invoked is unspecified. > > > > A highlighter can be anything that can respond to the #highlight: callback, e.g. the app-model that hosts the highlighting controller. However to simplify cleanup it might be easier to subclass the provided Highlighter class. Your pre-unload action can then simply collect all instances of your highlighter and send preUnload to each. E.g. the Spellchecker-ToolsIntegration package adds SpellingHighlighter. To highlight spelling mistakes simply attach a highlighter as follows: > > > > SpellingHighlighter on: aHighlightingController. > > > > The post-load method then simply collects all instances of the spelling highlighter. > > > > SpellingHighlighter allInstances do: [ :h | h preUnload ] > > > > 2) A new version of the RBCodeHighlighting package, the "+ spellchecking" branch, currently at (7.7 - 2 + spellchecking 10) > > > > 3) Spellchecker-ToolsIntegration which adds a reusable SpellingHighlighter and uses it to check spelling in the comment tool. It will check spelling of everything including the keyword constituents of selectors (splitting on camel-case boundaries). This takes advantage of Michael's excellent Spellchecker2, which is amazingly good and compact at the same time (that's including the english dictionary). > > > > BTW, it's very easy to add the spellchecking support to your own tools, in fact I'm using it to spell-check this email as I'm writing it. > > > > So, what I'm ultimately after is that, similarly to Tom Hawker, I'd like to make a change in RBCH. Since the leadership of RBCH is a bit unclear at this point, it seems the best way forward is to poll/lobby the community on this list to see if there would be a lot of push-back integrating this in. Or who knows, maybe there will be an outright support :-). If there isn't an outcry against the change, I'll merge it into the trunk at which point it can be included in VW7.7 builds. Same would apply to Tom's changes. Please, let me know if there's a different process that I should be following instead. > > > > Thanks, > > > > Martin > > > > _______________________________________________ > > vwnc mailing list > > [hidden email] > > http://lists.cs.uiuc.edu/mailman/listinfo/vwnc > > > > > > > > -- > Karsten Kusche - Dipl.Inf. - [hidden email] > Tel: +49 3496 21 43 29 > Georg Heeg eK - Köthen > Handelsregister: Amtsgericht Dortmund A 12812 > _______________________________________________ vwnc mailing list [hidden email] http://lists.cs.uiuc.edu/mailman/listinfo/vwnc |
Re: [vwnc] RBCH: Sharing the controller
|
|
In reply to this post by giorgiof
giorgio ferraris escreveu:
> Hi, Martin > nothing against, but I hope it will be possible to enable/disable every > single feature, for at least 2 reason: 1) speed on some machine ad 2) > not everywhere English is the native language... > I want to stress the reason number two... -- Cesar Rabak GNU/Linux User 52247. Get counted: http://counter.li.org/ _______________________________________________ vwnc mailing list [hidden email] http://lists.cs.uiuc.edu/mailman/listinfo/vwnc |
|
|
In reply to this post by kobetic
"Cesar Rabak"<[hidden email]> wrote:
> > nothing against, but I hope it will be possible to enable/disable every > > single feature, for at least 2 reason: 1) speed on some machine ad 2) > > not everywhere English is the native language... > > > I want to stress the reason number two... I'm not a native english speaker either, which is exactly why I find english spellchecker so useful :-). But seriously, as I mentioned before, if you don't want english spellchecking, you don't have to load it. If you want non-english spellchecking, it probably wouldn't be that hard to add, if you have a dictionary (basically just a simple list of all valid words) available. Michael built the english one from a public domain dictionary. If you ask he might be willing to describe the process of compiling it for the Spellchecker2 package. Cheers, Martin _______________________________________________ vwnc mailing list [hidden email] http://lists.cs.uiuc.edu/mailman/listinfo/vwnc |
Re: [vwnc] RBCH: Sharing the controller
|
|
In reply to this post by kobetic
> "giorgio ferraris"<[hidden email]> wrote:
> > I hope it will be possible to enable/disable every single feature > > Nothing changes in this regard. If you don't want code highlighting > don't load RBCH (or use its built-in settings the same way as before). > If you don't want spellchecking in comments, don't load Spellchecker- > ToolsIntegration. Of course I could add a setting there, but at this > point it seems redundant. I don't think a setting is redundant. I think most new users will look at settings to turn things like this on and off. Even for more experienced users, e.g. in a long term Smalltalk company, it could be useful to have a standard image that would include such components, and have individual users change settings. Or then if you want to temporarily turn something off, it seems a pain to have to unload and reload it. Steve _______________________________________________ vwnc mailing list [hidden email] http://lists.cs.uiuc.edu/mailman/listinfo/vwnc |
Re: [vwnc] RBCH: Sharing the controller
|
|
I agree with Steve. After 20+ years in Smalltalk, I've lived with the power, and limitations, of the IDE. Moving to the RB is a tremendous improvement, but it's not yet equivalent to, say, Eclispe. (Don't read that as a wish-list - just a comment on flexibility.)
The ability to have fine-grained control of each of these capabilities is harmonious with the idea of pluggable components. Just because you have a SpellChecker loaded does not mean that you want it to spell check your code or comments. That should be configurable, rather than "assumed" - as is the default dictionary. Such switches are not at all redundant, and in fact there should be more than one switch. Further, you may need multiple sets of those switches based on context. A "master" switch is not unreasonable with additional subordinate switches for individual component usage. This is consistent with the idea of turning on or off highlighting in all browsers in addition to disabling it only for debugger windows. I've added branch 63.4.4 in the public repository which has those controls for highlighting, spell checking, and hyperlinks. Try it and let us know what you think, BUT read the package comments first! Cheers! Tom Hawker -------------------------- Senior Framework Developer -------------------------- Home +1 (408) 274-4128 Office +1 (408) 576-6591 Mobile +1 (408) 835-3643 -----Original Message----- From: [hidden email] [mailto:[hidden email]] On Behalf Of Steven Kelly Sent: Monday, December 08, 2008 6:58 AM To: [hidden email] Subject: Re: [vwnc] RBCH: Sharing the controller > "giorgio ferraris"<[hidden email]> wrote: > > I hope it will be possible to enable/disable every single feature > > Nothing changes in this regard. If you don't want code highlighting > don't load RBCH (or use its built-in settings the same way as before). > If you don't want spellchecking in comments, don't load Spellchecker- > ToolsIntegration. Of course I could add a setting there, but at this > point it seems redundant. I don't think a setting is redundant. I think most new users will look at settings to turn things like this on and off. Even for more experienced users, e.g. in a long term Smalltalk company, it could be useful to have a standard image that would include such components, and have individual users change settings. Or then if you want to temporarily turn something off, it seems a pain to have to unload and reload it. Steve _______________________________________________ vwnc mailing list [hidden email] http://lists.cs.uiuc.edu/mailman/listinfo/vwnc IMPORTANT NOTICE Email from OOCL is confidential and may be legally privileged. If it is not intended for you, please delete it immediately unread. The internet cannot guarantee that this communication is free of viruses, interception or interference and anyone who communicates with us by email is taken to accept the risks in doing so. Without limitation, OOCL and its affiliates accept no liability whatsoever and howsoever arising in connection with the use of this email. Under no circumstances shall this email constitute a binding agreement to carry or for provision of carriage services by OOCL, which is subject to the availability of carrier's equipment and vessels and the terms and conditions of OOCL's standard bill of lading which is also available at http://www.oocl.com. _______________________________________________ vwnc mailing list [hidden email] http://lists.cs.uiuc.edu/mailman/listinfo/vwnc |
|
|
In reply to this post by kobetic
Seems like most of you are quite a bit ahead of me :-). All I really want is to make it possible to have both code highlighted and spelling checked at the same time. I don't aspire to have this included in the base image. That's why I thought that clean load and unload should suffice. But it's certainly no trouble to add a setting as well, so the new version of Spellchecker-ToolsIntegration has it. I decided to add a dedicated page, mostly because the Browser page is already overflowing and I don't want to require code highligting to be loaded just to be able to live on the highlighter settings page. Who knows maybe there will be more setting on the 'Check Spelling' page over time. This might change when Tom's cleanup of RBCH settings go in, and I'm certainly fine with that, as long as the spellchecking side remains independent of the code highlighting side.
> The ability to have fine-grained control of each of these capabilities is harmonious with the idea of pluggable components. Just because you have a SpellChecker loaded does not mean that you want it to spell check your code or comments. I just want to clarify. You don't get spelling checked in comments when you load Spellchecker2. You only get that when you load Spellchecker-ToolsIntegration. Martin _______________________________________________ vwnc mailing list [hidden email] http://lists.cs.uiuc.edu/mailman/listinfo/vwnc |
|
|
Greetings Fellow Smalltalkers,
I printed up 500 of the Smalltalk Love ifTrue: [car honk] bumper stickers. Details here: http://macqueen.us/bumperStickers.html Merry Christmas to all. Donald [ | ] _______________________________________________ vwnc mailing list [hidden email] http://lists.cs.uiuc.edu/mailman/listinfo/vwnc |
Re: [vwnc] Smalltalk Bumper Stickers
|
|
Sure glad they come in those "plain brown envelopes", wouldn't
want anyone to know :) (Sorry but I'm Canadian). Donald MacQueen wrote: > Greetings Fellow Smalltalkers, > > I printed up 500 of the Smalltalk Love ifTrue: [car honk] bumper > stickers. Details here: http://macqueen.us/bumperStickers.html > > Merry Christmas to all. > > Donald [ | ] > _______________________________________________ > vwnc mailing list > [hidden email] > http://lists.cs.uiuc.edu/mailman/listinfo/vwnc > -- Dennis Smith +1 416.798.7948 Cherniak Software Development Corporation Fax: +1 416.798.0948 509-2001 Sheppard Avenue East [hidden email] Toronto, ON M2J 4Z8 sip:[hidden email] Canada http://www.CherniakSoftware.com Entrance off Yorkland Blvd south of Sheppard Ave east of the DVP _______________________________________________ vwnc mailing list [hidden email] http://lists.cs.uiuc.edu/mailman/listinfo/vwnc |
|
|
Dennis Smith wrote:
> Sure glad they come in those "plain brown envelopes", wouldn't > want anyone to know :) > > (Sorry but I'm Canadian). Yeah, you guys gotta worry about Software Hate Crimes up there in the Great Frozen North. ;-) I'll send you a couple if you send me some Toonies. > > Donald MacQueen wrote: >> Greetings Fellow Smalltalkers, >> >> I printed up 500 of the Smalltalk Love ifTrue: [car honk] bumper >> stickers. Details here: http://macqueen.us/bumperStickers.html >> >> Merry Christmas to all. >> >> Donald [ | ] >> _______________________________________________ >> vwnc mailing list >> [hidden email] >> http://lists.cs.uiuc.edu/mailman/listinfo/vwnc >> > _______________________________________________ vwnc mailing list [hidden email] http://lists.cs.uiuc.edu/mailman/listinfo/vwnc |
|
|
In reply to this post by jWarrior
Donald MacQueen wrote:
> Greetings Fellow Smalltalkers, > > I printed up 500 of the Smalltalk Love ifTrue: [car honk] bumper > stickers. Details here: http://macqueen.us/bumperStickers.html > > Merry Christmas to all. > > Donald [ | ] > _______________________________________________ > vwnc mailing list > [hidden email] > http://lists.cs.uiuc.edu/mailman/listinfo/vwnc > > _______________________________________________ vwnc mailing list [hidden email] http://lists.cs.uiuc.edu/mailman/listinfo/vwnc |
Re: [vwnc] Smalltalk Bumper Stickers
|
|
In reply to this post by jWarrior
Donald
Why do I get an error (HTTP 404 Not Found) when I try your URL? Terry =========================================================== Terry Raymond Crafted Smalltalk 80 Lazywood Ln. Tiverton, RI 02878 (401) 624-4517 [hidden email] <http://www.craftedsmalltalk.com> =========================================================== > -----Original Message----- > From: [hidden email] [mailto:[hidden email]] On Behalf Of Donald MacQueen > Sent: Friday, December 19, 2008 6:37 PM > To: [hidden email] > Subject: [vwnc] Smalltalk Bumper Stickers > > Greetings Fellow Smalltalkers, > > I printed up 500 of the Smalltalk Love ifTrue: [car honk] bumper > stickers. Details here: http://macqueen.us/bumperStickers.html > > Merry Christmas to all. > > Donald [ | ] > _______________________________________________ > vwnc mailing list > [hidden email] > http://lists.cs.uiuc.edu/mailman/listinfo/vwnc _______________________________________________ vwnc mailing list [hidden email] http://lists.cs.uiuc.edu/mailman/listinfo/vwnc |
|
|
Terry Raymond wrote:
Because I'm an idiot who, after announcing this to the world, thought it would be a good time to 'tune' my server and wound up toasting resolv.conf. Arrrggghhhh!Donald Why do I get an error (HTTP 404 Not Found) when I try your URL? All should be well now and there is a link from www.macqueen.us. Thanks for pointing this out. Donald [ | ] who is now going back to his image where he does have a few clues Terry =========================================================== Terry Raymond Crafted Smalltalk 80 Lazywood Ln. Tiverton, RI 02878 (401) 624-4517 [hidden email] <http://www.craftedsmalltalk.com> ===========================================================-----Original Message----- From: [hidden email] [[hidden email]] On Behalf Of Donald MacQueen Sent: Friday, December 19, 2008 6:37 PM To: [hidden email] Subject: [vwnc] Smalltalk Bumper Stickers Greetings Fellow Smalltalkers, I printed up 500 of the Smalltalk Love ifTrue: [car honk] bumper stickers. Details here: http://macqueen.us/bumperStickers.html Merry Christmas to all. Donald [ | ] _______________________________________________ vwnc mailing list [hidden email] http://lists.cs.uiuc.edu/mailman/listinfo/vwnc _______________________________________________ vwnc mailing list [hidden email] http://lists.cs.uiuc.edu/mailman/listinfo/vwnc |
«
Return to VisualWorks
|
1 view|%1 views
| Free forum by Nabble | Edit this page |