[vwnc] RBConfigurableFormatter has SharedVariables defined as private

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[vwnc] RBConfigurableFormatter has SharedVariables defined as private

Thomas Brodt
Hi all

is there any reason why RBConfigurableFormatter defines some Shareds as
public, some as private? E.g. StringBeforeReturn and many other Strings
like StringInsideBlocks, StringInsideParentheses are private, so you
cannot access them in subclasses. Others mostly Integer settings are
defined public, so no problem here to access e.g.
RetainBlankLinesBetweenStatements.

As I understood you should be free to subclass RBConfigurableFormatter
if not everything can be configured the way you want it to be by
configuring RBConfigurableFormatter itself. Therefore the formatterClass
on RBProgramNode. But then all Shareds should be accessible, otherwise
they must be duplicated on subclasses.

Thomas

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
Reply | Threaded
Open this post in threaded view
|

Re: [vwnc] RBConfigurableFormatter has SharedVariables defined as private

Travis Griggs-3
AR54874

Thanks Thomas.

On Jul 31, 2008, at 12:34 PM, Thomas Brodt wrote:

> Hi all
>
> is there any reason why RBConfigurableFormatter defines some Shareds  
> as
> public, some as private? E.g. StringBeforeReturn and many other  
> Strings
> like StringInsideBlocks, StringInsideParentheses are private, so you
> cannot access them in subclasses. Others mostly Integer settings are
> defined public, so no problem here to access e.g.
> RetainBlankLinesBetweenStatements.
>
> As I understood you should be free to subclass RBConfigurableFormatter
> if not everything can be configured the way you want it to be by
> configuring RBConfigurableFormatter itself. Therefore the  
> formatterClass
> on RBProgramNode. But then all Shareds should be accessible, otherwise
> they must be duplicated on subclasses.
>
> Thomas
>
> _______________________________________________
> vwnc mailing list
> [hidden email]
> http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
>

--
Travis Griggs
Objologist
Time and Countertops. They both get used up way too fast.


_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc