Smalltalk › Pharo › Pharo Smalltalk Developers

why (MCPackage named: 'NonExistenPackage') unload. doesnt fail ?

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

6 messages Options

Mariano Martinez Peck

why (MCPackage named: 'NonExistenPackage') unload. doesnt fail ?

Do we want that? I am finding a lot of outdated code that uses code like that and it doesnt fail, but still doesnt unload the package.

For example, cleanUpForRelease does a
(MCPackage named: 'HelpSystem') unload.

and that package doesnt exist anymore since it was split....

so...do we want that silent behaviour ?

cheers

mariano

csrabak

Re: why (MCPackage named: 'NonExistenPackage') unload. doesnt fail ?

Joining the canvassing campaign done by Bill: *by all means, please, NO!*

--
Cesar Rabak

Em 05/01/2011 19:53, Mariano Martinez Peck < [hidden email] > escreveu:
Do we want that? I am finding a lot of outdated code that uses code like that and it doesnt fail, but still doesnt unload the package.

For example, cleanUpForRelease does a
(MCPackage named: 'HelpSystem') unload.

and that package doesnt exist anymore since it was split....

so...do we want that silent behaviour ?

cheers

mariano

Stéphane Ducasse

Re: why (MCPackage named: 'NonExistenPackage') unload. doesnt fail ?

In reply to this post by Mariano Martinez Peck

> Do we want that? I am finding a lot of outdated code that uses code like that and it doesnt fail, but still doesnt unload the package.
>
> For example, cleanUpForRelease does a
> (MCPackage named: 'HelpSystem') unload.
>
> and that package doesnt exist anymore since it was split....
>
> so...do we want that silent behaviour ?

probably not.
Better fix the scripts as early as possible

>
> cheers
>
> mariano

Schwab,Wilhelm K

Re: why (MCPackage named: 'NonExistenPackage') unload. doesnt fail ?

+1. Someone wanting something that "just runs" can/should do something like

(MCPackage named: 'HelpSystem' ifNone:'[ DeafObject current ]) unload

Another approach is to trap and log errors so that a lengthy build process completes and then clearly shows where it encountered problems.

Bill

________________________________________
From: [hidden email] [[hidden email]] On Behalf Of Stéphane Ducasse [[hidden email]]
Sent: Thursday, January 06, 2011 6:11 AM
To: [hidden email]
Subject: Re: [Pharo-project] why (MCPackage named: 'NonExistenPackage') unload. doesnt fail ?

> Do we want that? I am finding a lot of outdated code that uses code like that and it doesnt fail, but still doesnt unload the package.
>
> For example, cleanUpForRelease does a
> (MCPackage named: 'HelpSystem') unload.
>
> and that package doesnt exist anymore since it was split....
>
> so...do we want that silent behaviour ?

probably not.
Better fix the scripts as early as possible

>
> cheers
>
> mariano

Mariano Martinez Peck

Re: why (MCPackage named: 'NonExistenPackage') unload. doesnt fail ?

On Thu, Jan 6, 2011 at 3:32 PM, Schwab,Wilhelm K <[hidden email]> wrote:

+1. Someone wanting something that "just runs" can/should do something like

(MCPackage named: 'HelpSystem' ifNone:'[ DeafObject current ]) unload

Exactly.
Now...I don't know the impact of doing this change. Maybe we screw up monticello hehehe

cheer

mariano

Another approach is to trap and log errors so that a lengthy build process completes and then clearly shows where it encountered problems.

Bill

________________________________________
From: [hidden email] [[hidden email]] On Behalf Of Stéphane Ducasse [[hidden email]]
Sent: Thursday, January 06, 2011 6:11 AM
To: [hidden email]
Subject: Re: [Pharo-project] why (MCPackage named: 'NonExistenPackage') unload. doesnt fail ?

> Do we want that? I am finding a lot of outdated code that uses code like that and it doesnt fail, but still doesnt unload the package.
>
> For example, cleanUpForRelease does a
> (MCPackage named: 'HelpSystem') unload.
>
> and that package doesnt exist anymore since it was split....
>
> so...do we want that silent behaviour ?

probably not.
Better fix the scripts as early as possible

>
> cheers
>
> mariano

Mariano Martinez Peck

Re: why (MCPackage named: 'NonExistenPackage') unload. doesnt fail ?

On Thu, Jan 6, 2011 at 3:46 PM, Mariano Martinez Peck <[hidden email]> wrote:

On Thu, Jan 6, 2011 at 3:32 PM, Schwab,Wilhelm K <[hidden email]> wrote:
+1. Someone wanting something that "just runs" can/should do something like

(MCPackage named: 'HelpSystem' ifNone:'[ DeafObject current ]) unload

Exactly.
Now...I don't know the impact of doing this change. Maybe we screw up monticello hehehe

Even more.... If you have the packages: 'HelpSystem-Core' and 'HelpSystem-Tests', what do you think that happens if I do:

(MCPackage named: 'HelpSystem') unload.

All classes and categories are removed and the two packages 'HelpSystem-Core' and 'HelpSystem-Tests' are kept and marked as dirty....

grrrrrr

cheer

mariano

Another approach is to trap and log errors so that a lengthy build process completes and then clearly shows where it encountered problems.

Bill

________________________________________
From: [hidden email] [[hidden email]] On Behalf Of Stéphane Ducasse [[hidden email]]
Sent: Thursday, January 06, 2011 6:11 AM
To: [hidden email]
Subject: Re: [Pharo-project] why (MCPackage named: 'NonExistenPackage') unload. doesnt fail ?

> Do we want that? I am finding a lot of outdated code that uses code like that and it doesnt fail, but still doesnt unload the package.
>
> For example, cleanUpForRelease does a
> (MCPackage named: 'HelpSystem') unload.
>
> and that package doesnt exist anymore since it was split....
>
> so...do we want that silent behaviour ?

probably not.
Better fix the scripts as early as possible

>
> cheers
>
> mariano