Smalltalk › Pharo › Pharo Smalltalk Developers

why we removed debugTest from nautilus?

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

28 messages Options

Max Leske

Re: why we removed debugTest from nautilus?

On 11 Apr 2015, at 21:31, Ben Coman <[hidden email]> wrote:

On Sun, Apr 12, 2015 at 3:07 AM, Ben Coman <[hidden email]> wrote:
Returning to build 40486 which exhibits the freeze, as a first step, why don't we replace all that complicated stack manipulation stuff with...

NautilusUI>>debugTest: aMethod
[ aMethod methodClass debug: aMethod selector ] fork.

Sorry. Pretend I didn't say that. That is the <run test> behaviour.

Really? Why does it send #debug: then??

cheers -ben

Ben Coman

Re: why we removed debugTest from nautilus?

From the perspective of a TestCase...

* "running" a test wraps execution in error handling so it can log errors without TestRunner breaking open a debugger.

* "debugging" executes without that error handling so an error breaks open a debugger.

The functionality required is that a debugger opens immediately on the first line of the test method.

cheers -ben

On Sun, Apr 12, 2015 at 3:35 AM, Max Leske <[hidden email]> wrote:

On 11 Apr 2015, at 21:31, Ben Coman <[hidden email]> wrote:

On Sun, Apr 12, 2015 at 3:07 AM, Ben Coman <[hidden email]> wrote:
Returning to build 40486 which exhibits the freeze, as a first step, why don't we replace all that complicated stack manipulation stuff with...

NautilusUI>>debugTest: aMethod
[ aMethod methodClass debug: aMethod selector ] fork.

Sorry. Pretend I didn't say that. That is the <run test> behaviour.

Really? Why does it send #debug: then??

cheers -ben

Clara Allende

Re: why we removed debugTest from nautilus?

In reply to this post by Clément Béra

Le 11 avr. 2015 14:32, "Clément Bera" <[hidden email]> a écrit :
>
>
>
> 2015-04-11 1:10 GMT-07:00 Nicolai Hess <[hidden email]>:
>
>>
>>
>> 2015-04-10 17:28 GMT+02:00 Clément Bera <[hidden email]>:
>>>
>>> Well I guess I used to click proceed and not close the debugger...
>>
>>
>>
>> I don't know who is working on the breakpoint support and I don't know how long it will take.
>> Maybe we can fix thie image freeze and re-include the debugtest code until the new breakpoint support.
>>
>> what do you think?
>>
>
> I think break points were done by Clara Allende. As far as I know, they work but there's no IDE support for them. I think they are not ready for this release but I am not sure about the status. Marcus can confirm it will not be ready.

For this release the intention was reviewing and integrating the Reflectivity machinery, and then afterwards the breakpoints.
So far Marcus has done a lot on that part (reviewing and enhancing my prototype for reflectivity), and we have discussed that the breakpoints (in the state I've left them at the end of my internship) should work out of the box. Nevertheless, I want to do a pass on them and update what's necessary once Pharo4 is released.

But they won't be integrated in the release, that's for sure, because there's work to do with them...

Cheers
Clari
>
> Yes this image freeze could be fixed but I can't really work on the Pharo release this week (I'm working with Eliot on Cogit...). I could review the fix if you want just tagged me in fogbugz.
>>>
>>>
>>> 2015-04-10 1:24 GMT-07:00 Max Leske <[hidden email]>:
>>>
>>>> For a little more context: the issue was originally raised by Clara in the thread titled "MNU: receiver of "stepToCallee:" is nil”. IIRC the issue was easily reproducible when debugging a test, then closing the debugger (via the close icon). Clicking “Proceed” on the other hand gracefully terminated the process.
>>>>
>>>> Cheers,
>>>> Max
>>>>
>>>>
>>>>> On 10 Apr 2015, at 09:56, Nicolai Hess <[hidden email]> wrote:
>>>>>
>>>>> 2015-04-10 2:37 GMT+02:00 Clément Bera <[hidden email]>:
>>>>>>
>>>>>> I was using it frequently too and I have never experienced any issues...
>>>>>
>>>>>
>>>>> Ok, can you describe a use case, what test case you can start and
>>>>> close the debugger without image freeze?
>>>>>
>>>>> Maybe we can find what is the difference between that
>>>>> test case and those that freeze the image, and than find a fix.
>>>>>
>>>>>>
>>>>>>
>>>>>> 2015-04-09 14:58 GMT-07:00 Nicolai Hess <[hidden email]>:
>>>>>>
>>>>>>>
>>>>>>> 2015-04-09 23:38 GMT+02:00 [hidden email] <[hidden email]>:
>>>>>>>>
>>>>>>>> No Debug Tests?
>>>>>>>>
>>>>>>>> Geez, I am using that all the time.
>>>>>>>
>>>>>>>
>>>>>>> And you're never encountered this issue 14689?
>>>>>>> Or did this work in older versions?
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Phil
>>>>>>>>
>>>>>>>>
>>>>>>>> On Thu, Apr 9, 2015 at 10:21 PM, Marcus Denker <[hidden email]> wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> > On 09 Apr 2015, at 22:32, Sean P. DeNigris <[hidden email]> wrote:
>>>>>>>>> >
>>>>>>>>> > Nicolai Hess wrote
>>>>>>>>> >> http://forum.world.st/do-we-need-to-debug-testmethods-from-within-Nautilus-tp4805795.html
>>>>>>>>> >
>>>>>>>>> > Ah, I miss that too! From that thread, it seems it was removed temporarily
>>>>>>>>> > until we have real breakpoints. Is there an issue for its return?
>>>>>>>>> >
>>>>>>>>>
>>>>>>>>> Not yet.
>>>>>>>>>
>>>>>>>>> Marcus
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>

stepharo

Re: why we removed debugTest from nautilus?

In reply to this post by Ben Coman

Hi nicolai

I do not know the complexity of the fix and its addition.
I have the impression that we will have more fixes after the release than in 3.0.
So prepare it because it can always be used either in 4.0 or 5.0 alpha.
Even if at the end we remove it because of better wy to express breakpoint.

In france we say "never free the prey for its shadow" ;)
Stef

Le 11/4/15 14:58, Ben Coman a écrit :

I miss it. I think I remember that a <Restart> <Close> would work, so a hack fix could be the do a restart when the close button is pushed.
Reintroducing it with the problem fixed would be welcome.

cheers -ben

On Sat, Apr 11, 2015 at 4:10 PM, Nicolai Hess <[hidden email]> wrote:

2015-04-10 17:28 GMT+02:00 Clément Bera <[hidden email]>:

Well I guess I used to click proceed and not close the debugger...

I don't know who is working on the breakpoint support and I don't know how long it will take.

Maybe we can fix thie image freeze and re-include the debugtest code until the new breakpoint support.

what do you think?

2015-04-10 1:24 GMT-07:00 Max Leske <[hidden email]>:

For a little more context: the issue was originally raised by Clara in the thread titled "MNU: receiver of "stepToCallee:" is nil”. IIRC the issue was easily reproducible when debugging a test, then closing the debugger (via the close icon). Clicking “Proceed” on the other hand gracefully terminated the process.

Cheers,

Max

On 10 Apr 2015, at 09:56, Nicolai Hess <[hidden email]> wrote:

2015-04-10 2:37 GMT+02:00 Clément Bera <[hidden email]>:

I was using it frequently too and I have never experienced any issues...

Ok, can you describe a use case, what test case you can start and
close the debugger without image freeze?

Maybe we can find what is the difference between that
test case and those that freeze the image, and than find a fix.

2015-04-09 14:58 GMT-07:00 Nicolai Hess <[hidden email]>:

2015-04-09 23:38 GMT+02:00 [hidden email] <[hidden email]>:

No Debug Tests?

Geez, I am using that all the time.

And you're never encountered this issue 14689?

Or did this work in older versions?

Phil

On Thu, Apr 9, 2015 at 10:21 PM, Marcus Denker <[hidden email]> wrote:

> On 09 Apr 2015, at 22:32, Sean P. DeNigris <[hidden email]> wrote:
>
> Nicolai Hess wrote
>> http://forum.world.st/do-we-need-to-debug-testmethods-from-within-Nautilus-tp4805795.html
>
> Ah, I miss that too! From that thread, it seems it was removed temporarily
> until we have real breakpoints. Is there an issue for its return?
>

Not yet.

Marcus

Marcus Denker-4

Re: why we removed debugTest from nautilus?

In reply to this post by Nicolai Hess

On 11 Apr 2015, at 10:10, Nicolai Hess <[hidden email]> wrote:

2015-04-10 17:28 GMT+02:00 Clément Bera <[hidden email]>:
Well I guess I used to click proceed and not close the debugger...

I don't know who is working on the breakpoint support and I don't know how long it will take.
Maybe we can fix thie image freeze and re-include the debugtest code until the new breakpoint support.

what do you think?

Breakpoints are for Pharo5… maybe back porting will be possible, but it is not the priority.

Marcus

Marcus Denker-4

Re: why we removed debugTest from nautilus?

In reply to this post by Clara Allende

> I think break points were done by Clara Allende. As far as I know, they work but there's no IDE support for them. I think they are not ready for this release but I am not sure about the status. Marcus can confirm it will not be ready.
For this release the intention was reviewing and integrating the Reflectivity machinery, and then afterwards the breakpoints.
So far Marcus has done a lot on that part (reviewing and enhancing my prototype for reflectivity), and we have discussed that the breakpoints (in the state I've left them at the end of my internship) should work out of the box. Nevertheless, I want to do a pass on them and update what's necessary once Pharo4 is released.
But they won't be integrated in the release, that's for sure, because there's work to do with them...

The problem is that it needs compiler changes that will not be done for Pharo4. Maybe we can back port, but the priority for me is not Pharo4 for this.

Marcus

Francisco Ortiz Peñaloza

Re: why we removed debugTest from nautilus?

Hi,

i'm really missing the debug feature in nautilus. +1 to restore it!

But it's worse than what others describe, lets say you write a tests that fails, i've to press ALT + "." to've the UI back and the dialog window that offers you to proceed, abandon, debug, etc.

It hangs on this collaboration of PackageTreeNautilusUI#runTestForAMethod:notifying:priority:

testSemaphoreForMethod wait.

I also tried to send #haltOnce or #halt into the test and it doesn't work on a test. It stops only when i press ALT + "."

Cheers,

Francisco

On Sun, Apr 12, 2015 at 7:00 AM, Marcus Denker <[hidden email]> wrote:

> I think break points were done by Clara Allende. As far as I know, they work but there's no IDE support for them. I think they are not ready for this release but I am not sure about the status. Marcus can confirm it will not be ready.
For this release the intention was reviewing and integrating the Reflectivity machinery, and then afterwards the breakpoints.
So far Marcus has done a lot on that part (reviewing and enhancing my prototype for reflectivity), and we have discussed that the breakpoints (in the state I've left them at the end of my internship) should work out of the box. Nevertheless, I want to do a pass on them and update what's necessary once Pharo4 is released.
But they won't be integrated in the release, that's for sure, because there's work to do with them...

The problem is that it needs compiler changes that will not be done for Pharo4. Maybe we can back port, but the priority for me is not Pharo4 for this.

Marcus

Paul DeBruicker

Re: why we removed debugTest from nautilus?

Load the Slice #16018 into your Pharo 4 image and it will add the menu item back.

Francisco Ortiz Peñaloza wrote

Hi,

i'm really missing the debug feature in nautilus. +1 to restore it!

But it's worse than what others describe, lets say you write a tests that
fails, i've to press ALT + "." to've the UI back and the dialog window that
offers you to proceed, abandon, debug, etc.

It hangs on this collaboration of
PackageTreeNautilusUI#runTestForAMethod:notifying:priority:

testSemaphoreForMethod wait.

I also tried to send #haltOnce or #halt into the test and it doesn't work
on a test. It stops only when i press ALT + "."

Cheers,
Francisco

On Sun, Apr 12, 2015 at 7:00 AM, Marcus Denker <[hidden email]>
wrote:

>
> > I think break points were done by Clara Allende. As far as I know, they
> work but there's no IDE support for them. I think they are not ready for
> this release but I am not sure about the status. Marcus can confirm it will
> not be ready.
>
> For this release the intention was reviewing and integrating the
> Reflectivity machinery, and then afterwards the breakpoints.
> So far Marcus has done a lot on that part (reviewing and enhancing my
> prototype for reflectivity), and we have discussed that the breakpoints (in
> the state I've left them at the end of my internship) should work out of
> the box. Nevertheless, I want to do a pass on them and update what's
> necessary once Pharo4 is released.
>
> But they won't be integrated in the release, that's for sure, because
> there's work to do with them...
>
> The problem is that it needs compiler changes that will not be done for
> Pharo4. Maybe we can back port, but the priority for me is not Pharo4 for
> this.
>
> Marcus
>
>