withinContent

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

withinContent

keith1y
I have a subclass of PRMenuWidget which renders, however it now renders
with paragraphs, where it did not before.

Previously components were rendered by the PEViewRenderer which
maintains "withinContent", however now components are rendered by
"PREmbeddedRenderer" and have no knowledge of "withinContent"

is this a bug? Or is my menu widget abusing the new way of doing things?

Keith


_______________________________________________
SmallWiki, Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
Reply | Threaded
Open this post in threaded view
|

Re: withinContent

keith1y
Keith Hodges wrote:

> I have a subclass of PRMenuWidget which renders, however it now renders
> with paragraphs, where it did not before.
>
> Previously components were rendered by the PEViewRenderer which
> maintains "withinContent", however now components are rendered by
> "PREmbeddedRenderer" and have no knowledge of "withinContent"
>
> is this a bug? Or is my menu widget abusing the new way of doing things?
>
> Keith
>  
When the PRMenuRenderer is invoked it assumes its own withinContent is
true, it could ask the current context's renderer.

Keith


_______________________________________________
SmallWiki, Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
Reply | Threaded
Open this post in threaded view
|

Re: withinContent

Lukas Renggli
I fixed it in the latest commit. Althogh unlikely to happen, the new
version also properly detects recursion.

Lukas

On Mon, Apr 6, 2009 at 8:40 PM, Keith Hodges <[hidden email]> wrote:

> Keith Hodges wrote:
>> I have a subclass of PRMenuWidget which renders, however it now renders
>> with paragraphs, where it did not before.
>>
>> Previously components were rendered by the PEViewRenderer which
>> maintains "withinContent", however now components are rendered by
>> "PREmbeddedRenderer" and have no knowledge of "withinContent"
>>
>> is this a bug? Or is my menu widget abusing the new way of doing things?
>>
>> Keith
>>
> When the PRMenuRenderer is invoked it assumes its own withinContent is
> true, it could ask the current context's renderer.
>
> Keith
>
>
> _______________________________________________
> SmallWiki, Magritte, Pier and Related Tools ...
> https://www.iam.unibe.ch/mailman/listinfo/smallwiki
>



--
Lukas Renggli
http://www.lukas-renggli.ch

_______________________________________________
SmallWiki, Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki