Smalltalk › Pharo › Pharo Smalltalk Developers

xmlwriter change brakes an issuetracker-image test

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

Nicolai Hess

xmlwriter change brakes an issuetracker-image test

change in XMLWriter:
Name: XML-Writer-Core-monty.40
Author: monty
Time: 15 June 2015, 4:35:12.313879 am
UUID: 632db1a0-b6a6-4686-924e-a9bbb2b843b4
Ancestors: XML-Writer-Core-monty.39

xml declaration writers no longer output "encoding=UTF-8" by default

But now, CIXMLPublisherTest test fails, the test case expects a result

with "encoding=UTF-8"

Paul DeBruicker

Re: xmlwriter change brakes an issuetracker-image test

Is there a spec for XML documents and if so what does it say is the correct behavior?

I would guess the encoding declaration is optional according to the spec and shouldn't be relied on in the test as being there in default. Probably need to add the encoding explicitly if its required by the consumer of the XML document.

Nicolai Hess wrote

change in XMLWriter:
Name: XML-Writer-Core-monty.40
Author: monty
Time: 15 June 2015, 4:35:12.313879 am
UUID: 632db1a0-b6a6-4686-924e-a9bbb2b843b4
Ancestors: XML-Writer-Core-monty.39

xml declaration writers no longer output "encoding=UTF-8" by default

But now, CIXMLPublisherTest test fails, the test case expects a result
with "encoding=UTF-8"

Nicolai Hess

Re: xmlwriter change brakes an issuetracker-image test

2015-07-22 20:11 GMT+02:00 Paul DeBruicker <[hidden email]>:

Is there a spec for XML documents and if so what does it say is the correct
behavior?

I don't know.

I would guess the encoding declaration is optional according to the spec and
shouldn't be relied on in the test as being there in default. Probably need
to add the encoding explicitly if its required by the consumer of the XML
document.

We should change the tests.

How or who can do this? And how do we make the pharo issue tracker image use that

version?

Nicolai Hess wrote

> change in XMLWriter:
> Name: XML-Writer-Core-monty.40
> Author: monty
> Time: 15 June 2015, 4:35:12.313879 am
> UUID: 632db1a0-b6a6-4686-924e-a9bbb2b843b4
> Ancestors: XML-Writer-Core-monty.39
>
> xml declaration writers no longer output "encoding=UTF-8" by default
>
> But now, CIXMLPublisherTest test fails, the test case expects a result
> with "encoding=UTF-8"

--
View this message in context: http://forum.world.st/xmlwriter-change-brakes-an-issuetracker-image-test-tp4838622p4838718.html
Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.