Issue 3830 in pharo: [Failing Test] Autotes TestHitCounter.testHitCountIncrements

Status: Accepted
Owner: [hidden email]
Labels: Milestone-1.2-DevImage

New issue 3830 by [hidden email]: [Failing Test] Autotes  
TestHitCounter.testHitCountIncrements
http://code.google.com/p/pharo/issues/detail?id=3830

Why does this just like that start to fail after nunning for days without  
problems?

Autotest.Tests.Core.AutotestTestHitCounter.testHitCountIncrements

Comment #1 on issue 3830 by [hidden email]: [Failing Test] Autotes  
TestHitCounter.testHitCountIncrements
http://code.google.com/p/pharo/issues/detail?id=3830

The test fails when executing the whole AutotestTestHitCounter, succeeds  
when running it alone.

But really: Why did the code change that we load in 1.2? Did someone change  
something?

I really don't understand how the Pharo Full image is build and  
especicially how we can make sure
that we do something that is reproducable and does not change randomly.

Updates:
        Cc: [hidden email]

Comment #2 on issue 3830 by [hidden email]: [Failing Test] Autotes  
TestHitCounter.testHitCountIncrements
http://code.google.com/p/pharo/issues/detail?id=3830

(No comment was entered for this change.)

Comment #3 on issue 3830 by [hidden email]: [Failing Test] Autotes  
TestHitCounter.testHitCountIncrements
http://code.google.com/p/pharo/issues/detail?id=3830

Autotest have not changed for a while ... I will have a look.

Comment #4 on issue 3830 by [hidden email]: [Failing Test] Autotes  
TestHitCounter.testHitCountIncrements
http://code.google.com/p/pharo/issues/detail?id=3830

I'm puzzled.  I take the Pharo-1.2-AfterRunningTests image, open TestRunner  
and run all Autotest tests, sometimes (??)  
AutotestTestHitCounter.testHitCountIncrements.

So to debug I've added a log on Transcript to check that AutotestHitCounter  
wrapper works:

AutotestHitCounter>>run: aSelector with: anArray in: aReceiver
        self hit.

        Transcript
                show: thisContext sender asString;
                space;
                show: self hitCount asString;
                cr.

        ^ aReceiver withArgs: anArray executeMethod: method

but then tests never fail; always green !! Remove/comment Transcript  
instructions, then sometimes the test fail again.

So this come out of my knowledge - what should I check ?

Comment #5 on issue 3830 by [hidden email]: [Failing Test] Autotes  
TestHitCounter.testHitCountIncrements
http://code.google.com/p/pharo/issues/detail?id=3830

I'm puzzled.  I take the Pharo-1.2-AfterRunningTests image, open TestRunner  
and run all Autotest tests, sometimes (??)  
AutotestTestHitCounter.testHitCountIncrements fails.

So to debug I've added a log on Transcript to check that AutotestHitCounter  
wrapper works:

AutotestHitCounter>>run: aSelector with: anArray in: aReceiver
        self hit.

        Transcript
                show: thisContext sender asString;
                space;
                show: self hitCount asString;
                cr.

        ^ aReceiver withArgs: anArray executeMethod: method

but then tests never fail; always green !! Remove/comment Transcript  
instructions, then sometimes the test fail again.

So this come out of my knowledge - what should I check ?

Comment #6 on issue 3830 by [hidden email]: [Failing Test] Autotes  
TestHitCounter.testHitCountIncrements
http://code.google.com/p/pharo/issues/detail?id=3830

This is caused by the same issue in 3581. The method cache is returning the  
wrong CompiledMethod or delegate (AutoTestHitCounter).

As an example the cache could be flushed by adding a method to  
AutoTestHitCounter>>
flushCache
    method selector flushCache.

Updates:
        Status: FixProposed

Comment #7 on issue 3830 by [hidden email]: [Failing Test] Autotes  
TestHitCounter.testHitCountIncrements
http://code.google.com/p/pharo/issues/detail?id=3830

Thank you ! Seems to work. I've created Autotest v1.0.1 and updated  
ConfigurationOfPharo.

Waiting for next build....

Updates:
        Status: Closed

Comment #8 on issue 3830 by [hidden email]: [Failing Test] Autotes  
TestHitCounter.testHitCountIncrements
http://code.google.com/p/pharo/issues/detail?id=3830

Works!