0007439: Selection in Trunk text editors does not extend correctly

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

0007439: Selection in Trunk text editors does not extend correctly

Balázs Kósi
Hi,

From: http://bugs.squeak.org/view.php?id=7439
> Extending the selection in a Workspace with shift-click does not seem to work properly
The clause handling exactly this was removed from TextEditor >> mouesDown:

        evt shiftPressed
                ifFalse: [
                        self closeTypeIn.
                        self markBlock: b.
                        self pointBlock: b ]
>>>> ifTrue: [
                        self closeTypeIn.
                        self mouseMove: evt ].
        self storeSelectionInParagraph <<<< This was removed.

If you put it back, shift-click selection works again, but maybe there
was a motivation to remove it.
Anybody knows about this?

Balázs

Reply | Threaded
Open this post in threaded view
|

Re: 0007439: Selection in Trunk text editors does not extend correctly

Andreas.Raab
On 2/26/2010 10:11 AM, Balázs Kósi wrote:

> Hi,
>
> From: http://bugs.squeak.org/view.php?id=7439
>> Extending the selection in a Workspace with shift-click does not seem to work properly
> The clause handling exactly this was removed from TextEditor>>  mouesDown:
>
> evt shiftPressed
> ifFalse: [
> self closeTypeIn.
> self markBlock: b.
> self pointBlock: b ]
>>>>> ifTrue: [
> self closeTypeIn.
> self mouseMove: evt ].
> self storeSelectionInParagraph<<<<  This was removed.
>
> If you put it back, shift-click selection works again, but maybe there
> was a motivation to remove it.
> Anybody knows about this?

I'm not sure what's wrong with shift-click selection to begin with. It
seems tp work perfectly fine for me. Perhaps a platform issue? I'm on
Windows.

Cheers,
   - Andreas

Reply | Threaded
Open this post in threaded view
|

Re: 0007439: Selection in Trunk text editors does not extend correctly

Balázs Kósi
> I'm not sure what's wrong with shift-click selection to begin with. It seems
> tp work perfectly fine for me. Perhaps a platform issue? I'm on Windows.
It happens under both mac and windows for me:

Open a Workspace. Type aaa bbb. Position the cursor in aaa.
Hold down shift, click on bbb. aaa gets selected, instead of
selecting from the cursor to the character you clicked.

Balázs

Reply | Threaded
Open this post in threaded view
|

Re: 0007439: Selection in Trunk text editors does not extend correctly

K. K. Subramaniam
On Friday 26 February 2010 06:57:52 pm Balázs Kósi wrote:
> > I'm not sure what's wrong with shift-click selection to begin with. It
> > seems tp work perfectly fine for me. Perhaps a platform issue? I'm on
> > Windows.
>
> It happens under both mac and windows for me:
It happens in Linux too but only if I position it inside (like aa|a). If I
position it in the beginning (like |aaa) then the selection works as expected.

Subbu

Reply | Threaded
Open this post in threaded view
|

Re: 0007439: Selection in Trunk text editors does not extend correctly

Andreas.Raab
In reply to this post by Balázs Kósi
On 2/26/2010 2:27 PM, Balázs Kósi wrote:
>> I'm not sure what's wrong with shift-click selection to begin with. It seems
>> tp work perfectly fine for me. Perhaps a platform issue? I'm on Windows.
> It happens under both mac and windows for me:
>
> Open a Workspace. Type aaa bbb. Position the cursor in aaa.
> Hold down shift, click on bbb. aaa gets selected, instead of
> selecting from the cursor to the character you clicked.

Got it, thanks. (I had accidentally used an old workspace that still had
a TextMorphEditor installed)

Only Juan could say for sure if there was some intention behind changing
this but this is clearly broken so my take on it would be to fix it
first and ask questions later :-) It's easily undone if it turns out not
to be the preferred choice of fixing it but I can see how that might be
annoying.

Cheers,
   - Andreas

Reply | Threaded
Open this post in threaded view
|

Re: 0007439: Selection in Trunk text editors does not extend correctly

Juan Vuletich-4
Andreas Raab wrote:

> On 2/26/2010 2:27 PM, Balázs Kósi wrote:
>>> I'm not sure what's wrong with shift-click selection to begin with.
>>> It seems
>>> tp work perfectly fine for me. Perhaps a platform issue? I'm on
>>> Windows.
>> It happens under both mac and windows for me:
>>
>> Open a Workspace. Type aaa bbb. Position the cursor in aaa.
>> Hold down shift, click on bbb. aaa gets selected, instead of
>> selecting from the cursor to the character you clicked.
>
> Got it, thanks. (I had accidentally used an old workspace that still
> had a TextMorphEditor installed)
>
> Only Juan could say for sure if there was some intention behind
> changing this but this is clearly broken so my take on it would be to
> fix it first and ask questions later :-) It's easily undone if it
> turns out not to be the preferred choice of fixing it but I can see
> how that might be annoying.
>
> Cheers,
>   - Andreas
:) The reason for that change is to support the 'tap and wait' gesture
to open the menu in Cuis. This is good for pen computers and 1-button
mice, and having to move a bit the mouse to extend selection doesn't
sound that bad to me. Anyway, 'tap and wait' is not working in Squeak,
so it might make sense to reverse it.

Cheers,
Juan Vuletich

Reply | Threaded
Open this post in threaded view
|

Re: 0007439: Selection in Trunk text editors does not extend correctly

Balázs Kósi
> Anyway, 'tap and wait' is not working in Squeak, so it might make sense to reverse it.
I've just committed Morphic-kb.357 to The Inbox doing this.