I am still getting 2 failures with updated image in Tests-Monticello. K, r |
On Fri, 19 Jun 2020, Robert Withers via Squeak-dev wrote:
> I am still getting 2 failures with updated image in Tests-Monticello. > > K, r Those are failing here as well. The postscripts are missing entirely from the mock snapshot, hence the failure. I also see MCSerializationTest failing in my image. Some class definitions don't have trait compositions, but the reader is happy to read the first two lines of the next class's definition as trait composition and class trait composition. Levente |
In reply to this post by Squeak - Dev mailing list
See Tests-ct.436. Best,
Christoph
Von: Squeak-dev <[hidden email]> im Auftrag von Levente Uzonyi <[hidden email]> Gesendet: Samstag, 20. Juni 2020, 02:57 An: Robert Withers; The general-purpose Squeak developers list Betreff: Re: [squeak-dev] 2 failures in Tests-Monticello On Fri, 19 Jun 2020, Robert Withers via Squeak-dev wrote: > I am still getting 2 failures with updated image in Tests-Monticello. > > K, r Those are failing here as well. The postscripts are missing entirely from the mock snapshot, hence the failure. I also see MCSerializationTest failing in my image. Some class definitions don't have trait compositions, but the reader is happy to read the first two lines of the next class's definition as trait composition and class trait composition. Levente
Carpe Squeak!
|
Where can I find this package? Kindly, Robert
|
Sorry, it is located in the inbox.
Best, ChristophVon: Robert <[hidden email]>
Gesendet: Samstag, 20. Juni 2020 12:43 Uhr An: Thiede, Christoph; The general-purpose Squeak developers list Betreff: Re: [squeak-dev] 2 failures in Tests-Monticello Where can I find this package?
Kindly,
Robert
Carpe Squeak!
|
I am completely unfamiliar with how the Inbox works and how I can access this particular package. Could you explain how I can interact with the Inbox, please?
K, r
On 6/20/20 7:37 AM, Thiede, Christoph
wrote:
|
Of course, here is the swiki article about the inbox: https://wiki.squeak.org/squeak/6545
If you have installed the latest trunk updates, the inbox repository should already exist. You only need to open the Monticello Browser from the Apps Menu. Then select the Tests package from the left, inbox from the right, and press Open. Select Tests-ct.436 and press Merge. Does that work for you? :-)
Best, Christoph Von: Robert Withers <[hidden email]>
Gesendet: Samstag, 20. Juni 2020 13:49:53 An: Thiede, Christoph; The general-purpose Squeak developers list Betreff: Re: AW: [squeak-dev] 2 failures in Tests-Monticello I am completely unfamiliar with how the Inbox works and how I can access this particular package. Could you explain how I can interact with the Inbox, please?
K, r
On 6/20/20 7:37 AM, Thiede, Christoph wrote:
Carpe Squeak!
|
In reply to this post by Christoph Thiede
I found the Inbox repository in Monticello Browser and opened it, found your package, ran "update code from server", loaded your Tests-ct.436 package from inbox and ran the Tests-Monticello tests. There are now 4 failures, in different spots.
Is the Inbox for manual loading and testing? Or is it related to
the packages that are loaded when I do: "update code from server"?
This is the area where I am lost, where code updates get loaded by
"update code from server".
K, r
On 6/20/20 7:37 AM, Thiede, Christoph
wrote:
|
In reply to this post by Christoph Thiede
Thank you for the reference to the swiki page on Inbox. I read the new development model page and tried to look into the trunk link. I am unable to find any details about saving to Inbox then moving to trunk.
K, r
On 6/20/20 8:07 AM, Thiede, Christoph
wrote:
|
In reply to this post by Squeak - Dev mailing list
Hi,
Update code from server loads from the URL set under Preferences --> Updates. - Herbert Am 20.06.2020 um 14:07 schrieb Robert
Withers via Squeak-dev:
|
In reply to this post by Squeak - Dev mailing list
Pooh, tbh I don't know. Where is that "update code from server" button? Usually, I merge but do not load versions from the inbox.
> There are now 4 failures, in different spots. Oops, they are regressions, unfortunately. Thanks for the reminder! I tried to emphasize the isolation of all the tests from each other, something must have broken there.
> I am unable to find any details about saving to Inbox then moving to trunk.
Best, Christoph Von: Robert Withers <[hidden email]>
Gesendet: Samstag, 20. Juni 2020 14:07:54 An: Thiede, Christoph; The general-purpose Squeak developers list Betreff: Re: AW: [squeak-dev] 2 failures in Tests-Monticello I found the Inbox repository in Monticello Browser and opened it, found your package, ran "update code from server", loaded your Tests-ct.436 package from inbox and ran the Tests-Monticello tests. There are now 4 failures, in different spots.
Is the Inbox for manual loading and testing? Or is it related to the packages that are loaded when I do: "update code from server"? This is the area where I am lost, where code updates get loaded by "update code from server".
K, r
On 6/20/20 7:37 AM, Thiede, Christoph wrote:
Carpe Squeak!
|
Hi,
Am 20.06.2020 um 14:18 schrieb Thiede,
Christoph:
Sorry I messed that one up. I know there is (was) such a button but I talked about what happens when you press "Update Squeak" under the top left Squeak Menu. - Herbert
|
In reply to this post by Christoph Thiede
On 6/20/20 8:18 AM, Thiede, Christoph
wrote:
I go under World Menu-->help...->'update code from server'.
I now have a script:
Alright, thank goodness for Unit Tests!
I do not think I have write access and no need, either. If I understand correctly, the Inbox package version getting promoted into the trunk is to merely Copy the package to the trunk repository. Then the 'MCMcmUpdater updateFromServer' loads the latest package of every package in trunk. Is it so?
K, r
|
In reply to this post by Levente Uzonyi
Am Sa., 20. Juni 2020 um 02:57 Uhr schrieb Levente Uzonyi
<[hidden email]>: > > Some class definitions > don't have trait compositions, but the reader is happy to read the first > two lines of the next class's definition as trait composition and class > trait composition. > I see the same thing happening when loading the INIFile package. This breaks my smalltalkCI tests even further, because Monticello now thinks that the class INIFile depends on the class INIFile and warns about it during the load... Curiously it seems to work when I do this in a Trunk image, although in smalltalkCI I also used a Trunk image, hmm. |
Fix proposed as Monticello-jr.726. The bug was triggered by the
optimized ReadStream>>match: method introduced with Collections-ul.900, which does not set the stream to the end. The traitComposition is read from a ReadStream of the class definition string, hence the wrong read result if there are no traits in the definition. Am Sa., 27. Juni 2020 um 11:17 Uhr schrieb Jakob Reschke <[hidden email]>: > > Am Sa., 20. Juni 2020 um 02:57 Uhr schrieb Levente Uzonyi > <[hidden email]>: > > > > Some class definitions > > don't have trait compositions, but the reader is happy to read the first > > two lines of the next class's definition as trait composition and class > > trait composition. > > > > I see the same thing happening when loading the INIFile package. This > breaks my smalltalkCI tests even further, because Monticello now > thinks that the class INIFile depends on the class INIFile and warns > about it during the load... Curiously it seems to work when I do this > in a Trunk image, although in smalltalkCI I also used a Trunk image, > hmm. |
That's a bug in ReadStream >> #match:. The behavior shouldn't have
changed. Levente On Sun, 28 Jun 2020, Jakob Reschke wrote: > Fix proposed as Monticello-jr.726. The bug was triggered by the > optimized ReadStream>>match: method introduced with > Collections-ul.900, which does not set the stream to the end. The > traitComposition is read from a ReadStream of the class definition > string, hence the wrong read result if there are no traits in the > definition. > > Am Sa., 27. Juni 2020 um 11:17 Uhr schrieb Jakob Reschke > <[hidden email]>: >> >> Am Sa., 20. Juni 2020 um 02:57 Uhr schrieb Levente Uzonyi >> <[hidden email]>: >> > >> > Some class definitions >> > don't have trait compositions, but the reader is happy to read the first >> > two lines of the next class's definition as trait composition and class >> > trait composition. >> > >> >> I see the same thing happening when loading the INIFile package. This >> breaks my smalltalkCI tests even further, because Monticello now >> thinks that the class INIFile depends on the class INIFile and warns >> about it during the load... Curiously it seems to work when I do this >> in a Trunk image, although in smalltalkCI I also used a Trunk image, >> hmm. |
Free forum by Nabble | Edit this page |