3.10 image snapshot artifacts

Hi,

The attached image grabbed by (shift-viewer icon on halo) shows up blurry in
parts 3.10alpha#7108. The blurring occurs in both 16-bit and 32-bit depths.

Any idea on why this is happening?
Subbu

Weird effect. I guess you have to say which platform you are on. It's
probably some plugin issue...

Karl


subbukk wrote:

On Sunday 20 May 2007 8:48 pm, Karl wrote:
> Weird effect. I guess you have to say which platform you are on. It's
> probably some plugin issue...
Squeak vm 3.7.7 on Linux. But these artifacts also appear on Mac VM (3.8beta)
also. I dont have a Windows machine, so I cannot check it.

The shift-click on viewer icon to copy an image of a menu is new in 3.9, so I
suspect I must have hit a tender spot in Squeak code.

Regards .. Subbu

----- Original Message -----

From: [hidden email]

To: [hidden email]

Sent: Sunday, May 20, 2007 5:17 PM

Subject: Re: 3.10 image snapshot artifacts

On Sunday 20 May 2007 8:48 pm, Karl wrote:
> Weird effect. I guess you have to say which platform you are on. It's
> probably some plugin issue...
Squeak vm 3.7.7 on Linux. But these artifacts also appear on Mac VM (3.8beta)
also. I dont have a Windows machine, so I cannot check it.

The shift-click on viewer icon to copy an image of a menu is new in 3.9, so I
suspect I must have hit a tender spot in Squeak code.

Regards .. Subbu

Apologies for posting in html format

----- Original Message -----
From: "Andrew Tween" <[hidden email]>
To: "The general-purpose Squeak developers list"
<[hidden email]>
Sent: Sunday, May 20, 2007 5:14 PM
Subject: Re: 3.10 image snapshot artifacts


Hi,
It also happens on windows.
The ThumbnailImage morph that is created is 1 too small (possibly due to the
border?).
If you inspect it, and evaluate...
    self extent: self extent+1
then the blurriness disappears.
Cheers,
Andy
  ----- Original Message -----
  From: subbukk
  To: [hidden email]
  Sent: Sunday, May 20, 2007 5:17 PM
  Subject: Re: 3.10 image snapshot artifacts


  On Sunday 20 May 2007 8:48 pm, Karl wrote:
  > Weird effect. I guess you have to say which platform you are on. It's
  > probably some plugin issue...
  Squeak vm 3.7.7 on Linux. But these artifacts also appear on Mac VM (3.8beta)
  also. I dont have a Windows machine, so I cannot check it.

  The shift-click on viewer icon to copy an image of a menu is new in 3.9, so I
  suspect I must have hit a tender spot in Squeak code.

  Regards .. Subbu




--------------------------------------------------------------------------------


>
>

On Sunday 20 May 2007 9:47 pm, subbukk wrote:
> On Sunday 20 May 2007 8:48 pm, Karl wrote:
> > Weird effect. I guess you have to say which platform you are on. It's
> > probably some plugin issue...
>
> Squeak vm 3.7.7 on Linux. But these artifacts also appear on Mac VM
> (3.8beta) also. I dont have a Windows machine, so I cannot check it.
>
> The shift-click on viewer icon to copy an image of a menu is new in 3.9, so
> I suspect I must have hit a tender spot in Squeak code.
I traced out the code. The snapshot feature gives a thumbnail, not an image.
The actual image pops up when I turn on the popup feature this thumbnail, but
I can't figure out how to get to the image itself :-(.

Is there a simpler way to grab a snapshot image of a sub-menu?

TIA .. Subbu

On Sunday 20 May 2007 9:44 pm, Andrew Tween wrote:
> Hi,
> It also happens on windows.
> The ThumbnailImage morph that is created is 1 too small (possibly due to
> the border?). If you inspect it, and evaluate...
>     self extent: self extent+1
> then the blurriness disappears.
Thanks for the clue. The thumbnails extent calculation seems to be off by one
for x. The snapshot for an 124@80 extent comes out as 125@82. With one pixel
for the border on all sides, the width should have been 126.

In fact even "self extent: 1 + self extent" fixes the problem.

Regards .. Subbu

On Sunday 20 May 2007 9:44 pm, Andrew Tween wrote:
> Hi,
> It also happens on windows.
> The ThumbnailImage morph that is created is 1 too small (possibly due to
> the border?). If you inspect it, and evaluate...
>     self extent: self extent+1
> then the blurriness disappears.
You're right. The missing pixel annoyed me like a dripping faucet :-), so I
traced the whole creation of snapshot. Finally, I caught a suspect:
Morph>>duplicateMorphImage: evt
        ..
        dup := self asSnapshotThumbnail withSnapshotBorder.
        dup bounds: self bounds.
        ..
the second line should read "self fullbounds" since Morphs add a 1px border
along bottom-right to its underlying image forms. The fix cleared the
artifacts for menus and submenus. But for SystemWindows, it yields a Morph
with an 1px extra line along the top. The (fullBounds origin y) appears to be
less by one two, so I am not sure if this is the right fix. Can some Morphic
experts confirm this bug?

Regards,
Subbu