5.3 cannot rename subclasses of Error
Locked
5.3 cannot rename subclasses of Error
 
|
In trunk / 5.3 RC. - Make a subclass of Error called MyError1 - Make a subclass of Error called MyError2 - Delete MyError1 - Try to rename MyError2 to MyError1 The last step fails. No errors or debuggers, but the class is not renamed. Works in 5.2. |
Re: 5.3 cannot rename subclasses of Error
|
|
Hi Chris,
in a fresh image, I cannot reproduce this. Are you sure the class has not been renamed or is it possible that the class list was not updated properly?
Best, Christoph Von: Squeak-dev <[hidden email]> im Auftrag von Chris Muller <[hidden email]>
Gesendet: Dienstag, 25. Februar 2020 06:29:00 An: squeak dev Betreff: [squeak-dev] 5.3 cannot rename subclasses of Error In trunk / 5.3 RC.
- Make a subclass of Error called MyError1
- Make a subclass of Error called MyError2
- Delete MyError1
- Try to rename MyError2 to MyError1
The last step fails. No errors or debuggers, but the class is not renamed.
Works in 5.2.
Carpe Squeak!
|
Re: 5.3 cannot rename subclasses of Error
|
Hmm... I can reproduce the bug. Yet, calling "Error2 rename: #Error1" from a workspace works fine. Strange. Best, Marcel
|
Re: 5.3 cannot rename subclasses of Error
|
|
Von: Squeak-dev <[hidden email]> im Auftrag von Taeumel, Marcel
Gesendet: Dienstag, 25. Februar 2020 09:34:03 An: John Pfersich via Squeak-dev; Chris Muller Betreff: Re: [squeak-dev] 5.3 cannot rename subclasses of Error
Hmm... I can reproduce the bug. Yet, calling "Error2 rename: #Error1" from a workspace works fine. Strange.
Best,
Marcel
Carpe Squeak!
|
Re: 5.3 cannot rename subclasses of Error
|
|
> Maybe it is a sporadic issue? It is! Related to the ProgressNotification which I accidentially catch in Browser >> #renameClass. I wanted to get the UI call out of Class >> #rename:. That progress notification does not appear every time. Only above a certain threshold. That's why it appears to be sporadic. Best, Marcel
|
Re: 5.3 cannot rename subclasses of Error
|
|
Fixed. BUT: Please take a look at Kernel-mt.1305 Tools-mt.941 We need a name! :-) Best, Marcel
|
Re: 5.3 cannot rename subclasses of Error
|
|
On Feb 25, 2020, at 1:40 AM, Marcel Taeumel <[hidden email]> wrote:
UserNotification? NotificationOfUser? NotificationForUser?
|
Re: 5.3 cannot rename subclasses of Error
|
|
In reply to this post by marcel.taeumel
On Feb 25, 2020, at 1:40 AM, Marcel Taeumel <[hidden email]> wrote:
|
Re: 5.3 cannot rename subclasses of Error
|
|
Just "Notice"?
|
Re: 5.3 cannot rename subclasses of Error
|
|
In reply to this post by Eliot Miranda-2
RemarkNotification or NoticeNotification (though tautogram) sound good to me. Notice is so general that it could be a Morph or Model as well.
> UINotification?
> UserNotification?
> NotificationOfUser?
> NotificationForUser?
Uhm, I would rather like to reserve some of them for the UserNotification design I proposed here. And I would still be excited to hear your opinions about it :-)
Best, Christoph Von: Squeak-dev <[hidden email]> im Auftrag von Eliot Miranda <[hidden email]>
Gesendet: Dienstag, 25. Februar 2020 12:09:53 An: The general-purpose Squeak developers list Betreff: Re: [squeak-dev] 5.3 cannot rename subclasses of Error On Feb 25, 2020, at 1:40 AM, Marcel Taeumel <[hidden email]> wrote:
UserNotification?
NotificationOfUser?
NotificationForUser?
Carpe Squeak!
|
Re: 5.3 cannot rename subclasses of Error
|
|
In reply to this post by marcel.taeumel
On Feb 25, 2020, at 6:17 AM, Marcel Taeumel <[hidden email]> wrote:
|
Re: 5.3 cannot rename subclasses of Error
|
|
In reply to this post by marcel.taeumel
-1. "Notice" is such a generic, common word to steal from all applications that might want to create their own, especially for this one tiny little thing of a modal alert when renaming classes? Say, why do we need a modal alert at all? What happened to simply opening up a MessageSet on the references afterward? - Chris On Tue, Feb 25, 2020 at 8:17 AM Marcel Taeumel <[hidden email]> wrote:
|
Re: 5.3 cannot rename subclasses of Error
|
|
Hi Chris. > especially for this one tiny little thing of a modal alert when renaming classes? It is a more general issue. There should be no UI invocation code in a non-UI part of the system. So, "Transcript showln:." is fine but "self inform:" is not. Why? Because those cannot be trapped in scripts, which is - for example - unfortunate in automated pipelines such as our CI. > What happened to simply opening up a MessageSet on the references afterward? Still there. Unrelated to this issue. See the end of Browser >> #renameClass. > Say, why do we need a modal alert at all? I agree, that extra check in Class >> #rename: might not be necessary and maybe moved to our refactoring tools. Best, Marcel
|
| Free forum by Nabble | Edit this page |