Smalltalk › Squeak › Squeak - Dev

5.3 font size selection bug

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 5 messages Options
Chris Muller-3
Reply | Threaded
Open this post in threaded view
♦
♦
|

5.3 font size selection bug

Chris Muller-3
Appearance... | system fonts... | button font... |

then click on one of the point sizes in the righthand pane.  Although it appears to register the click, the list selection does not update.  Arrows too, no effect...
Christoph Thiede
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: 5.3 font size selection bug

Christoph Thiede

Nice catch, can reproduce it. I saw this effect at different places during the last weeks (e. g., changesets, but this is fixed now) - did we (Marcel) change the relevant list protocol? It would be nice to keep downward compatible.


Christoph

Von: Squeak-dev <[hidden email]> im Auftrag von Chris Muller <[hidden email]>
Gesendet: Freitag, 3. Januar 2020 23:31:52
An: squeak dev
Betreff: [squeak-dev] 5.3 font size selection bug
 
Appearance... | system fonts... | button font... |

then click on one of the point sizes in the righthand pane.  Although it appears to register the click, the list selection does not update.  Arrows too, no effect...



Carpe Squeak!
marcel.taeumel
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: 5.3 font size selection bug

marcel.taeumel
> Although it appears to register the click, the list selection does not update. 

Fixed in Morphic-mt.1614.

> It would be nice to keep downward compatible.

In general, yes. In this case, challenging because that view -> model communication can be performance critical. Models (or tools) that forgot to send some changed-event, can easily be fixed. No need to bring back those hacks in PluggableListMorph again.

Best,
Marcel

Am 04.01.2020 02:23:33 schrieb Thiede, Christoph <[hidden email]>:

Nice catch, can reproduce it. I saw this effect at different places during the last weeks (e. g., changesets, but this is fixed now) - did we (Marcel) change the relevant list protocol? It would be nice to keep downward compatible.


Christoph

Von: Squeak-dev <[hidden email]> im Auftrag von Chris Muller <[hidden email]>
Gesendet: Freitag, 3. Januar 2020 23:31:52
An: squeak dev
Betreff: [squeak-dev] 5.3 font size selection bug
 
Appearance... | system fonts... | button font... |

then click on one of the point sizes in the righthand pane.  Although it appears to register the click, the list selection does not update.  Arrows too, no effect...
Christoph Thiede
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: 5.3 font size selection bug

Christoph Thiede

Hi Marcel, thanks for the fix!


Specific to the FontChooserTool: Why do we need

self changed: #pointSizeList.

in the method you patched (#selectedPointSizeIndex:)?


> No need to bring back those hacks in PluggableListMorph again.


So the problem is that in past models were encouraged not to signal a selection change after a list change was signaled?
Then, in theory, it would be possible to do something like this:

PluggableListMorph >> update: aSymbol

aSymbol == getListSelector ifTrue: [
self updateList.
model isDec2019Compatible ifFalse: [
self update: getIndexSelector]].
aSymbol == getIndexSelector ifTrue: [^ self updateListSelection].
...

I would bet that out there are many more models that won't work after the 5.3 release. I'm afraid there is also a world outside of Trunk :(
It just would be sad if five years later, someone wants to try out any cool Squeak package developed for Squeak 5.1 that uses lists, and, without special knowledge of the bug, he or she will fail to use it for this trivial reason.
On the other hand, of course, I see the added complexity of such a versioning mechanism ...

Best,
Christoph



Von: Squeak-dev <[hidden email]> im Auftrag von Taeumel, Marcel
Gesendet: Montag, 6. Januar 2020 09:53 Uhr
An: John Pfersich via Squeak-dev; Chris Muller
Betreff: Re: [squeak-dev] 5.3 font size selection bug
 
> Although it appears to register the click, the list selection does not update. 

Fixed in Morphic-mt.1614.

> It would be nice to keep downward compatible.

In general, yes. In this case, challenging because that view -> model communication can be performance critical. Models (or tools) that forgot to send some changed-event, can easily be fixed. No need to bring back those hacks in PluggableListMorph again.

Best,
Marcel

Am 04.01.2020 02:23:33 schrieb Thiede, Christoph <[hidden email]>:

Nice catch, can reproduce it. I saw this effect at different places during the last weeks (e. g., changesets, but this is fixed now) - did we (Marcel) change the relevant list protocol? It would be nice to keep downward compatible.


Christoph

Von: Squeak-dev <[hidden email]> im Auftrag von Chris Muller <[hidden email]>
Gesendet: Freitag, 3. Januar 2020 23:31:52
An: squeak dev
Betreff: [squeak-dev] 5.3 font size selection bug
 
Appearance... | system fonts... | button font... |

then click on one of the point sizes in the righthand pane.  Although it appears to register the click, the list selection does not update.  Arrows too, no effect...



Carpe Squeak!
marcel.taeumel
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: 5.3 font size selection bug

marcel.taeumel
> So the problem is that in past models were encouraged not to signal a selection change after a list change was signaled?

I wouldn't say "encouraged". It rather just happened because of the glitch. People get used to it or don't fall over it.

Best,
Marcel

Am 06.01.2020 14:25:07 schrieb Thiede, Christoph <[hidden email]>:

Hi Marcel, thanks for the fix!


Specific to the FontChooserTool: Why do we need

self changed: #pointSizeList.

in the method you patched (#selectedPointSizeIndex:)?


> No need to bring back those hacks in PluggableListMorph again.


So the problem is that in past models were encouraged not to signal a selection change after a list change was signaled?
Then, in theory, it would be possible to do something like this:

PluggableListMorph >> update: aSymbol

aSymbol == getListSelector ifTrue: [
self updateList.
model isDec2019Compatible ifFalse: [
self update: getIndexSelector]].
aSymbol == getIndexSelector ifTrue: [^ self updateListSelection].
...

I would bet that out there are many more models that won't work after the 5.3 release. I'm afraid there is also a world outside of Trunk :(
It just would be sad if five years later, someone wants to try out any cool Squeak package developed for Squeak 5.1 that uses lists, and, without special knowledge of the bug, he or she will fail to use it for this trivial reason.
On the other hand, of course, I see the added complexity of such a versioning mechanism ...

Best,
Christoph



Von: Squeak-dev <[hidden email]> im Auftrag von Taeumel, Marcel
Gesendet: Montag, 6. Januar 2020 09:53 Uhr
An: John Pfersich via Squeak-dev; Chris Muller
Betreff: Re: [squeak-dev] 5.3 font size selection bug
 
> Although it appears to register the click, the list selection does not update. 

Fixed in Morphic-mt.1614.

> It would be nice to keep downward compatible.

In general, yes. In this case, challenging because that view -> model communication can be performance critical. Models (or tools) that forgot to send some changed-event, can easily be fixed. No need to bring back those hacks in PluggableListMorph again.

Best,
Marcel

Am 04.01.2020 02:23:33 schrieb Thiede, Christoph <[hidden email]>:

Nice catch, can reproduce it. I saw this effect at different places during the last weeks (e. g., changesets, but this is fixed now) - did we (Marcel) change the relevant list protocol? It would be nice to keep downward compatible.


Christoph

Von: Squeak-dev <[hidden email]> im Auftrag von Chris Muller <[hidden email]>
Gesendet: Freitag, 3. Januar 2020 23:31:52
An: squeak dev
Betreff: [squeak-dev] 5.3 font size selection bug
 
Appearance... | system fonts... | button font... |

then click on one of the point sizes in the righthand pane.  Although it appears to register the click, the list selection does not update.  Arrows too, no effect...
Free forum by Nabble Edit this page