A bug with class renaming

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

A bug with class renaming

Mateusz Grotek
Is this problem already solved in the forthcoming 2.6 or it's new?

To reproduce:
1. Create a class.
2. Rightclick on the class name and choose "Rename class".
3. Enter the new name and accept.

Reply | Threaded
Open this post in threaded view
|

Re: A bug with class renaming

Tobias Pape
Hey

On 02.04.2015, at 15:20, Mateusz Grotek <[hidden email]> wrote:

> Is this problem already solved in the forthcoming 2.6 or it's new?
>
> To reproduce:
> 1. Create a class.
> 2. Rightclick on the class name and choose "Rename class".
> 3. Enter the new name and accept.


This is fixed for 4.5 and Trunk (upcoming 4.6).
For 4.5 please use the update functionality.

Best
        -Tobias



Reply | Threaded
Open this post in threaded view
|

Re: A bug with class renaming

Mateusz Grotek
Dnia 02.04.2015 15:19:10, Tobias Pape napisał(a):

> Hey
>
> On 02.04.2015, at 15:20, Mateusz Grotek <[hidden email]>  
> wrote:
>
> > Is this problem already solved in the forthcoming 2.6 or it's new?
> >
> > To reproduce:
> > 1. Create a class.
> > 2. Rightclick on the class name and choose "Rename class".
> > 3. Enter the new name and accept.
>
>
> This is fixed for 4.5 and Trunk (upcoming 4.6).
> For 4.5 please use the update functionality.
>
> Best
> -Tobias
>
>
>
>
Hi,
(Of course I wanted to say 4.6, not 2.6) Well, it seems the update  
(click on logo, and then "Update Squeak") does not solve the problem.  
Can you verify it?
Mateusz


Reply | Threaded
Open this post in threaded view
|

Re: A bug with class renaming

Tobias Pape
Hi Mateusz

On 02.04.2015, at 16:06, Mateusz Grotek <[hidden email]> wrote:

> Dnia 02.04.2015 15:19:10, Tobias Pape napisał(a):
>> Hey
>> On 02.04.2015, at 15:20, Mateusz Grotek <[hidden email]> wrote:
>> > Is this problem already solved in the forthcoming 2.6 or it's new?
>> >
>> > To reproduce:
>> > 1. Create a class.
>> > 2. Rightclick on the class name and choose "Rename class".
>> > 3. Enter the new name and accept.
>> This is fixed for 4.5 and Trunk (upcoming 4.6).
>> For 4.5 please use the update functionality.
>> Best
>> -Tobias
> Hi,
> (Of course I wanted to say 4.6, not 2.6) Well, it seems the update (click on logo, and then "Update Squeak") does not solve the problem. Can you verify it?
> Mateusz


Can you explain what happens after step 3 and what should happen?
It might be we are talking about different bugs.

Best
        -Tobias
Reply | Threaded
Open this post in threaded view
|

Re: A bug with class renaming

Mateusz Grotek
Dnia 02.04.2015 16:07:54, Tobias Pape napisał(a):

> Hi Mateusz
>
> On 02.04.2015, at 16:06, Mateusz Grotek <[hidden email]>  
> wrote:
>
> > Dnia 02.04.2015 15:19:10, Tobias Pape napisał(a):
> >> Hey
> >> On 02.04.2015, at 15:20, Mateusz Grotek <[hidden email]>  
> wrote:
> >> > Is this problem already solved in the forthcoming 2.6 or it's  
> new?
> >> >
> >> > To reproduce:
> >> > 1. Create a class.
> >> > 2. Rightclick on the class name and choose "Rename class".
> >> > 3. Enter the new name and accept.
> >> This is fixed for 4.5 and Trunk (upcoming 4.6).
> >> For 4.5 please use the update functionality.
> >> Best
> >> -Tobias
> > Hi,
> > (Of course I wanted to say 4.6, not 2.6) Well, it seems the update  
> (click on logo, and then "Update Squeak") does not solve the problem.  
> Can you verify it?
> > Mateusz
>
>
> Can you explain what happens after step 3 and what should happen?
> It might be we are talking about different bugs.
>
> Best
> -Tobias
>
Sure. After accepting the new name an exception shows up.
Its message is: MessageNotUnderstood: PutTheRenamedClassNameHere  
class>>updateMethodBindingsTo:
The exception is called from the following line:
   aClass updateMethodBindingsTo: newBinding.
of: Environment>>renameClass:from:to:

After closing the exception window it reopens ad infinitum. It's  
impossible to work in the image after that, because more and more  
exceptions show up after doing some trivial things.

It's probably related to the new environments functionality.

Best wishes,
Mateusz



Reply | Threaded
Open this post in threaded view
|

Re: A bug with class renaming

Tobias Pape
Hi Mateuz

On 02.04.2015, at 17:14, Mateusz Grotek <[hidden email]> wrote:

> Dnia 02.04.2015 16:07:54, Tobias Pape napisał(a):
>> Hi Mateusz
>> On 02.04.2015, at 16:06, Mateusz Grotek <[hidden email]> wrote:
>> > Dnia 02.04.2015 15:19:10, Tobias Pape napisał(a):
>> >> Hey
>> >> On 02.04.2015, at 15:20, Mateusz Grotek <[hidden email]> wrote:
>> >> > Is this problem already solved in the forthcoming 2.6 or it's new?
>> >> >
>> >> > To reproduce:
>> >> > 1. Create a class.
>> >> > 2. Rightclick on the class name and choose "Rename class".
>> >> > 3. Enter the new name and accept.
>> >> This is fixed for 4.5 and Trunk (upcoming 4.6).
>> >> For 4.5 please use the update functionality.
>> >> Best
>> >> -Tobias
>> > Hi,
>> > (Of course I wanted to say 4.6, not 2.6) Well, it seems the update (click on logo, and then "Update Squeak") does not solve the problem. Can you verify it?
>> > Mateusz
>> Can you explain what happens after step 3 and what should happen?
>> It might be we are talking about different bugs.
>> Best
>> -Tobias
> Sure. After accepting the new name an exception shows up.
> Its message is: MessageNotUnderstood: PutTheRenamedClassNameHere class>>updateMethodBindingsTo:
> The exception is called from the following line:
>  aClass updateMethodBindingsTo: newBinding.
> of: Environment>>renameClass:from:to:
>
> After closing the exception window it reopens ad infinitum. It's impossible to work in the image after that, because more and more exceptions show up after doing some trivial things.
>
> It's probably related to the new environments functionality.

I cannot reproduce this.
Class renaming works just fine in trunk and 4.5.
What version is Squeak reporting?

Best
        -Tobias
Reply | Threaded
Open this post in threaded view
|

Re: A bug with class renaming

Mateusz Grotek
> I cannot reproduce this.
> Class renaming works just fine in trunk and 4.5.
> What version is Squeak reporting?
>
> Best
> -Tobias
>

I did exactly the following to verify everything.

1. I downloaded the all-in-one squeak distribution from  
http://ftp.squeak.org/4.5/Squeak-4.5-All-in-One.zip
$ wget 'http://ftp.squeak.org/4.5/Squeak-4.5-All-in-One.zip'
$ unzip Squeak-4.5-All-in-One.zip
$ cd Squeak-4.5-All-In-One
$ ./squeak.sh

2. I clicked on the logo, and then "Update Squeak". A window with  
progress bars and Transcript showed up. Waiting...
3. A window with the title: "Warning" and the following content showed  
up:
About to serialize an empty package.

Select Proceed to continue, or close this window to cancel the  
operation.
4. I clicked Proceed. The update continued. A window with the title  
"Note:" and the following content showed up:
Update completed.
Current update number: 13703
5. I clicked OK and closed Transcript.
6. I clicked Tools->Browser, scrolled down to the end of the leftmost  
list, rightclicked and chose "add item...". I entered XYZ and clicked  
Accept.
7. I changed NameOfSubclass to XYZ and CTRL-s
8. I rightclicked on the XYZ class and chose "rename class...". I  
entered "ABC" and clicked "Accept(s)".
9. An exception message showed up with the title:  
"MessageNotUnderstood: ABC class>>updateMethodBindingsTo:"
The source of the exception is the line:
        aClass updateMethodBindingsTo: newBinding.
of: Environment>>renameClass:from:to:
10. An exception message showed up with the title:  
"MessageNotUnderstood: UndefinedObject>>superclass".
The source of the exception is the line:
                childs := col select: [:class | class isTrait not and:  
[class superclass = ea]].
of: Browser>>createHierarchyTreeOf:
11. I clicked on the logo and "About Squeak". The Squeak version is:  
#13703

That's it. My operating system is Gentoo Linux.

Please tell me the first step which is different in your case.

Mateusz

Reply | Threaded
Open this post in threaded view
|

Re: A bug with class renaming

Mateusz Grotek
I've opened a ticket for it: #0007827

Reply | Threaded
Open this post in threaded view
|

Re: A bug with class renaming

Tobias Pape
Hi,
On 04.04.2015, at 15:47, Mateusz Grotek <[hidden email]> wrote:

> I've opened a ticket for it: #0007827

Sorry for taking so long.
I reproduced it.
For Squeak-4.5 I fixed it in Kernel-topa.845.
Please see if your problem is gone :)

Best
        -Tobias

Reply | Threaded
Open this post in threaded view
|

Re: A bug with class renaming

Mateusz Grotek
Dnia 10.04.2015 23:08:34, Tobias Pape napisał(a):

> Hi,
> On 04.04.2015, at 15:47, Mateusz Grotek <[hidden email]>  
> wrote:
>
> > I've opened a ticket for it: #0007827
>
> Sorry for taking so long.
> I reproduced it.
> For Squeak-4.5 I fixed it in Kernel-topa.845.
> Please see if your problem is gone :)
>
> Best
> -Tobias
>
>

Yup! Your hotfix has solved it. Great job.

Best wishes,
Mateusz


Reply | Threaded
Open this post in threaded view
|

Re: A bug with class renaming

Mateusz Grotek
Dnia 12.04.2015 06:17:34, Mateusz Grotek napisał(a):

> Dnia 10.04.2015 23:08:34, Tobias Pape napisał(a):
>> Hi,
>> On 04.04.2015, at 15:47, Mateusz Grotek <[hidden email]>  
>> wrote:
>>
>> > I've opened a ticket for it: #0007827
>>
>> Sorry for taking so long.
>> I reproduced it.
>> For Squeak-4.5 I fixed it in Kernel-topa.845.
>> Please see if your problem is gone :)
>>
>> Best
>> -Tobias
>>
>>
>
> Yup! Your hotfix has solved it. Great job.
>
> Best wishes,
> Mateusz
>
>
Please close the ticket.