Adds a new preference for the caret-with and changes the default
color of the caret http://bugs.impara.de/view.php?id=3790 Name: Graphics-ar.39 Author: ar Time: 13 July 2006, 11:01:44 am UUID: 8493073d-14aa-7643-9a13-574d84f7b2c3 Ancestors: Graphics-ar.38 - include fix from http://bugs.impara.de/view.php?id=3570 + test http://squeaksource.com/ToolBuilder/ToolBuilder-Kernel-ar.16.mcz http://squeaksource.com/ToolBuilder/ToolBuilder-Morphic-ar.19.mcz http://squeaksource.com/ToolBuilder/ToolBuilder-SUnit-ar.11.mcz http://squeaksource.com/ToolBuilder/ToolBuilder-MVC-dtl.12.mcz The main change is that some support for menus has been added. |
On Jul 14, 2006, at 10:34 AM, Stéphane Ducasse wrote: > http://squeaksource.com/ToolBuilder/ToolBuilder-Kernel-ar.16.mcz > http://squeaksource.com/ToolBuilder/ToolBuilder-Morphic-ar.19.mcz > http://squeaksource.com/ToolBuilder/ToolBuilder-SUnit-ar.11.mcz > http://squeaksource.com/ToolBuilder/ToolBuilder-MVC-dtl.12.mcz > > The main change is that some support for menus has been added. As it happens, I just committed some ToolBuilder fixes. The main issue is that fix supplied for (http://bugs.impara.de/ view.php?id=3588) is completely bogus. The failures were not expected, they indicated a problem. There were also problems with the tests. I've committed the following packages, which fix the tests and make ToolBuilder-SUnit pass them. There's still a failing test for Morphic, but I'm not sure what the correct fix is. MVC seems to be badly broken. http://squeaksource.com/ToolBuilder/ToolBuilder-Kernel-cwp.17.mcz http://squeaksource.com/ToolBuilder/ToolBuilder-SUnit-cwp.12.mcz Colin |
How do we proceed?
Are you a package maintainer? Should I proceed and load them or is it andreas the boss of these packages? Stef On 14 juil. 06, at 18:02, Colin Putney wrote: > > On Jul 14, 2006, at 10:34 AM, Stéphane Ducasse wrote: > >> http://squeaksource.com/ToolBuilder/ToolBuilder-Kernel-ar.16.mcz >> http://squeaksource.com/ToolBuilder/ToolBuilder-Morphic-ar.19.mcz >> http://squeaksource.com/ToolBuilder/ToolBuilder-SUnit-ar.11.mcz >> http://squeaksource.com/ToolBuilder/ToolBuilder-MVC-dtl.12.mcz >> >> The main change is that some support for menus has been added. > > As it happens, I just committed some ToolBuilder fixes. > > The main issue is that fix supplied for (http://bugs.impara.de/ > view.php?id=3588) is completely bogus. The failures were not > expected, they indicated a problem. There were also problems with > the tests. > > I've committed the following packages, which fix the tests and make > ToolBuilder-SUnit pass them. There's still a failing test for > Morphic, but I'm not sure what the correct fix is. MVC seems to be > badly broken. > > http://squeaksource.com/ToolBuilder/ToolBuilder-Kernel-cwp.17.mcz > http://squeaksource.com/ToolBuilder/ToolBuilder-SUnit-cwp.12.mcz > > Colin > |
On Jul 14, 2006, at 12:11 PM, stéphane ducasse wrote: > How do we proceed? > Are you a package maintainer? > Should I proceed and load them or is it andreas the boss of these > packages? Andreas is the boss, although I do try to keep ToolBuilder-SUnit up to date. Andreas, The issue with Morphic is MorphicToolBuilderTest>>testAddAction. The test supplies a selector as action, but MorphicToolBuilder seems to want a MessageSend. It could probably work either way, but it's hard to tell what the intention was. Also, see my fixes to #testButtonInitiallyEnabled and #testButtonInitiallyDisabled. Colin |
In reply to this post by Colin Putney
Colin Putney wrote:
> As it happens, I just committed some ToolBuilder fixes. > > The main issue is that fix supplied for > (http://bugs.impara.de/view.php?id=3588) is completely bogus. The > failures were not expected, they indicated a problem. There were also > problems with the tests. Ouch. Thanks for looking at it. Cheers, - Andreas |
In reply to this post by stéphane ducasse-2
stéphane ducasse wrote:
> How do we proceed? Go for it. The fixes look good to me. Cheers, - Andreas > Are you a package maintainer? > Should I proceed and load them or is it andreas the boss of these packages? > > Stef > > On 14 juil. 06, at 18:02, Colin Putney wrote: > >> >> On Jul 14, 2006, at 10:34 AM, Stéphane Ducasse wrote: >> >>> http://squeaksource.com/ToolBuilder/ToolBuilder-Kernel-ar.16.mcz >>> http://squeaksource.com/ToolBuilder/ToolBuilder-Morphic-ar.19.mcz >>> http://squeaksource.com/ToolBuilder/ToolBuilder-SUnit-ar.11.mcz >>> http://squeaksource.com/ToolBuilder/ToolBuilder-MVC-dtl.12.mcz >>> >>> The main change is that some support for menus has been added. >> >> As it happens, I just committed some ToolBuilder fixes. >> >> The main issue is that fix supplied for >> (http://bugs.impara.de/view.php?id=3588) is completely bogus. The >> failures were not expected, they indicated a problem. There were also >> problems with the tests. >> >> I've committed the following packages, which fix the tests and make >> ToolBuilder-SUnit pass them. There's still a failing test for Morphic, >> but I'm not sure what the correct fix is. MVC seems to be badly broken. >> >> http://squeaksource.com/ToolBuilder/ToolBuilder-Kernel-cwp.17.mcz >> http://squeaksource.com/ToolBuilder/ToolBuilder-SUnit-cwp.12.mcz >> >> Colin >> > > > |
Ok I will integrate them in the next batch then.
Stef > stéphane ducasse wrote: >> How do we proceed? > > Go for it. The fixes look good to me. > > Cheers, > - Andreas > >> Are you a package maintainer? >> Should I proceed and load them or is it andreas the boss of these >> packages? >> Stef >> On 14 juil. 06, at 18:02, Colin Putney wrote: >>> >>> On Jul 14, 2006, at 10:34 AM, Stéphane Ducasse wrote: >>> >>>> http://squeaksource.com/ToolBuilder/ToolBuilder-Kernel-ar.16.mcz >>>> http://squeaksource.com/ToolBuilder/ToolBuilder-Morphic-ar.19.mcz >>>> http://squeaksource.com/ToolBuilder/ToolBuilder-SUnit-ar.11.mcz >>>> http://squeaksource.com/ToolBuilder/ToolBuilder-MVC-dtl.12.mcz >>>> >>>> The main change is that some support for menus has been added. >>> >>> As it happens, I just committed some ToolBuilder fixes. >>> >>> The main issue is that fix supplied for (http://bugs.impara.de/ >>> view.php?id=3588) is completely bogus. The failures were not >>> expected, they indicated a problem. There were also problems with >>> the tests. >>> >>> I've committed the following packages, which fix the tests and >>> make ToolBuilder-SUnit pass them. There's still a failing test >>> for Morphic, but I'm not sure what the correct fix is. MVC seems >>> to be badly broken. >>> >>> http://squeaksource.com/ToolBuilder/ToolBuilder-Kernel-cwp.17.mcz >>> http://squeaksource.com/ToolBuilder/ToolBuilder-SUnit-cwp.12.mcz >>> >>> Colin >>> > > |
In reply to this post by Colin Putney
So
Did you merge your fixes? Can I take the latest version then? Stef On 14 juil. 06, at 18:30, Colin Putney wrote: > > On Jul 14, 2006, at 12:11 PM, stéphane ducasse wrote: > >> How do we proceed? >> Are you a package maintainer? >> Should I proceed and load them or is it andreas the boss of these >> packages? > > Andreas is the boss, although I do try to keep ToolBuilder-SUnit up > to date. > > Andreas, > > The issue with Morphic is MorphicToolBuilderTest>>testAddAction. > The test supplies a selector as action, but MorphicToolBuilder > seems to want a MessageSend. It could probably work either way, but > it's hard to tell what the intention was. > > Also, see my fixes to #testButtonInitiallyEnabled and > #testButtonInitiallyDisabled. > > Colin > > > |
Free forum by Nabble | Edit this page |