Smalltalk › Squeak › Squeak - Dev

AbstractSound bug in 4.1 rc5

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

Stéphane Rollandin

AbstractSound bug in 4.1 rc5

one more bug:

in AbstractSound the method

, aSound
"Return the concatenation of the receiver and the argument sound."

^ SequentialSound new
add: self;
add: aSound

...does not work because the method SequentialSound>>#add: has been
modified to return the added sound, instead of the receiver:

add: aSound

sounds := sounds copyWith: aSound.
^aSound

previously (in 3.8 for example) it was:

add: aSound

sounds _ sounds copyWith: aSound.

Stef

Stéphane Rollandin

Re: AbstractSound bug in 4.1 rc5

and we have the same change in MixedSound>>#add: leading to the same
error in AbstractSound>>+

may be this has something to do with the sounds problem what where
discussed recently ?

anyway the fix is easy, just add a #yourself ...

AbstractSound
+ aSound
"Return the mix of the receiver and the argument sound."

^ MixedSound new
add: self;
add: aSound;
yourself

AbstractSound
, aSound
"Return the concatenation of the receiver and the argument sound."

^ SequentialSound new
add: self;
add: aSound;
yourself

Stef

Nicolas Cellier

Re: AbstractSound bug in 4.1 rc5

Sorry Stephane,
That was me.
I think it is better to have a uniform behaviour: add:return the argument.

Nicolas

2010/4/17 Stéphane Rollandin <[hidden email]>:

> and we have the same change in MixedSound>>#add: leading to the same error
> in AbstractSound>>+
>
> may be this has something to do with the sounds problem what where discussed
> recently ?
>
> anyway the fix is easy, just add a #yourself ...
>
>
> AbstractSound
> + aSound
> "Return the mix of the receiver and the argument sound."
>
> ^ MixedSound new
> add: self;
> add: aSound;
> yourself
>
>
> AbstractSound
> , aSound
> "Return the concatenation of the receiver and the argument sound."
>
> ^ SequentialSound new
> add: self;
> add: aSound;
> yourself
>
>
> Stef
>
>
>
>