AndreasSystemProfiler missing CompiledMethod>>who

> On 2013-03-05, at 12:06, Frank Shearar <[hidden email]> wrote:
>
>> On 5 March 2013 00:46, David T. Lewis <[hidden email]> wrote:
>>> This is just a convenience method that probably belongs in the AndreasSystemProfiler
>>> package (or in Squeak trunk?).
>>>
>>> Or if I am guessing right it might be just a matter of changing the printOn:
>>>
>>> QSystemTally>>printOn: aStream
>>>        aStream print: class; nextPutAll: '>>'; print: (method ifNotNil:[method selector storeString]).
>>>        aStream nextPutAll: ' -- '; print: tally.
>
> That's the right fix, yes.
>
>> I'd imagine it does something like CompiledMethod >> #timeStamp, that
>> is, displays a bit of the CM's metadata. That seems like a good
>> candidate for trunk.
>>
>> frank
>
> #who was removed recently when we introduced method properties. It used to answer {class. selector} of the method. The reason was that it was a very expensive operation, it used to scan all classes to find the new method. So if you needed both the class and selector, it would have to do the scan twice.
>
> Now it would be simple enough to re-implement for compatibility, but then it is very easy to change the senders, too. And since it makes the senders a lot more readable we have not re-implemented #who.

> On 2013-03-05, at 12:06, Frank Shearar <[hidden email]> wrote:
>
> > On 5 March 2013 00:46, David T. Lewis <[hidden email]> wrote:
> >> This is just a convenience method that probably belongs in the AndreasSystemProfiler
> >> package (or in Squeak trunk?).
> >>
> >> Or if I am guessing right it might be just a matter of changing the printOn:
> >>
> >> QSystemTally>>printOn: aStream
> >>        aStream print: class; nextPutAll: '>>'; print: (method ifNotNil:[method selector storeString]).
> >>        aStream nextPutAll: ' -- '; print: tally.
>
> That's the right fix, yes.
>
> > I'd imagine it does something like CompiledMethod >> #timeStamp, that
> > is, displays a bit of the CM's metadata. That seems like a good
> > candidate for trunk.
> >
> > frank
>
> #who was removed recently when we introduced method properties. It used to answer {class. selector} of the method. The reason was that it was a very expensive operation, it used to scan all classes to find the new method. So if you needed both the class and selector, it would have to do the scan twice.
>
> Now it would be simple enough to re-implement for compatibility, but then it is very easy to change the senders, too. And since it makes the senders a lot more readable we have not re-implemented #who.
>
> - Bert -

> On 2013-03-05, at 12:06, Frank Shearar <[hidden email]> wrote:
>
>> On 5 March 2013 00:46, David T. Lewis <[hidden email]> wrote:
>>> This is just a convenience method that probably belongs in the AndreasSystemProfiler
>>> package (or in Squeak trunk?).
>>>
>>> Or if I am guessing right it might be just a matter of changing the printOn:
>>>
>>> QSystemTally>>printOn: aStream
>>>        aStream print: class; nextPutAll: '>>'; print: (method ifNotNil:[method selector storeString]).
>>>        aStream nextPutAll: ' -- '; print: tally.
>
> That's the right fix, yes.
>
>> I'd imagine it does something like CompiledMethod >> #timeStamp, that
>> is, displays a bit of the CM's metadata. That seems like a good
>> candidate for trunk.
>>
>> frank
>
> #who was removed recently when we introduced method properties. It used to answer {class. selector} of the method. The reason was that it was a very expensive operation, it used to scan all classes to find the new method. So if you needed both the class and selector, it would have to do the scan twice.
>
> Now it would be simple enough to re-implement for compatibility, but then it is very easy to change the senders, too. And since it makes the senders a lot more readable we have not re-implemented #who.
>
> - Bert -
>
>
>

> -----Original Message-----
> From: [hidden email] [mailto:squeak-dev-
> [hidden email]] On Behalf Of David T. Lewis
> Sent: Wednesday, March 06, 2013 7:15 AM
> To: The general-purpose Squeak developers list
> Cc: [hidden email]
> Subject: Re: [squeak-dev] AndreasSystemProfiler missing
> CompiledMethod>>who
>
> On Tue, Mar 05, 2013 at 12:12:51PM +0100, Bert Freudenberg wrote:
> > On 2013-03-05, at 12:06, Frank Shearar <[hidden email]> wrote:
> >
> > > On 5 March 2013 00:46, David T. Lewis <[hidden email]> wrote:
> > >> This is just a convenience method that probably belongs in the
> > >> AndreasSystemProfiler package (or in Squeak trunk?).
> > >>
> > >> Or if I am guessing right it might be just a matter of changing the

> selector storeString]).
> > >>        aStream nextPutAll: ' -- '; print: tally.
> >
> > That's the right fix, yes.
> >
>
> Trivial patch attached. Ron or Eliot, can one of you update this on
> http://ss3.gemstone.com/ss/AndreasSystemProfiler?
>
> Thanks!
> Dave
>