Smalltalk › Squeak › Squeak - Dev

[BUG] Browsers vertically squished in trunk?

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

6 messages Options

Casey Ransberger-2

[BUG] Browsers vertically squished in trunk?

When I open a system browser in recent trunk images, the browser opens up squished vertically so the first thing I need to do is resize it. I could swear I'd seen this some place before, and the fix wound up being in toolbuilder somewhere. IIRC Andreas pointed out the fix, but I can't find the message anywhere in any of my inboxes.

As a sanity check, are other people seeing this too? I might note that I've been using Squeak on a very small screen lately, if that makes any difference (I don't know, maybe the browser tries to open at a % of total screen real estate, which is too small on my box?)

Casey Ransberger-2

Re: [BUG] Browsers vertically squished in trunk?

Grrr. Figured out what the old bug was, and this looks like the same behavior, but I don't think it's the same bug. That was related to a Polymorph override that I don't have in my trunk image.

On Tue, Mar 30, 2010 at 10:25 AM, Casey Ransberger <[hidden email]> wrote:

When I open a system browser in recent trunk images, the browser opens up squished vertically so the first thing I need to do is resize it. I could swear I'd seen this some place before, and the fix wound up being in toolbuilder somewhere. IIRC Andreas pointed out the fix, but I can't find the message anywhere in any of my inboxes.

As a sanity check, are other people seeing this too? I might note that I've been using Squeak on a very small screen lately, if that makes any difference (I don't know, maybe the browser tries to open at a % of total screen real estate, which is too small on my box?)

Casey Ransberger-2

Re: [BUG] Browsers vertically squished in trunk?

In reply to this post by Casey Ransberger-2

Found it.

RealEstateAgent class>>standardWindowExtent

<snip>

^ (allowedArea extent - (grid*(maxLevel+1*2) + (grid//2))) min: StandardSize "600@400"].

Something is going wrong with the math here. Changing this line to (note that I've just commented everything out and returned 600@400) fixes the bug, but probably breaks tons of other stuff:

^"^ (allowedArea extent - (grid*(maxLevel+1*2) + (grid//2))) min: StandardSize "600@400].

I'm going to see if I can figure out exactly what's going wrong with this, and if so, push a proper fix to the Inbox.

On Tue, Mar 30, 2010 at 10:25 AM, Casey Ransberger <[hidden email]> wrote:

When I open a system browser in recent trunk images, the browser opens up squished vertically so the first thing I need to do is resize it. I could swear I'd seen this some place before, and the fix wound up being in toolbuilder somewhere. IIRC Andreas pointed out the fix, but I can't find the message anywhere in any of my inboxes.

As a sanity check, are other people seeing this too? I might note that I've been using Squeak on a very small screen lately, if that makes any difference (I don't know, maybe the browser tries to open at a % of total screen real estate, which is too small on my box?)

Casey Ransberger-2

Re: [BUG] Browsers vertically squished in trunk?

Hmmm. Totally different behavior in this method if the preference #reverseWindowStagger is enabled. What I don't understand is why the window staggering policy should have anything to do with the default height or width of windows.

I am officially calling shenanigans on this method.

On Tue, Mar 30, 2010 at 1:56 PM, Casey Ransberger <[hidden email]> wrote:

Found it.

RealEstateAgent class>>standardWindowExtent
<snip>
^ (allowedArea extent - (grid*(maxLevel+1*2) + (grid//2))) min: StandardSize "600@400"].

Something is going wrong with the math here. Changing this line to (note that I've just commented everything out and returned 600@400) fixes the bug, but probably breaks tons of other stuff:

^"^ (allowedArea extent - (grid*(maxLevel+1*2) + (grid//2))) min: StandardSize "600@400].

I'm going to see if I can figure out exactly what's going wrong with this, and if so, push a proper fix to the Inbox.

On Tue, Mar 30, 2010 at 10:25 AM, Casey Ransberger <[hidden email]> wrote:

When I open a system browser in recent trunk images, the browser opens up squished vertically so the first thing I need to do is resize it. I could swear I'd seen this some place before, and the fix wound up being in toolbuilder somewhere. IIRC Andreas pointed out the fix, but I can't find the message anywhere in any of my inboxes.

As a sanity check, are other people seeing this too? I might note that I've been using Squeak on a very small screen lately, if that makes any difference (I don't know, maybe the browser tries to open at a % of total screen real estate, which is too small on my box?)

Nicolas Cellier

Re: [BUG] Browsers vertically squished in trunk?

2010/3/31 Casey Ransberger <[hidden email]>:
> Hmmm. Totally different behavior in this method if the preference
> #reverseWindowStagger is enabled. What I don't understand is why the window
> staggering policy should have anything to do with the default height or
> width of windows.
> I am officially calling shenanigans on this method.
>

Thank you for the nice idiom.
I don't understand anything to it, but
^self callingShenanigans
would certainly bring more poetry in the image than
^self primitiveFailed.

Nicolas

> On Tue, Mar 30, 2010 at 1:56 PM, Casey Ransberger <[hidden email]>
> wrote:
>>
>> Found it.
>> RealEstateAgent class>>standardWindowExtent
>> <snip>
>> ^ (allowedArea extent - (grid*(maxLevel+1*2) + (grid//2))) min:
>> StandardSize "600@400"].
>>
>> Something is going wrong with the math here. Changing this line to (note
>> that I've just commented everything out and returned 600@400) fixes the bug,
>> but probably breaks tons of other stuff:
>> ^"^ (allowedArea extent - (grid*(maxLevel+1*2) + (grid//2))) min:
>> StandardSize "600@400].
>> I'm going to see if I can figure out exactly what's going wrong with this,
>> and if so, push a proper fix to the Inbox.
>> On Tue, Mar 30, 2010 at 10:25 AM, Casey Ransberger
>> <[hidden email]> wrote:
>>>
>>> When I open a system browser in recent trunk images, the browser opens up
>>> squished vertically so the first thing I need to do is resize it. I could
>>> swear I'd seen this some place before, and the fix wound up being in
>>> toolbuilder somewhere. IIRC Andreas pointed out the fix, but I can't find
>>> the message anywhere in any of my inboxes.
>>> As a sanity check, are other people seeing this too? I might note that
>>> I've been using Squeak on a very small screen lately, if that makes any
>>> difference (I don't know, maybe the browser tries to open at a % of total
>>> screen real estate, which is too small on my box?)
>
>
>
>
>

Casey Ransberger-2

Re: [BUG] Browsers vertically squished in trunk?

Yes, Nicolas, shenanigans were at some point sent to this method.

I did the simplest thing possible to make windows big enough to use by default on small screens (a browser gets unusable around height 300 and below) and decided to hold off on merciless refactoring until 4.2.

Fixed in System-cbr.306, which is in the Inbox.

On Tue, Mar 30, 2010 at 3:51 PM, Nicolas Cellier <[hidden email]> wrote:

2010/3/31 Casey Ransberger <[hidden email]>:

> Hmmm. Totally different behavior in this method if the preference
> #reverseWindowStagger is enabled. What I don't understand is why the window
> staggering policy should have anything to do with the default height or
> width of windows.
> I am officially calling shenanigans on this method.
>

Thank you for the nice idiom.
I don't understand anything to it, but
^self callingShenanigans
would certainly bring more poetry in the image than
^self primitiveFailed.

Nicolas

> On Tue, Mar 30, 2010 at 1:56 PM, Casey Ransberger <[hidden email]>
> wrote:
>>
>> Found it.
>> RealEstateAgent class>>standardWindowExtent
>> <snip>
>> ^ (allowedArea extent - (grid*(maxLevel+1*2) + (grid//2))) min:
>> StandardSize "600@400"].
>>
>> Something is going wrong with the math here. Changing this line to (note
>> that I've just commented everything out and returned 600@400) fixes the bug,
>> but probably breaks tons of other stuff:
>> ^"^ (allowedArea extent - (grid*(maxLevel+1*2) + (grid//2))) min:
>> StandardSize "600@400].
>> I'm going to see if I can figure out exactly what's going wrong with this,
>> and if so, push a proper fix to the Inbox.
>> On Tue, Mar 30, 2010 at 10:25 AM, Casey Ransberger
>> <[hidden email]> wrote:
>>>
>>> When I open a system browser in recent trunk images, the browser opens up
>>> squished vertically so the first thing I need to do is resize it. I could
>>> swear I'd seen this some place before, and the fix wound up being in
>>> toolbuilder somewhere. IIRC Andreas pointed out the fix, but I can't find
>>> the message anywhere in any of my inboxes.
>>> As a sanity check, are other people seeing this too? I might note that
>>> I've been using Squeak on a very small screen lately, if that makes any
>>> difference (I don't know, maybe the browser tries to open at a % of total
>>> screen real estate, which is too small on my box?)
>
>
>
>
>