[BUG] Dialog window does not keyboard focus together with its body

I think the screencast should be self-explaining:

Am 17.09.2020 09:46:34 schrieb Thiede, Christoph <[hidden email]>:

I think the screencast should be self-explaining:

The problem might be the check in TextMorph >> #mouseDown:, but I'm not yet sure.

Best,

Christoph

Hi Marcel,

clicking inside the text morph of the dialog window does not bring the dialog window to the front. I think this is quite confusing because the inspector window is still *displayed* at the front, but any click into it is processed by the text morph. Do you understand what I mean? :)

Best,

Christoph

Am 17.09.2020 13:02:17 schrieb Thiede, Christoph <[hidden email]>:

Hi Marcel,

clicking inside the text morph of the dialog window does not bring the dialog window to the front. I think this is quite confusing because the inspector window is still *displayed* at the front, but any click into it is processed by the text morph. Do you understand what I mean? :)

Best,

Christoph

---

Von: Squeak-dev <[hidden email]> im Auftrag von Taeumel, Marcel
Gesendet: Donnerstag, 17. September 2020 12:56:38
An: squeak-dev
Betreff: Re: [squeak-dev] [BUG] Dialog window does not keyboard focus together with its body

 

Hi Christoph,

can you rephrase that? What's the issue here?

Best,

Marcel

Am 17.09.2020 09:46:34 schrieb Thiede, Christoph <[hidden email]>:

I think the screencast should be self-explaining:

The problem might be the check in TextMorph >> #mouseDown:, but I'm not yet sure.

Best,

Christoph

Am 17.09.2020 13:09:34 schrieb Marcel Taeumel <[hidden email]>:

Hi Christoph,

aha! We should add #handleMouseDown: like the one in SystemWindow to bring that dialog to the front. No need to change the TextMorph. Then we can remove "self comeToFront" from DialogWindow >> #mouseDown:.

Best,

Marcel

Am 17.09.2020 13:02:17 schrieb Thiede, Christoph <[hidden email]>:

Hi Marcel,

clicking inside the text morph of the dialog window does not bring the dialog window to the front. I think this is quite confusing because the inspector window is still *displayed* at the front, but any click into it is processed by the text morph. Do you understand what I mean? :)

Best,

Christoph

---

Von: Squeak-dev <[hidden email]> im Auftrag von Taeumel, Marcel
Gesendet: Donnerstag, 17. September 2020 12:56:38
An: squeak-dev
Betreff: Re: [squeak-dev] [BUG] Dialog window does not keyboard focus together with its body

 

Hi Christoph,

can you rephrase that? What's the issue here?

Best,

Marcel

Am 17.09.2020 09:46:34 schrieb Thiede, Christoph <[hidden email]>:

I think the screencast should be self-explaining:

The problem might be the check in TextMorph >> #mouseDown:, but I'm not yet sure.

Best,

Christoph

Thank you for the fast fix! :-)

Best,

Christoph