[BUG][FIX]Omnibrowser button bar

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[BUG][FIX]Omnibrowser button bar

Karl-19
Here is a little fix for Omnibrowser that prevent huge screen redraw
when swiching from pane to pane in the browser. There is a subtle bug in
Morph>>addMorph: that sometimes causes the added morph to be added at
World top left corner. The easy fix is to give a position to the morph
to avoid screen damage.

This fix will be a candidate for the 3.10 image.

Karl

'From Squeak3.10alpha of 30 March 2007 [latest update: #7119] on 7 September 2007 at 10:19:53 pm'!

!OBButtonBar methodsFor: 'updating' stamp: 'kfr 9/7/2007 22:19'!
addButtonFor: aCommand
        self addMorphBack: ((self buttonFor: aCommand)position: self position)! !


Reply | Threaded
Open this post in threaded view
|

Re: [BUG][FIX]Omnibrowser button bar

Damien Cassou-3
Hi Karl,

2007/9/7, Karl <[hidden email]>:
> Here is a little fix for Omnibrowser that prevent huge screen redraw
> when swiching from pane to pane in the browser. There is a subtle bug in
> Morph>>addMorph: that sometimes causes the added morph to be added at
> World top left corner. The easy fix is to give a position to the morph
> to avoid screen damage.


thank you very much. I've commit the fix to the OB repository.


> This fix will be a candidate for the 3.10 image.

No, because OB is not part of Squeak anymore. But it will be included
in future squeak-dev releases.

Thank you

--
Damien Cassou

Reply | Threaded
Open this post in threaded view
|

Re: [BUG][FIX]Omnibrowser button bar

Karl-19
Damien Cassou wrote:

> Hi Karl,
>
> 2007/9/7, Karl <[hidden email]>:
>  
>> Here is a little fix for Omnibrowser that prevent huge screen redraw
>> when swiching from pane to pane in the browser. There is a subtle bug in
>> Morph>>addMorph: that sometimes causes the added morph to be added at
>> World top left corner. The easy fix is to give a position to the morph
>> to avoid screen damage.
>>    
>
>
> thank you very much. I've commit the fix to the OB repository.
>  
Great.
>
>  
>> This fix will be a candidate for the 3.10 image.
>>    
>
> No, because OB is not part of Squeak anymore. But it will be included
> in future squeak-dev releases.
>  
Aha, I did not know that.

> Thank you
>
>  
Thank you
Karl