[BUG] List filters are not reset

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[BUG] List filters are not reset

Bert Freudenberg
List filters are not reset anymore when clicking outside. The "Filterable Lists Clear Automatically" preference is enabled but apparently not honored.

To reproduce: Open a new Test Runner, mouse over the class category list, type "rel" (to filter for release stuff), click elsewhere.

Expected result: List returns from filtered pink state to white unfiltered state.

Actual result: Nothing happens. There appears to be no way to get back the unfiltered view.

- Bert -




smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [BUG] List filters are not reset

marcel.taeumel (old)
That bug seems to be related with the #mouseOverForKeyboardFocus preference. If that is off, I can reproduce it.

Best,
Marcel
Reply | Threaded
Open this post in threaded view
|

Re: [BUG] List filters are not reset

Tobias Pape
In reply to this post by Bert Freudenberg

On 09.04.2015, at 11:54, Bert Freudenberg <[hidden email]> wrote:

> List filters are not reset anymore when clicking outside. The "Filterable Lists Clear Automatically" preference is enabled but apparently not honored.
>
> To reproduce: Open a new Test Runner, mouse over the class category list, type "rel" (to filter for release stuff), click elsewhere.
>
> Expected result: List returns from filtered pink state to white unfiltered state.
>
> Actual result: Nothing happens. There appears to be no way to get back the unfiltered view.

no fix, but what happens if you type ESC or backspace?


> - Bert -





signature.asc (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [BUG] List filters are not reset

marcel.taeumel (old)
In reply to this post by marcel.taeumel (old)
Oh, my... I just learned something new. :)

If morphs fail to grab the keyboard (i.e. "ActiveHand newKeyboardFocus: self"), the hand will start event processing at its owner, which is the ActiveWorld. When it does so, there will be no #keyboardFocusChange: notification sent to affected lists, which will thus not reset their filters.

Some morphs that miss to grab the keyboard are:

- PluggableListMorphOfMany (used in TestRunner)
- PluggableTreeMorph (used in ObjectExplorer)

When event processing starts at the world, things still seem to work because the foremost/topmost morph of the world will receive that event. Having this, the keyboard events because the hand is over that list, etc...

We should both that keyboard grabbing this because this will also speed up event processing in those cases.

Best,
Marcel
Reply | Threaded
Open this post in threaded view
|

Re: [BUG] List filters are not reset

marcel.taeumel (old)
In reply to this post by Bert Freudenberg
Reply | Threaded
Open this post in threaded view
|

Re: [BUG] List filters are not reset

Bert Freudenberg
On 09.04.2015, at 13:47, Marcel Taeumel <[hidden email]> wrote:
>
> Should be fixed:
> http://forum.world.st/The-Trunk-Morphic-mt-849-mcz-td4818555.html

Thank you! It's better, but not quite correct yet. If you just mouse over the test runner's category list and type without ever clicking inside the list, then clicking somewhere else will not clear the filter.

Maybe we need to set the focus also when we're receiving the first filtering keystroke?

- Bert -






smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [BUG] List filters are not reset

Bert Freudenberg
On 09.04.2015, at 15:43, Bert Freudenberg <[hidden email]> wrote:

>
> On 09.04.2015, at 13:47, Marcel Taeumel <[hidden email]> wrote:
>>
>> Should be fixed:
>> http://forum.world.st/The-Trunk-Morphic-mt-849-mcz-td4818555.html
>
> Thank you! It's better, but not quite correct yet. If you just mouse over the test runner's category list and type without ever clicking inside the list, then clicking somewhere else will not clear the filter.
>
> Maybe we need to set the focus also when we're receiving the first filtering keystroke?
>
> - Bert -
Also, I just ran into this beauty:




- Bert -






PastedGraphic-3.png (72K) Download Attachment
SqueakDebug.log (19K) Download Attachment
smime.p7s (5K) Download Attachment