Smalltalk › Squeak › Squeak - Dev

[BUG] Number does not read '1.0e-10 .txt' from file

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

5 messages Options

Klaus D. Witzel

[BUG] Number does not read '1.0e-10 .txt' from file

Entered
- http://bugs.impara.de/view.php?id=3993

The following statement works:

Number readFrom: '1.0e-10 .txt' readStream

But when reading the same string from a file

Number readFrom: (FileStream readOnlyFileNamed: 'Number1.0e-10 .txt')

it fails with the attached DNU. Note that in order to reproduce, the
string '1.0e-10 .txt' must be put into the file named 'Number1.0e-10 .txt'.

/Klaus

P.S. I stumbled over this when using Scanner for scanning all the tokens
in the .changes file.

Nicolas Cellier-3

Re: [BUG] Number does not read '1.0e-10 .txt' from file

Klaus,

you will find an explanation and link to possible workaround into note attached at http://bugs.impara.de/view.php?id=3993

Nicolas

Klaus D. Witzel:

> Entered
> - http://bugs.impara.de/view.php?id=3993
>
> The following statement works:
>
> Number readFrom: '1.0e-10 .txt' readStream
>
> But when reading the same string from a file
>
> Number readFrom: (FileStream readOnlyFileNamed: 'Number1.0e-10 .txt')
>
> it fails with the attached DNU. Note that in order to reproduce, the
> string '1.0e-10 .txt' must be put into the file named 'Number1.0e-10 .txt'.
>
> /Klaus
>
> P.S. I stumbled over this when using Scanner for scanning all the tokens
> in the .changes file.
>

________________________________________________________________________
iFRANCE, exprimez-vous !
http://web.ifrance.com

Klaus D. Witzel

[Fix][BUG] Number does not read '1.0e-10 .txt' from file

Hi Nicolas,

on Mon, 03 Jul 2006 18:01:32 +0200, you wrote:

> Klaus,
>
> you will find an explanation and link to possible workaround into note
> attached at http://bugs.impara.de/view.php?id=3993

Thank you Nicolas for pointing me to the symptom. Sames happens in Number
class>>canParseAsScaledDecimal:... :(

Attached a fix for both methods, now Scanner scans all the tokens from the
.changes file. It should be able to do so because at the time the .changes
where recorded they where syntactically correct.

BTW: didn't look at how to integrate into Scanner the possible workaround
you mentioned, I think that Scanner just asks Number readFrom: aStream.

Klaus

> Nicolas
>
>
> Klaus D. Witzel:
>> Entered
>> - http://bugs.impara.de/view.php?id=3993
>>
>> The following statement works:
>>
>> Number readFrom: '1.0e-10 .txt' readStream
>>
>> But when reading the same string from a file
>>
>> Number readFrom: (FileStream readOnlyFileNamed: 'Number1.0e-10 .txt')
>>
>> it fails with the attached DNU. Note that in order to reproduce, the
>> string '1.0e-10 .txt' must be put into the file named 'Number1.0e-10
>> .txt'.
>>
>> /Klaus
>>
>> P.S. I stumbled over this when using Scanner for scanning all the tokens
>> in the .changes file.
>>
>
>
> ________________________________________________________________________
> iFRANCE, exprimez-vous !
> http://web.ifrance.com

Number-class-canParse-fix-kwl.1.cs (1K) Download Attachment

Nicolas Cellier-3

Re: [Fix][BUG] Number does not read '1.0e-10 .txt' from file

Le Lundi 03 Juillet 2006 19:30, Klaus D. Witzel a écrit :
> Hi Nicolas,
>
> etc...
>
> BTW: didn't look at how to integrate into Scanner the possible workaround
> you mentioned, I think that Scanner just asks Number readFrom: aStream.
>
> Klaus

That's exactly that. Scanner uses Number readFrom:
You just have to redirect Number class>>readFrom: to a call to NumberParser
alternative.

Nicolas

David T. Lewis

Re: [Fix][BUG] Number does not read '1.0e-10 .txt' from file

On Mon, Jul 03, 2006 at 11:00:54PM +0200, nicolas cellier wrote:

> Le Lundi 03 Juillet 2006 19:30, Klaus D. Witzel a ?crit :
> >
> > BTW: didn't look at how to integrate into Scanner the possible workaround ?
> > you mentioned, I think that Scanner just asks Number readFrom: aStream.
> >
> > Klaus
>
> That's exactly that. Scanner uses Number readFrom:
> You just have to redirect Number class>>readFrom: to a call to NumberParser
> alternative.

I put a cleanup and fix for the the original problem in Mantis 3993 (I was
the cause of the original bug). But I think that NumberParser (Mantis 3512)
is a better solution. It is better organized, it solves several other
number parsing problems, and it is faster than the current parser even
after my cleanup.

Dave