Smalltalk › Squeak › Squeak - Dev

[BUG] ObjectExplorer menu

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

13 messages Options

Karl Ramberg

[BUG] ObjectExplorer menu

ObjectExplorer will fail to open a yellow button menu if you explore values that change while you are exploring them.

The method updateInspectorSelection uses assert: to check if objects are the same as in a inspector, which they are not because they have changed in the background.

I think this should be fixed before we release.

ObjectExplorer>>updateInspectorForSelection

"Reuse the inspector for some callbacks."

self inspector inspect: (self parentObject ifNil: [self object]).

self parentObject

ifNil: [self inspector toggleIndex: 1. "self"]

ifNotNil: [

self inspector toggleIndex: (self inspector fieldList indexOf: self currentSelection key)].

self assert: self inspector selection == self object.

Karl

marcel.taeumel

Re: [BUG] ObjectExplorer menu

This can be fixed by *not* reusing code of the Inspector class hierarchy. Should we copy? :)

Best,
Marcel

Karl Ramberg

Re: [BUG] ObjectExplorer menu

We must use another mechanism in explorer than in inspector.

Items in the inspector list does not change or are updated continuously.

The explorer list is (usually) frozen while items change in the background.

Updating the list in explorer is quite slow so we don't want to do that continuously.

Karl

On Tue, May 19, 2015 at 10:53 AM, marcel.taeumel <[hidden email]> wrote:

This can be fixed by *not* reusing code of the Inspector class hierarchy.
Should we copy? :)

Best,
Marcel

--
View this message in context: http://forum.world.st/BUG-ObjectExplorer-menu-tp4827121p4827264.html
Sent from the Squeak - Dev mailing list archive at Nabble.com.

marcel.taeumel

Re: [BUG] ObjectExplorer menu

That's not what I meant. You can already enable update for explorer items by monitoring them (use context menu).

I extracting/copying code from the inspector for generating the context menu as well as keyboard shortcut callbacks.

Best,
Marcel

Karl Ramberg

Re: [BUG] ObjectExplorer menu

That what I meant, too ;-)

Just commenting out the assert: line in the method >>updateInspectorForSelection makes the menu pop up, and everything seems to work.

I'm not sure if that breaks something, though...

Karl

On Tue, May 19, 2015 at 4:09 PM, marcel.taeumel <[hidden email]> wrote:

That's not what I meant. You can already enable update for explorer items by
monitoring them (use context menu).

I extracting/copying code from the inspector for generating the context menu
as well as keyboard shortcut callbacks.

Best,
Marcel

--
View this message in context: http://forum.world.st/BUG-ObjectExplorer-menu-tp4827121p4827381.html

Sent from the Squeak - Dev mailing list archive at Nabble.com.

marcel.taeumel

Re: [BUG] ObjectExplorer menu

Yes, it breaks. Try exploring the ActiveHand and then invoke the menu on keyboardFocus. :)

Best,
Marcel

Karl Ramberg

Re: [BUG] ObjectExplorer menu

I get the menu in explorer for ActiveHand keyboardFocus

Karl

On Tue, May 19, 2015 at 4:49 PM, marcel.taeumel <[hidden email]> wrote:

Yes, it breaks. Try exploring the ActiveHand and then invoke the menu on
keyboardFocus. :)

Best,
Marcel

--
View this message in context: http://forum.world.st/BUG-ObjectExplorer-menu-tp4827121p4827405.html

Sent from the Squeak - Dev mailing list archive at Nabble.com.

marcel.taeumel

Re: [BUG] ObjectExplorer menu

If you remove the assert, you will get a context menu for the wrong object. :)

Best,
Marcel

Karl Ramberg

Re: [BUG] ObjectExplorer menu

But at lest there will be a menu.

And all it points to the item I clicked on.

I found another bug in the explorer list.

See attached screenshot.

If I click a line and move the mouse while holding down, and then release mouse button outside the line, the line gets a black outline.

There seem to be missing some mouseLeaveDragging: stuff ?

And one more thing:

When I explore the clock in the docking bar and select monitoring the 'contents' the selection color of the line stops before the printed clock string and is very hard to read. Somehow the text is displaying yellow on white...

Karl

On Thu, May 21, 2015 at 7:45 PM, marcel.taeumel <[hidden email]> wrote:

If you remove the assert, you will get a context menu for the wrong object.
:)

Best,
Marcel

--
View this message in context: http://forum.world.st/BUG-ObjectExplorer-menu-tp4827121p4827933.html

Sent from the Squeak - Dev mailing list archive at Nabble.com.

Sketch.jpeg (11K) Download Attachment

Karl Ramberg

Re: [BUG] ObjectExplorer menu

Here is a fix for the black border highlight on mouse move.

Karl

On Thu, May 21, 2015 at 9:32 PM, karl ramberg <[hidden email]> wrote:

But at lest there will be a menu.
And all it points to the item I clicked on.

I found another bug in the explorer list.
See attached screenshot.
If I click a line and move the mouse while holding down, and then release mouse button outside the line, the line gets a black outline.

There seem to be missing some mouseLeaveDragging: stuff ?

And one more thing:
When I explore the clock in the docking bar and select monitoring the 'contents' the selection color of the line stops before the printed clock string and is very hard to read. Somehow the text is displaying yellow on white...

Karl

On Thu, May 21, 2015 at 7:45 PM, marcel.taeumel <[hidden email]> wrote:
If you remove the assert, you will get a context menu for the wrong object.
:)

Best,
Marcel

--
View this message in context: http://forum.world.st/BUG-ObjectExplorer-menu-tp4827121p4827933.html

Sent from the Squeak - Dev mailing list archive at Nabble.com.

SimpleHierarchicalListMorph-mouseMove.st (996 bytes) Download Attachment

marcel.taeumel

Re: [BUG] ObjectExplorer menu

Thank you. I will take a look at it.

Best,
Marcel

marcel.taeumel

Re: [BUG] ObjectExplorer menu

Fixed: http://forum.world.st/The-Trunk-Morphic-mt-985-mcz-td4828886.html

Note that you cannot monitor #contents in the ClockMorph because the object itself (the string morph) is replaced each second. That's why the #assert statement is very important. ;-) You may have just observed a bug I want to avoid by using this assert statement. :-)

We have to find a better way to create that context menu. Maybe just copy the code from the Inspector.

Best,
Marcel

Karl Ramberg

Re: [BUG] ObjectExplorer menu

The fix seem right.

The other bug with monitoring and highlight seem to be related to how ObjectExplorerWrapper asString responds.

Usually it responds like this: 'bounds 10@380 corner: 82@452'

When the model is a string its like this: 'contents ''2:36:30 pm'''

The superfluous apostrophes mess up the display I think.

Also see attached screenshot

Karl

On Wed, May 27, 2015 at 2:00 PM, marcel.taeumel <[hidden email]> wrote:

Fixed: http://forum.world.st/The-Trunk-Morphic-mt-985-mcz-td4828886.html

Note that you cannot monitor #contents in the ClockMorph because the object
itself (the string morph) is replaced each second. That's why the #assert
statement is very important. ;-) You may have just observed a bug I want to
avoid by using this assert statement. :-)

We have to find a better way to create that context menu. Maybe just copy
the code from the Inspector.

Best,
Marcel

--
View this message in context: http://forum.world.st/BUG-ObjectExplorer-menu-tp4827121p4828887.html

Sent from the Squeak - Dev mailing list archive at Nabble.com.

bug.png (3K) Download Attachment