Smalltalk › Squeak › Squeak - Dev

[Bug] Cannot use non-english characters even after loading a proper font

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

14 messages Options

Mateusz Grotek

[Bug] Cannot use non-english characters even after loading a proper font

Hi,
First of all thank you for the new version of Squeak. It's really great.

Special thanks for Tobias and Marcel for the font import tool! It works
perfectly.

Nevertheless I have noticed that there is a regression in Squeak
4.6/5.0 in the font handling. It's not possible anymore to use
non-english characters even after loading a font that contains them
(I've changed the code font and tried to use the characters in a
workspace). Can anyone verify?

Mateusz

Tobias Pape

Re: [Bug] Cannot use non-english characters even after loading a proper font

Hi Mateusz

On 16.08.2015, at 00:56, Mateusz Grotek <[hidden email]> wrote:

> Hi,
> First of all thank you for the new version of Squeak. It's really great.
>
> Special thanks for Tobias and Marcel for the font import tool! It works perfectly.
>
> Nevertheless I have noticed that there is a regression in Squeak 4.6/5.0 in the font handling. It's not possible anymore to use non-english characters even after loading a font that contains them (I've changed the code font and tried to use the characters in a workspace). Can anyone verify?

It is somewhat strange,
I imported Arial Unicode (the whole stuff) and, yes some characters did not show up,
but others (such as ß) did. I don't know yet _where_ the problem is. Although
I've written the importer, I still lack some knowledge to debug this behavior.

Best regards
-Tobias

Levente Uzonyi-2

Re: [Bug] Cannot use non-english characters even after loading a proper font

I see the following issues here (latest Trunk image):

1. Glyphs for non-ascii (asciiValue >= 256) characters are shown as a
black rectangle.

2. FontImporterTool doesn't see fonts in the subdirectories of the base
font directory. Because of this, there's only one font on the list for
me.

3. FontImporterTool doesn't use the selected font in the preview
panel.

Levente

On Wed, 19 Aug 2015, Tobias Pape wrote:

> Hi Mateusz
>
> On 16.08.2015, at 00:56, Mateusz Grotek <[hidden email]> wrote:
>
>> Hi,
>> First of all thank you for the new version of Squeak. It's really great.
>>
>> Special thanks for Tobias and Marcel for the font import tool! It works perfectly.
>>
>> Nevertheless I have noticed that there is a regression in Squeak 4.6/5.0 in the font handling. It's not possible anymore to use non-english characters even after loading a font that contains them (I've changed the code font and tried to use the characters in a workspace). Can anyone verify?
>
> It is somewhat strange,
> I imported Arial Unicode (the whole stuff) and, yes some characters did not show up,
> but others (such as ß) did. I don't know yet _where_ the problem is. Although
> I've written the importer, I still lack some knowledge to debug this behavior.
>
> Best regards
> -Tobias
>

Tobias Pape

Re: [Bug] Cannot use non-english characters even after loading a proper font

Hey

On 19.08.2015, at 17:34, Levente Uzonyi <[hidden email]> wrote:

> I see the following issues here (latest Trunk image):
>
> 1. Glyphs for non-ascii (asciiValue >= 256) characters are shown as a black rectangle.

I see. and I don't know why :(

>
> 2. FontImporterTool doesn't see fonts in the subdirectories of the base font directory. Because of this, there's only one font on the list for me.

No, that's not the reason for only one font.
The importer tries to group families of typefaces into one font
and displays them as a group.

>
> 3. FontImporterTool doesn't use the selected font in the preview panel.

It surely does; but if you have a group selected, it will only display
one of its faces.

Best
-Tobias

Can you give a screenshot?

>
> Levente
>
> On Wed, 19 Aug 2015, Tobias Pape wrote:
>
>> Hi Mateusz
>>
>> On 16.08.2015, at 00:56, Mateusz Grotek <[hidden email]> wrote:
>>
>>> Hi,
>>> First of all thank you for the new version of Squeak. It's really great.
>>>
>>> Special thanks for Tobias and Marcel for the font import tool! It works perfectly.
>>>
>>> Nevertheless I have noticed that there is a regression in Squeak 4.6/5.0 in the font handling. It's not possible anymore to use non-english characters even after loading a font that contains them (I've changed the code font and tried to use the characters in a workspace). Can anyone verify?
>>
>> It is somewhat strange,
>> I imported Arial Unicode (the whole stuff) and, yes some characters did not show up,
>> but others (such as ß) did. I don't know yet _where_ the problem is. Although
>> I've written the importer, I still lack some knowledge to debug this behavior.
>>
>> Best regards
>> -Tobias

Mateusz Grotek

Re: [Bug] Cannot use non-english characters even after loading a proper font

Screenshot 1

codepage.png (22K) Download Attachment

Mateusz Grotek

Re: [Bug] Cannot use non-english characters even after loading a proper font

In reply to this post by Tobias Pape

Screenshot 2

fontimporter.png (72K) Download Attachment

Karl Ramberg

Re: [Bug] Cannot use non-english characters even after loading a proper font

In reply to this post by Levente Uzonyi-2

On Wed, Aug 19, 2015 at 5:34 PM, Levente Uzonyi <[hidden email]> wrote:

I see the following issues here (latest Trunk image):

1. Glyphs for non-ascii (asciiValue >= 256) characters are shown as a black rectangle.

2. FontImporterTool doesn't see fonts in the subdirectories of the base font directory. Because of this, there's only one font on the list for me.

3. FontImporterTool doesn't use the selected font in the preview panel.

This fixes the preview of the font:

FontImporterTool>>currentSelection: anObject

anObject = currentSelection ifTrue: [^ self].

currentSelection := anObject.

self changed: #currentSelection.

self changed: #contents.

self changed: #filename.

self changed: #copyright.

self changed: #previewText.

Karl

Levente

On Wed, 19 Aug 2015, Tobias Pape wrote:

Hi Mateusz

On 16.08.2015, at 00:56, Mateusz Grotek <[hidden email]> wrote:

Hi,
First of all thank you for the new version of Squeak. It's really great.

Special thanks for Tobias and Marcel for the font import tool! It works perfectly.

Nevertheless I have noticed that there is a regression in Squeak 4.6/5.0 in the font handling. It's not possible anymore to use non-english characters even after loading a font that contains them (I've changed the code font and tried to use the characters in a workspace). Can anyone verify?

It is somewhat strange,
I imported Arial Unicode (the whole stuff) and, yes some characters did not show up,
but others (such as ß) did. I don't know yet _where_ the problem is. Although
I've written the importer, I still lack some knowledge to debug this behavior.

Best regards
-Tobias

Tobias Pape

Re: [Bug] Cannot use non-english characters even after loading a proper font

Hi,

On 21.08.2015, at 12:16, karl ramberg <[hidden email]> wrote:

>
>
> On Wed, Aug 19, 2015 at 5:34 PM, Levente Uzonyi <[hidden email]> wrote:
> I see the following issues here (latest Trunk image):
>
> 1. Glyphs for non-ascii (asciiValue >= 256) characters are shown as a black rectangle.
>
> 2. FontImporterTool doesn't see fonts in the subdirectories of the base font directory. Because of this, there's only one font on the list for me.
>
> 3. FontImporterTool doesn't use the selected font in the preview panel.
>
> This fixes the preview of the font:
>
> FontImporterTool>>currentSelection: anObject
> anObject = currentSelection ifTrue: [^ self].
> currentSelection := anObject.
> self changed: #currentSelection.
> self changed: #contents.
> self changed: #filename.
> self changed: #copyright.
> self changed: #previewText.
>

Ah I see. In Morphic-mt.951 FontImporterTool became a Subclass of Model and not StringHolder.
I'll change accortingly (in trunk)

Best regards
-Tobias

> Karl
>
>
> Levente
>
>
> On Wed, 19 Aug 2015, Tobias Pape wrote:
>
> Hi Mateusz
>
> On 16.08.2015, at 00:56, Mateusz Grotek <[hidden email]> wrote:
>
> Hi,
> First of all thank you for the new version of Squeak. It's really great.
>
> Special thanks for Tobias and Marcel for the font import tool! It works perfectly.
>
> Nevertheless I have noticed that there is a regression in Squeak 4.6/5.0 in the font handling. It's not possible anymore to use non-english characters even after loading a font that contains them (I've changed the code font and tried to use the characters in a workspace). Can anyone verify?
>
> It is somewhat strange,
> I imported Arial Unicode (the whole stuff) and, yes some characters did not show up,
> but others (such as ß) did. I don't know yet _where_ the problem is. Although
> I've written the importer, I still lack some knowledge to debug this behavior.
>
> Best regards
> -Tobias

Tobias Pape

Re: [Bug] Cannot use non-english characters even after loading a proper font

In reply to this post by Mateusz Grotek

Well, I don't know yet what to do about that.

I probably have to dig deeper. For example, when I import
Arial Unicode, I end up with only 191 glyphs, which is way to few.
I'll look at that in the future.

Thanks for noticing.

Best regards
-Tobias

On 21.08.2015, at 02:51, Mateusz Grotek <[hidden email]> wrote:

> Screenshot 1

Karl Ramberg

Re: [Bug] Cannot use non-english characters even after loading a proper font

In reply to this post by Tobias Pape

On Fri, Aug 21, 2015 at 2:11 PM, Tobias Pape <[hidden email]> wrote:

Hi,

On 21.08.2015, at 12:16, karl ramberg <[hidden email]> wrote:

>
>
> On Wed, Aug 19, 2015 at 5:34 PM, Levente Uzonyi <[hidden email]> wrote:
> I see the following issues here (latest Trunk image):
>
> 1. Glyphs for non-ascii (asciiValue >= 256) characters are shown as a black rectangle.
>
> 2. FontImporterTool doesn't see fonts in the subdirectories of the base font directory. Because of this, there's only one font on the list for me.
>
> 3. FontImporterTool doesn't use the selected font in the preview panel.
>
> This fixes the preview of the font:
>
> FontImporterTool>>currentSelection: anObject
> anObject = currentSelection ifTrue: [^ self].
> currentSelection := anObject.
> self changed: #currentSelection.
> self changed: #contents.
> self changed: #filename.
> self changed: #copyright.
> self changed: #previewText.
>

Ah I see. In Morphic-mt.951 FontImporterTool became a Subclass of Model and not StringHolder.
I'll change accortingly (in trunk)

Best regards
-Tobias

Oh, that explains it. I did not notice that the contents send did nothing.

What does contents do for model ?

Karl

> Karl
>
>
> Levente
>
>
> On Wed, 19 Aug 2015, Tobias Pape wrote:
>
> Hi Mateusz
>
> On 16.08.2015, at 00:56, Mateusz Grotek <[hidden email]> wrote:
>
> Hi,
> First of all thank you for the new version of Squeak. It's really great.
>
> Special thanks for Tobias and Marcel for the font import tool! It works perfectly.
>
> Nevertheless I have noticed that there is a regression in Squeak 4.6/5.0 in the font handling. It's not possible anymore to use non-english characters even after loading a font that contains them (I've changed the code font and tried to use the characters in a workspace). Can anyone verify?
>
> It is somewhat strange,
> I imported Arial Unicode (the whole stuff) and, yes some characters did not show up,
> but others (such as ß) did. I don't know yet _where_ the problem is. Although
> I've written the importer, I still lack some knowledge to debug this behavior.
>
> Best regards
> -Tobias

Tobias Pape

Re: [Bug] Cannot use non-english characters even after loading a proper font

On 21.08.2015, at 14:42, karl ramberg <[hidden email]> wrote:

>
>
> On Fri, Aug 21, 2015 at 2:11 PM, Tobias Pape <[hidden email]> wrote:
> Hi,
>
> On 21.08.2015, at 12:16, karl ramberg <[hidden email]> wrote:
>
> >
> >
> > On Wed, Aug 19, 2015 at 5:34 PM, Levente Uzonyi <[hidden email]> wrote:
> > I see the following issues here (latest Trunk image):
> >
> > 1. Glyphs for non-ascii (asciiValue >= 256) characters are shown as a black rectangle.
> >
> > 2. FontImporterTool doesn't see fonts in the subdirectories of the base font directory. Because of this, there's only one font on the list for me.
> >
> > 3. FontImporterTool doesn't use the selected font in the preview panel.
> >
> > This fixes the preview of the font:
> >
> > FontImporterTool>>currentSelection: anObject
> > anObject = currentSelection ifTrue: [^ self].
> > currentSelection := anObject.
> > self changed: #currentSelection.
> > self changed: #contents.
> > self changed: #filename.
> > self changed: #copyright.
> > self changed: #previewText.
> >
>
> Ah I see. In Morphic-mt.951 FontImporterTool became a Subclass of Model and not StringHolder.
> I'll change accortingly (in trunk)
>
> Best regards
> -Tobias
> Oh, that explains it. I did not notice that the contents send did nothing.
> What does contents do for model ?

Nothing. But it did things for StringHolder.
The #contents area of the StringHolder was where now the #previewText is.
:)

Best regards
-Tobias

>
> Karl
>
>
> > Karl
> >
> >
> > Levente
> >
> >
> > On Wed, 19 Aug 2015, Tobias Pape wrote:
> >
> > Hi Mateusz
> >
> > On 16.08.2015, at 00:56, Mateusz Grotek <[hidden email]> wrote:
> >
> > Hi,
> > First of all thank you for the new version of Squeak. It's really great.
> >
> > Special thanks for Tobias and Marcel for the font import tool! It works perfectly.
> >
> > Nevertheless I have noticed that there is a regression in Squeak 4.6/5.0 in the font handling. It's not possible anymore to use non-english characters even after loading a font that contains them (I've changed the code font and tried to use the characters in a workspace). Can anyone verify?
> >
> > It is somewhat strange,
> > I imported Arial Unicode (the whole stuff) and, yes some characters did not show up,
> > but others (such as ß) did. I don't know yet _where_ the problem is. Although
> > I've written the importer, I still lack some knowledge to debug this behavior.
> >
> > Best regards
> > -Tobias

Вася Чайко

Re: [Bug] Cannot use non-english characters even after loading a proper font

In reply to this post by Mateusz Grotek

16.08.2015 4:56, Mateusz Grotek пишет:

> Hi,
> First of all thank you for the new version of Squeak. It's really great.
>
> Special thanks for Tobias and Marcel for the font import tool! It
> works perfectly.
>
> Nevertheless I have noticed that there is a regression in Squeak
> 4.6/5.0 in the font handling. It's not possible anymore to use
> non-english characters even after loading a font that contains them
> (I've changed the code font and tried to use the characters in a
> workspace).

Unnamed1.1.cs
> Can anyone verify?
>
> Mateusz
>

Unnamed1.1.cs (4K) Download Attachment

Karl Ramberg

Re: [Bug] Cannot use non-english characters even after loading a proper font

Seems to work, at least your name comes out ok with imported Arial font.

The out commented code is confusing in TTFontReader>>decodeCmapFmtTable:

Karl

On Fri, Aug 28, 2015 at 9:50 PM, Вася Чайко <[hidden email]> wrote:

16.08.2015 4:56, Mateusz Grotek пишет:

Hi,
First of all thank you for the new version of Squeak. It's really great.

Special thanks for Tobias and Marcel for the font import tool! It works perfectly.

Nevertheless I have noticed that there is a regression in Squeak 4.6/5.0 in the font handling. It's not possible anymore to use non-english characters even after loading a font that contains them (I've changed the code font and tried to use the characters in a workspace).

Unnamed1.1.cs

Can anyone verify?

Mateusz

Tobias Pape

Re: [Bug] Cannot use non-english characters even after loading a proper font

In reply to this post by Вася Чайко

Hi Вася,

On 28.08.2015, at 21:50, Вася Чайко <[hidden email]> wrote:

> 16.08.2015 4:56, Mateusz Grotek пишет:
>> Hi,
>> First of all thank you for the new version of Squeak. It's really great.
>>
>> Special thanks for Tobias and Marcel for the font import tool! It works perfectly.
>>
>> Nevertheless I have noticed that there is a regression in Squeak 4.6/5.0 in the font handling. It's not possible anymore to use non-english characters even after loading a font that contains them (I've changed the code font and tried to use the characters in a workspace).
> Unnamed1.1.cs
>> Can anyone verify?
>>
>> Mateusz

I included your changeset into trunk.
Thank you!

Best regards
-Tobias