Bulletproof BitBltSimulation against failure in #lockSurfaces

 
Hi David,

Can you please add the following patch to the VMMaker source code?  It's a one-line fix to VMMaker-dtl.156 from SourceForge.  It fixes a bug where #warpBits doesn't check the return value of #lockSurfaces, and can potentially crash when execution continues after the failed lock attempt.

Thanks,
Josh

 
On Thu, Jan 28, 2010 at 12:21:14AM -0800, Josh Gargus wrote:
> Hi David,
>
> Can you please add the following patch to the VMMaker source code?  It's
> a one-line fix to VMMaker-dtl.156 from SourceForge.  It fixes a bug
> where #warpBits doesn't check the return value of #lockSurfaces, and
> can potentially crash when execution continues after the failed lock attempt.

Thanks Josh, will do. It might be a couple of days until I can get to it though.

Dave

On Jan 28, 2010, at 5:17 AM, David T. Lewis wrote:

> On Thu, Jan 28, 2010 at 12:21:14AM -0800, Josh Gargus wrote:
>> Hi David,
>>
>> Can you please add the following patch to the VMMaker source code?  It's
>> a one-line fix to VMMaker-dtl.156 from SourceForge.  It fixes a bug
>> where #warpBits doesn't check the return value of #lockSurfaces, and
>> can potentially crash when execution continues after the failed lock attempt.
>
> Thanks Josh, will do. It might be a couple of days until I can get to it though.

No problem.  Thanks!

Josh




>
> Dave
>

 
On Thu, Jan 28, 2010 at 12:21:14AM -0800, Josh Gargus wrote:
>
> Can you please add the following patch to the VMMaker source code?
> It's a one-line fix to VMMaker-dtl.156 from SourceForge.  It fixes
> a bug where #warpBits doesn't check the return value of #lockSurfaces,
> and can potentially crash when execution continues after the failed
> lock attempt.

Josh,

Your patch is added as VMMaker-dtl.157 on SqueakSource, with Mantis
issue #7461 added for bookkeeping.

Thanks,
Dave