Can folks please review carefully the replacement MiscPrimitivePlugin?

 

 

 

 
Hi Eliot,

Attached is IncludedMethodsTest from (old trunk) VMMaker. This is something
I wrote to document the included methods in MiscPrimitivePlugin, so you can
run the tests in e.g. trunk Squeak as a check for presence of the primitives.

Note that some of the primitives are not yet covered by the test, see
#todoForADPCMCodecPlugin.

You may want to consider giving the reimplemented plugin a different class
name, but retain the module name. That would make it easier to keep a copy
of the old plugin (compiled external) that a user can swap in to the runtime
if any problems come up.

It might also be worth considering putting the string, sound, and codec
primitives into separate modules with appropriate names. That would be
harder to manage from the point of view updating primitive references in
the image, but the old MiscPrimitivePlugin is a rather haphazard collection
of functions and this might be a good time to clean that up too.

Dave



On Wed, Feb 21, 2018 at 06:18:53PM -0800, Eliot Miranda wrote: