Smalltalk › Squeak › Squeak - Dev

Change to WebMessage breaks configuration loading (smalltalkCI)

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

Max Leske

Change to WebMessage breaks configuration loading (smalltalkCI)

Hi,

The change by Tobias (03-07-2017) to WebMessage>>getContentWithProgress: breaks loading of configurations. They are gzip encoded but that is never being considered if a converter is set. The binary stream will then be decoded as string which fails.

Cheers,
Max

Tobias Pape

Re: Change to WebMessage breaks configuration loading (smalltalkCI)

Hi Max,

> On 06.07.2017, at 09:08, Max Leske <[hidden email]> wrote:
>
> Hi,
>
> The change by Tobias (03-07-2017) to WebMessage>>getContentWithProgress: breaks loading of configurations. They are gzip encoded but that is never being considered if a converter is set. The binary stream will then be decoded as string which fails.

Arhg, and ordering problem :(
Thanks for noticing.

Does WebClient-Core-topa.108 fix that?

Best regards
-Tobias

Max Leske

Re: Change to WebMessage breaks configuration loading (smalltalkCI)

In reply to this post by Max Leske

On 6 Jul 2017, at 14:00, [hidden email] wrote:

Hi Max,

On 06.07.2017, at 09:08, Max Leske <[hidden email]> wrote:

Hi,

The change by Tobias (03-07-2017) to WebMessage>>getContentWithProgress: breaks loading of configurations. They are gzip encoded but that is never being considered if a converter is set. The binary stream will then be decoded as string which fails.

Arhg, and ordering problem :(
Thanks for noticing.

Does WebClient-Core-topa.108 fix that?

Yes, that fixes it, thanks!

Best regards
-Tobias