Commanche

Hi,

I just noticed from my RSS feed that Squeaksource got a set of changes
to Commanche put in like a machine gun (every 20 seconds or so).  Is
that legit, or is this some kind of replay thing?  If it's legit,
what's going on? :)  Are the longstanding bugs people talk about
getting fixed?

2007/10/23, Jason Johnson <[hidden email]>:
> Hi,
>
> I just noticed from my RSS feed that Squeaksource got a set of changes
> to Commanche put in like a machine gun (every 20 seconds or so).  Is
> that legit, or is this some kind of replay thing?

the -gk versions are just imports of old versions.

Philippe

> If it's legit,
> what's going on? :)  Are the longstanding bugs people talk about
> getting fixed?
>
>

Il giorno mar, 23/10/2007 alle 18.55 +0200, Jason Johnson ha scritto:
> Hi,
>
> I just noticed from my RSS feed that Squeaksource got a set of changes
> to Commanche put in like a machine gun (every 20 seconds or so).  Is
> that legit, or is this some kind of replay thing?  If it's legit,
> what's going on? :)  Are the longstanding bugs people talk about
> getting fixed?

Hi Jason,

that was me using the 'Copy' feature of Monticello to move the packages
from Goran's repository to SqueakSource. Goran and I were talking in
#squeak earlier today, and we agreed to move the packages to the
SqueakSource repository. I was waiting for him to get back on #squeak to
discuss things further.

As for the bugs list, bugs.squeak.org only shows 5 open bugs. Are there
other bugs that are not on Mantis?

        Giovanni

2007/10/23, Giovanni Corriga <[hidden email]>:
The by far most annoying for Seaside is that you send
#unescapePercents. Also you couln't return 409, Kom would
automatically converti to 500. This should be fixed in
KomHttpServer-gc.15.

Cheers
Philippe

2007/10/23, Giovanni Corriga <[hidden email]>:
I also forgot the parsing of cookies without a value. See the
overrided in Seaside (!!!) for a fix.

Cheers
Philippe

Il giorno mar, 23/10/2007 alle 19.50 +0200, Philippe Marschall ha
scritto:

> The by far most annoying for Seaside is that you send
> #unescapePercents.

Is this related to http://bugs.squeak.org/view.php?id=4178 ?
In case, would you mind uploading a new .mcz with your patch in the Kom
repository?

> Also you couln't return 409, Kom would
> automatically converti to 500. This should be fixed in
> KomHttpServer-gc.15.

Yes, I added all the missing HTTP 1.1 status codes.

        Giovanni

Awesome!  So Philippe, you seem to be the expert on what has been
wrong with it, do you know of anything still outstanding that hasn't
been mentioned yet?

On 10/23/07, Giovanni Corriga <[hidden email]> wrote:

Hi All,

Shouldn't we be using http://www.squeaksource.com/KomWebServer.html or
should this be deleted?

Ron

2007/10/23, Giovanni Corriga <[hidden email]>:
> Il giorno mar, 23/10/2007 alle 19.50 +0200, Philippe Marschall ha
> scritto:
>
> > The by far most annoying for Seaside is that you send
> > #unescapePercents.
>
> Is this related to http://bugs.squeak.org/view.php?id=4178 ?
> In case, would you mind uploading a new .mcz with your patch in the Kom
> repository?

I added the version from the SeasideInstaller. I'm sorry the history
is a complete mess. The only things that are changed are:
HttpRequest class >> #decodeUrlEncodedForm:multipleValues: and
HttpRequest >> #initStatusString:. Instead of 'latin-1' as an ecoding
you can also take nil. To fix all underscores you can use the class
FixUnderscores. The fix for cookie parsing is:

HttpRequest >> #parseCookies: aString
        "PRIVATE: Parse a string in the format:
        Cookie: NAME1=OPAQUE_STRING1; NAME2=OPAQUE_STRING2 ..."

        | dict |
        dict := Dictionary new.
        (aString findTokens: ';') do:
                        [:pairStr |
                        | pair |
                        pair := pairStr findTokens: '='.
                        pair size > 0
                                ifTrue:
                                        [| key value |
                                        key := pair first withBlanksTrimmed asSymbol.
                                        value := pair size > 1
                                                ifTrue:
                                                        [pair second withBlanksTrimmed]
                                                ifFalse:
                                                        [nil].
                                        dict at: key put: value]
                                ifFalse:
                                        ["self log: 'Cookie invalid pair format: ''' , pairStr , ''''"

                                        ]].
        ^dict

Cheers
Philippe

Hi folks!

Just wanted to confirm that I now have transferred the ownership of the
KomHttpServer and KomServices entries in SM to myself (from Stephen Pair
- I checked this with him a while ago but didn't get around to do it)
and now that I control them I added Giovanni Corriga as a co-maintainer.

This means Giovanni is free to make SM releases and of course add
snapshots to the SS repo we use from now on, since it is actually open
for global write (so anyone can).

It is great that you guys fix/improve stuff in Kom - just go ahead!

regards, Göran

Il giorno mar, 23/10/2007 alle 14.23 -0400, Ron Teitelbaum ha scritto:
> Hi All,
>
> Shouldn't we be using http://www.squeaksource.com/KomWebServer.html or
> should this be deleted?

Hi Ron,

when I went to Squeaksource I looked for KomHttpServer, so I didn't find
this other repo. In any case I've copied all the packages to
KomHttpServer, and I've produced a new version that includes your
changes.

        Giovanni

Il giorno mar, 23/10/2007 alle 20.26 +0200, Philippe Marschall ha
scritto:

> I added the version from the SeasideInstaller. I'm sorry the history
> is a complete mess. The only things that are changed are:
> HttpRequest class >> #decodeUrlEncodedForm:multipleValues: and
> HttpRequest >> #initStatusString:. Instead of 'latin-1' as an ecoding
> you can also take nil. To fix all underscores you can use the class
> FixUnderscores. The fix for cookie parsing is:
> [...]

Hi Philippe

could you please check that the fixes in KomHttpServer-gc.28.mcz have
been applied correctly?

        Giovanni

2007/10/24, Giovanni Corriga <[hidden email]>:
Yes, but:
I loaded, KomHttpServer-gc.28, KomServices-gc.11, DynamicBindings-gc.7

When I run /seaside/tests/alltests -> Encoding -> Multipart, I get:

Internal Server Error
ConnectionTimedOut: Data receive timed out.

There seems to be a bug in multipart parsing. When talking about
multipart bugs. There is an other bug in Kom. The running behind
Apache in reverse proxy and keepAlive enabled multipart posts fail
from time to time and you get a proxy error. Sorry for not being more
specific.

Cheers
Philippe

Il giorno mer, 24/10/2007 alle 21.36 +0200, Philippe Marschall ha
scritto:
Ok, these bugs are now in the Mantis database as
http://bugs.squeak.org/view.php?id=6737 and
http://bugs.squeak.org/view.php?id=6738 .

        Giovanni

Il giorno gio, 25/10/2007 alle 00.23 +0200, Giovanni Corriga ha scritto:
> Il giorno mer, 24/10/2007 alle 21.36 +0200, Philippe Marschall ha
> scritto:

The multipart bug #6737 should be fixed in KomHttpServer-gc.29 . Could
you please confirm that everything's ok? If there are no more problems I
will release it as KomHttpServer 7.0.5 .

        Giovanni