Smalltalk › Squeak › Squeak - Dev

CompiledMethod changed in debugger does not get reflected in the browser nor monticello

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

timrowledge

CompiledMethod changed in debugger does not get reflected in the browser nor monticello

OK, weird behaviour of the day -
Loaded up the Refectoring tools tests; ran them. One failed because of Symbols not wanting to mutate - see RBSpellingRule>>#normalizeSelector:

I fixed this in the debugger to convert the incoming selector to a String and all runs as expected. Yay!

But.

The change is not reflected in the system browser; RBSpellingRule>>#normalizeSelector: still reads as before. No change is detected in the MC browser. No change was added to the current changeset. In the changelist as accessed by 'Recover changes' my alteration can be found and has my initials and a suitable timestamp.

Pretty sure that isn't how we want it.

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
..... REALITY.SYS Corrupted - Unable to recover Universe

marcel.taeumel

Re: CompiledMethod changed in debugger does not get reflected in the browser nor monticello

Hi Tim,

I had the same issue yesterday. Might be that the rb tests do a "SystemChangeNotifier doSilently: ..." during #performTest? This would extend to any debugger invoked by that test.

Best,

Marcel

Am 03.09.2019 02:24:26 schrieb tim Rowledge <[hidden email]>:
OK, weird behaviour of the day -
Loaded up the Refectoring tools tests; ran them. One failed because of Symbols not wanting to mutate - see RBSpellingRule>>#normalizeSelector:

I fixed this in the debugger to convert the incoming selector to a String and all runs as expected. Yay!

But.

The change is not reflected in the system browser; RBSpellingRule>>#normalizeSelector: still reads as before. No change is detected in the MC browser. No change was added to the current changeset. In the changelist as accessed by 'Recover changes' my alteration can be found and has my initials and a suitable timestamp.

Pretty sure that isn't how we want it.

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
..... REALITY.SYS Corrupted - Unable to recover Universe