Smalltalk › Squeak › Squeak - Dev

CompiledMethodTrailers ready for use

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

25 messages Options

David T. Lewis

Re: 2GB changes file and a pony (was: ALL CLEAR (Re: CompiledMethodTrailers ready for use))

I have put the updates for large changes and sources files into the
inbox. I would appreciate if someone can review this before moving
into trunk.

There are three mcz updates:
Files-dtl.62
System-dtl.205
Kernel-dtl.347

Important: The changes *must* be loaded in the order listed above.
This will require a configuration map update when the changes are
moved to trunk.

The use of ExpandedSourceFileArray takes effect after the first
image restart. To change back to using the StandardSourceFileArray,
the procedure is as follows:

1) Evaluate 'StandardSourceFileArray install'
2) Edit SourceFileArray class>>concreteClass to answer
StandardSourceFileArray rather than ExpandedSourceFileArray.

Thanks,
Dave

Andreas.Raab

Re: 2GB changes file and a pony

David T. Lewis wrote:
> I have put the updates for large changes and sources files into the
> inbox. I would appreciate if someone can review this before moving
> into trunk.

Looks excellent. I tried, ran all tests and there didn't seem to be any
problems whatsoever.

Cheers,
- Andreas

> There are three mcz updates:
> Files-dtl.62
> System-dtl.205
> Kernel-dtl.347
>
> Important: The changes *must* be loaded in the order listed above.
> This will require a configuration map update when the changes are
> moved to trunk.
>
> The use of ExpandedSourceFileArray takes effect after the first
> image restart. To change back to using the StandardSourceFileArray,
> the procedure is as follows:
>
> 1) Evaluate 'StandardSourceFileArray install'
> 2) Edit SourceFileArray class>>concreteClass to answer
> StandardSourceFileArray rather than ExpandedSourceFileArray.
>
> Thanks,
> Dave
>
>
>

David T. Lewis

Re: Re: 2GB changes file and a pony

On Sun, Dec 27, 2009 at 06:26:49PM +0100, Andreas Raab wrote:
> David T. Lewis wrote:
> >I have put the updates for large changes and sources files into the
> >inbox. I would appreciate if someone can review this before moving
> >into trunk.
>
> Looks excellent. I tried, ran all tests and there didn't seem to be any
> problems whatsoever.

Thanks for doing the configuration map update. It loaded in correct
order, no problems.

Dave

Levente Uzonyi-2

Re: 2GB changes file and a pony (was: ALL CLEAR (Re: CompiledMethodTrailers ready for use))

In reply to this post by David T. Lewis

On Sun, 27 Dec 2009, David T. Lewis wrote:

> I have put the updates for large changes and sources files into the
> inbox. I would appreciate if someone can review this before moving
> into trunk.
>
> There are three mcz updates:
> Files-dtl.62
> System-dtl.205
> Kernel-dtl.347
>
> Important: The changes *must* be loaded in the order listed above.
> This will require a configuration map update when the changes are
> moved to trunk.
>
> The use of ExpandedSourceFileArray takes effect after the first
> image restart. To change back to using the StandardSourceFileArray,
> the procedure is as follows:
>
> 1) Evaluate 'StandardSourceFileArray install'
> 2) Edit SourceFileArray class>>concreteClass to answer
> StandardSourceFileArray rather than ExpandedSourceFileArray.

I guess these steps should be swapped, since #install creates an instance
of #concreteClass.

Levente

>
> Thanks,
> Dave
>
>
>

David T. Lewis

Re: 2GB changes file and a pony (was: ALL CLEAR (Re: CompiledMethodTrailers ready for use))

On Sun, Dec 27, 2009 at 07:55:05PM +0100, Levente Uzonyi wrote:

> On Sun, 27 Dec 2009, David T. Lewis wrote:
>
> >The use of ExpandedSourceFileArray takes effect after the first
> >image restart. To change back to using the StandardSourceFileArray,
> >the procedure is as follows:
> >
> >1) Evaluate 'StandardSourceFileArray install'
> >2) Edit SourceFileArray class>>concreteClass to answer
> > StandardSourceFileArray rather than ExpandedSourceFileArray.
>
> I guess these steps should be swapped, since #install creates an instance
> of #concreteClass.

Yes you're right - sorry.

And hopefully if I did not make any more mistakes, nobody will care :)

Thanks very much for your careful review.

Dave