Decompiler reordering temps

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Decompiler reordering temps

Frank Shearar-3
I happened to have Metacello loaded when I ran the DecompilerTests. A
method (MetacelloCommonMCSpecLoader >>
#retryingResolvePackageSpecReferences:gofer:) has these locals
declared:

| references repositoryString retryCount repositoryError |

and when decompiled the list looks like this:

| references retryCount repositoryError repositoryString |

frank

Reply | Threaded
Open this post in threaded view
|

Re: Decompiler reordering temps

David T. Lewis
On Sat, Jun 22, 2013 at 11:38:46PM +0100, Frank Shearar wrote:

> I happened to have Metacello loaded when I ran the DecompilerTests. A
> method (MetacelloCommonMCSpecLoader >>
> #retryingResolvePackageSpecReferences:gofer:) has these locals
> declared:
>
> | references repositoryString retryCount repositoryError |
>
> and when decompiled the list looks like this:
>
> | references retryCount repositoryError repositoryString |
>

What's wrong with that?

Dave


Reply | Threaded
Open this post in threaded view
|

Re: Decompiler reordering temps

Frank Shearar-3
On 23 June 2013 01:04, David T. Lewis <[hidden email]> wrote:

> On Sat, Jun 22, 2013 at 11:38:46PM +0100, Frank Shearar wrote:
>> I happened to have Metacello loaded when I ran the DecompilerTests. A
>> method (MetacelloCommonMCSpecLoader >>
>> #retryingResolvePackageSpecReferences:gofer:) has these locals
>> declared:
>>
>> | references repositoryString retryCount repositoryError |
>>
>> and when decompiled the list looks like this:
>>
>> | references retryCount repositoryError repositoryString |
>>
>
> What's wrong with that?

It breaks a test. The Decompiler tests imply that foo's source and
foo's decompiled source are identical. This is another case where
that's not true.

So if you like, there's nothing wrong with it, and it's the test
that's broken (by being too strict). Either way there's a problem.

frank

> Dave
>
>