Display comments in MC patch browsers (was: [squeak-dev] The Inbox: Monticello-dtl.392.mcz)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Display comments in MC patch browsers (was: [squeak-dev] The Inbox: Monticello-dtl.392.mcz)

David T. Lewis
I added this update show changes to class comments in Monticello patch
browsers. I put it in the inbox, since I have little experience with
Monticello and I don't want to break something critical.

Note that both Monticello-topa.392 and Monticello-dtl.392 are now in
the inbox, so a merge may be needed.

Dave


On Thu, May 06, 2010 at 02:16:39AM +0000, [hidden email] wrote:

> A new version of Monticello was added to project The Inbox:
> http://source.squeak.org/inbox/Monticello-dtl.392.mcz
>
> ==================== Summary ====================
>
> Name: Monticello-dtl.392
> Author: dtl
> Time: 5 May 2010, 10:04:18.92 pm
> UUID: a0e86123-a9ae-48f8-95fa-9181a1241a35
> Ancestors: Monticello-ar.391
>
> Display class comment changes in Monticello patch browsers.
>
> =============== Diff against Monticello-ar.391 ===============
>
> Item was added:
> + ----- Method: MCClassDefinition>>printCommentOn: (in category 'printing') -----
> + printCommentOn: stream
> + stream
> + nextPut: $";
> + nextPutAll: self comment asString;
> + nextPut: $"
> + !
>
> Item was changed:
>   ----- Method: MCClassDefinition>>source (in category 'printing') -----
>   source
> + ^ self definitionAndCommentString!
> - ^ self definitionString!
>
> Item was added:
> + ----- Method: MCClassDefinition>>definitionAndCommentString (in category 'printing') -----
> + definitionAndCommentString
> + ^ String streamContents: [:stream |
> + self printDefinitionOn: stream.
> + stream cr; cr.
> + self printCommentOn: stream]!
>

Reply | Threaded
Open this post in threaded view
|

Re: Display comments in MC patch browsers

Andreas.Raab
On 5/5/2010 7:22 PM, David T. Lewis wrote:
> I added this update show changes to class comments in Monticello patch
> browsers. I put it in the inbox, since I have little experience with
> Monticello and I don't want to break something critical.

It looks good, if something breaks, I'll take the heat :-)

> Note that both Monticello-topa.392 and Monticello-dtl.392 are now in
> the inbox, so a merge may be needed.

Yup, did that.

Cheers,
   - Andreas

> On Thu, May 06, 2010 at 02:16:39AM +0000, [hidden email] wrote:
>> A new version of Monticello was added to project The Inbox:
>> http://source.squeak.org/inbox/Monticello-dtl.392.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Monticello-dtl.392
>> Author: dtl
>> Time: 5 May 2010, 10:04:18.92 pm
>> UUID: a0e86123-a9ae-48f8-95fa-9181a1241a35
>> Ancestors: Monticello-ar.391
>>
>> Display class comment changes in Monticello patch browsers.
>>
>> =============== Diff against Monticello-ar.391 ===============
>>
>> Item was added:
>> + ----- Method: MCClassDefinition>>printCommentOn: (in category 'printing') -----
>> + printCommentOn: stream
>> + stream
>> + nextPut: $";
>> + nextPutAll: self comment asString;
>> + nextPut: $"
>> + !
>>
>> Item was changed:
>>    ----- Method: MCClassDefinition>>source (in category 'printing') -----
>>    source
>> + ^ self definitionAndCommentString!
>> - ^ self definitionString!
>>
>> Item was added:
>> + ----- Method: MCClassDefinition>>definitionAndCommentString (in category 'printing') -----
>> + definitionAndCommentString
>> + ^ String streamContents: [:stream |
>> + self printDefinitionOn: stream.
>> + stream cr; cr.
>> + self printCommentOn: stream]!
>>
>
>


Reply | Threaded
Open this post in threaded view
|

Re: Display comments in MC patch browsers

David T. Lewis
On Wed, May 05, 2010 at 10:42:58PM -0700, Andreas Raab wrote:
> On 5/5/2010 7:22 PM, David T. Lewis wrote:
> >I added this update show changes to class comments in Monticello patch
> >browsers. I put it in the inbox, since I have little experience with
> >Monticello and I don't want to break something critical.
>
> It looks good, if something breaks, I'll take the heat :-)

Thanks. Possibly this will also result in comment updates appearing
in the the commit notification messages on squeak-dev. If somebody
writes a new comment or two, we'll find out :)

Dave


Reply | Threaded
Open this post in threaded view
|

Re: Display comments in MC patch browsers

Bert Freudenberg
On 06.05.2010, at 11:02, David T. Lewis wrote:

>
> On Wed, May 05, 2010 at 10:42:58PM -0700, Andreas Raab wrote:
>> On 5/5/2010 7:22 PM, David T. Lewis wrote:
>>> I added this update show changes to class comments in Monticello patch
>>> browsers. I put it in the inbox, since I have little experience with
>>> Monticello and I don't want to break something critical.
>>
>> It looks good, if something breaks, I'll take the heat :-)
>
> Thanks. Possibly this will also result in comment updates appearing
> in the the commit notification messages on squeak-dev. If somebody
> writes a new comment or two, we'll find out :)
>
> Dave

The server image generating the commit notes is not updated automatically.

But comment changes are already in the notifications - what do you think is missing? See below for an example.

- Bert -

Begin forwarded message:

> From: [hidden email]
> Date: 27. April 2010 08:17:39 GMT-07:00
> To: [hidden email], [hidden email]
> Subject: [squeak-dev] The Trunk: System-jcg.321.mcz
> Reply-To: [hidden email]
>
> Joshua Gargus uploaded a new version of System to project The Trunk:
> http://source.squeak.org/trunk/System-jcg.321.mcz
>
> ==================== Summary ====================
>
> Name: System-jcg.321
> Author: jcg
> Time: 27 April 2010, 1:14:47.36 am
> UUID: 82305d30-8760-ca40-9554-4eb47b763189
> Ancestors: System-laza.320
>
> Class comment for ObjectFinalizer.
>
> =============== Diff against System-laza.320 ===============
>
> Item was changed:
>  MessageSend subclass: #ObjectFinalizer
>   instanceVariableNames: ''
>   classVariableNames: ''
>   poolDictionaries: ''
>   category: 'System-Finalization'!
> +
> + !ObjectFinalizer commentStamp: 'jcg 4/27/2010 01:01' prior: 0!
> + Represents an action that is to be taken when a target object (not referenced by the ObjectFinalizer) is garbage-collected.!
>
>



Reply | Threaded
Open this post in threaded view
|

Re: Display comments in MC patch browsers

David T. Lewis
On Thu, May 06, 2010 at 11:24:52AM -0700, Bert Freudenberg wrote:

> On 06.05.2010, at 11:02, David T. Lewis wrote:
> >
> > Thanks. Possibly this will also result in comment updates appearing
> > in the the commit notification messages on squeak-dev. If somebody
> > writes a new comment or two, we'll find out :)
>
> The server image generating the commit notes is not updated automatically.
>
> But comment changes are already in the notifications - what do you
> think is missing? See below for an example.

Oops, I'm sorry. Never mind.

Dave