Doubles from #allCallsOn

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Doubles from #allCallsOn

Casey Ransberger
When I choose "class refs (N)" in my system browser I get doubles
back. This seems like a bug to me, but I wanted to be sure before
filing it. Is there any reason I should expect this behavior?

--
Ron

Reply | Threaded
Open this post in threaded view
|

Re: Doubles from #allCallsOn

Levente Uzonyi-2
On Mon, 23 Nov 2009, Ronald Spengler wrote:

> When I choose "class refs (N)" in my system browser I get doubles
> back. This seems like a bug to me, but I wanted to be sure before
> filing it. Is there any reason I should expect this behavior?

It's a bug, but we should discuss the fix IMO.
Eliot changed the behavior of CompiledMethod >> #hasLiteralThorough:. Now
variablebinding literals' keys are counted as literals, but they weren't
counted before.

The question is: should we keep the new behavior and change
Behavior >> #allCallsOn to call SystemNavigation >> #allCallsOn: with only
the class symbol (I did this before and it works for me), or should we
change the behavior of CompiledMethod >> #hasLiteralThorough: back to the
previous version?
Does Eliot's change has other effects besides this issue?

Levente

>
> --
> Ron
>
>

Reply | Threaded
Open this post in threaded view
|

Re: Doubles from #allCallsOn

Casey Ransberger
I filed http://bugs.squeak.org/view.php?id=7418 to track this issue.

On Mon, Nov 23, 2009 at 10:43 AM, Levente Uzonyi <[hidden email]> wrote:

> On Mon, 23 Nov 2009, Ronald Spengler wrote:
>
>> When I choose "class refs (N)" in my system browser I get doubles
>> back. This seems like a bug to me, but I wanted to be sure before
>> filing it. Is there any reason I should expect this behavior?
>
> It's a bug, but we should discuss the fix IMO.
> Eliot changed the behavior of CompiledMethod >> #hasLiteralThorough:. Now
> variablebinding literals' keys are counted as literals, but they weren't
> counted before.
>
> The question is: should we keep the new behavior and change
> Behavior >> #allCallsOn to call SystemNavigation >> #allCallsOn: with only
> the class symbol (I did this before and it works for me), or should we
> change the behavior of CompiledMethod >> #hasLiteralThorough: back to the
> previous version? Does Eliot's change has other effects besides this issue?
>
> Levente
>
>>
>> --
>> Ron
>>
>>
>
>



--
Ron