[ENH/FIX] SMTPClient

Hi all,
please find attached a fix for SMTPClient:
        1. RFC 2821 [1] (section 4.5.2 pag 53) states that a mail text line starting
           with a dot has to be modified such that an additional period has to be inserted
           at the beginning of the line. The problem in SMTPClient is that in
                SMTPClient>>data:
           the implementation was using
                String>>linesDo:
           which uses CR as line termination and not CRLF. So I added and used
                String>>linesCrLfDo:

        2. I removed HELO with ELHO

        3. I fixed the following commands in order to not have a SPC after ':'
           so to follow the RFC which states
                MAIL <SP> FROM:<reverse-path> <CRLF>
                RCPT <SP> TO:<forward-path> <CRLF>

        4. Added additional unit tests.

<<SMTPClient-espin.1.cs>>

Hope it helps
Bye
Enrico

[1] RFC 2821 <http://www.ietf.org/rfc/rfc2821.txt>
---
Enrico Spinielli                          Eurocontrol/CFMU
enrico.spinielli at eurocontrol.int       office 21.111
tel:+32-2-7299716                         Rue de la Fusée, 96
fax:+32-2-7299022                         B-1130 Bruxelles Belgium

____

This message and any files transmitted with it are legally privileged and intended for the sole use of the individual(s) or entity to whom they are addressed. If you are not the intended recipient, please notify the sender by reply and delete the message and any attachments from your system. Any unauthorised use or disclosure of the content of this message is strictly prohibited and may be unlawful.

Nothing in this e-mail message amounts to a contractual or legal commitment on the part of EUROCONTROL, unless it is confirmed by appropriately signed hard copy.

Any views expressed in this message are those of the sender.




 SMTPClient-espin.1.cs (6K) Download Attachment