[FIX] TextAnchor
Locked
 
|
The class TextAnchor (to allow Form's and Morph's in Text) is broken
because the method #emphasizeScanner: is missing. Moreover I removed the unreferenced and as well broken subclass TextAnchorPlus. Then I also changed the CharacterScanner to properly render transparent Form's. This involves 4 mcz-files all commited to the 3.9 inbox: - Multilingual-lr.11 - MorphicExtras-lr.10 - Morphic-lr.63 - Graphics-lr.17 Cheers, Lukas -- Lukas Renggli http://www.lukas-renggli.ch |
|
|
On 21.01.2006, at 16:12, Lukas Renggli wrote: > The class TextAnchor (to allow Form's and Morph's in Text) is broken > because the method #emphasizeScanner: is missing. Moreover I removed > the unreferenced and as well broken subclass TextAnchorPlus. Then I > also changed the CharacterScanner to properly render transparent > Form's. This involves 4 mcz-files all commited to the 3.9 inbox: > > - Multilingual-lr.11 > - MorphicExtras-lr.10 > - Morphic-lr.63 > - Graphics-lr.17 > So... how do we deal with patches that span packages maintained by differnt groups? I guess the first thing to check is which package depends on which, so we can start to bug the maintainer of that one to look at the change. Marcus |
|
|
In reply to this post by Lukas Renggli
Hi Team managers
how do we handle this one? I would like to integrate the fixes of lukas now they touch different packages. Normally it would be easy that we integrate them and that you merge in your changes after. Now I do not want to hear people syaing louding that we touched a package that they were maintaining. So I propose the following if by wednesday we hear nothing from the package maintainer, we proceed. Stef > From: Lukas Renggli <[hidden email]> > Date: 21 janvier 2006 16:12:10 HNEC > To: "Squeak 3.9" <[hidden email]> > Subject: [FIX] TextAnchor > > The class TextAnchor (to allow Form's and Morph's in Text) is broken > because the method #emphasizeScanner: is missing. Moreover I removed > the unreferenced and as well broken subclass TextAnchorPlus. Then I > also changed the CharacterScanner to properly render transparent > Form's. This involves 4 mcz-files all commited to the 3.9 inbox: > > - Multilingual-lr.11 > - MorphicExtras-lr.10 > - Morphic-lr.63 > - Graphics-lr.17 > > Cheers, > Lukas > > -- > Lukas Renggli > http://www.lukas-renggli.ch > |
|
|
Hi Stef,
>From time to time this will happen. I think it's ok for you to proceed. Of course, if you believe some change could be problematic you could ask the package maintainers for their opinion. But if you are sure of what you're doing, it's ok. Anyway, it's nice of you asking the package maintainers, to avoid changing the current version of the packages in the middle of their work. (This is just my opinion. If every package maintainers agree, much better then.) So, ok with me. Cheers, Juan ----- Original Message ----- From: "stéphane ducasse" <[hidden email]> To: "The general-purpose Squeak developers list" <[hidden email]> Cc: "Squeak 3.9" <[hidden email]> Sent: Saturday, January 21, 2006 1:25 PM Subject: Fwd: [FIX] TextAnchor > Hi Team managers > > how do we handle this one? > I would like to integrate the fixes of lukas now they touch different > packages. > Normally it would be easy that we integrate them and that you merge in > your changes after. > Now I do not want to hear people syaing louding that we touched a package > that they were maintaining. > So I propose the following if by wednesday we hear nothing from the > package maintainer, we proceed. > > Stef > > >> From: Lukas Renggli <[hidden email]> >> Date: 21 janvier 2006 16:12:10 HNEC >> To: "Squeak 3.9" <[hidden email]> >> Subject: [FIX] TextAnchor >> >> The class TextAnchor (to allow Form's and Morph's in Text) is broken >> because the method #emphasizeScanner: is missing. Moreover I removed >> the unreferenced and as well broken subclass TextAnchorPlus. Then I >> also changed the CharacterScanner to properly render transparent >> Form's. This involves 4 mcz-files all commited to the 3.9 inbox: >> >> - Multilingual-lr.11 >> - MorphicExtras-lr.10 >> - Morphic-lr.63 >> - Graphics-lr.17 >> >> Cheers, >> Lukas >> >> -- >> Lukas Renggli >> http://www.lukas-renggli.ch >> > > > > > -- > No virus found in this incoming message. > Checked by AVG Free Edition. > Version: 7.1.375 / Virus Database: 267.14.21/235 - Release Date: 1/19/2006 > > |
|
|
Thanks
now that the changes of andreas have been integrated this is easier for him to merge. the changes of lukas. Now I do not know how to sync. I will wait a bit...and then see what we can do. Stef On 24 janv. 06, at 13:57, Juan Vuletich wrote: > Hi Stef, > >> From time to time this will happen. I think it's ok for you to >> proceed. Of > course, if you believe some change could be problematic you could > ask the package maintainers for their opinion. But if you are sure > of what you're doing, it's ok. Anyway, it's nice of you asking the > package maintainers, to avoid changing the current version of the > packages in the middle of their work. > > (This is just my opinion. If every package maintainers agree, much > better then.) > > So, ok with me. > > Cheers, > Juan > > ----- Original Message ----- From: "stéphane ducasse" > <[hidden email]> > To: "The general-purpose Squeak developers list" <squeak- > [hidden email]> > Cc: "Squeak 3.9" <[hidden email]> > Sent: Saturday, January 21, 2006 1:25 PM > Subject: Fwd: [FIX] TextAnchor > > >> Hi Team managers >> >> how do we handle this one? >> I would like to integrate the fixes of lukas now they touch >> different packages. >> Normally it would be easy that we integrate them and that you >> merge in your changes after. >> Now I do not want to hear people syaing louding that we touched a >> package that they were maintaining. >> So I propose the following if by wednesday we hear nothing from >> the package maintainer, we proceed. >> >> Stef >> >> >>> From: Lukas Renggli <[hidden email]> >>> Date: 21 janvier 2006 16:12:10 HNEC >>> To: "Squeak 3.9" <[hidden email]> >>> Subject: [FIX] TextAnchor >>> >>> The class TextAnchor (to allow Form's and Morph's in Text) is broken >>> because the method #emphasizeScanner: is missing. Moreover I removed >>> the unreferenced and as well broken subclass TextAnchorPlus. Then I >>> also changed the CharacterScanner to properly render transparent >>> Form's. This involves 4 mcz-files all commited to the 3.9 inbox: >>> >>> - Multilingual-lr.11 >>> - MorphicExtras-lr.10 >>> - Morphic-lr.63 >>> - Graphics-lr.17 >>> >>> Cheers, >>> Lukas >>> >>> -- >>> Lukas Renggli >>> http://www.lukas-renggli.ch >>> >> >> >> >> >> -- >> No virus found in this incoming message. >> Checked by AVG Free Edition. >> Version: 7.1.375 / Virus Database: 267.14.21/235 - Release Date: >> 1/19/2006 >> > > |
«
Return to Squeak - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |