Smalltalk › Squeak › Squeak - Dev

FYI Squeak5.0 latest update: #15987

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

tty

FYI Squeak5.0 latest update: #15987

FYI

Just upgraded to check out Patrick Rein's Terse Guide addition.

Squeak5.0
latest update: #15987

After upgrade, opening the Help kicked in that "CR to enter an emergency evaluator" window.

The DNU exception was thrown in

SimpleHierarchicalListMorph >> drawLinesOn: aCanvas

.....
ifTrue:
[submorph drawLinesOn: clippedCanvas lineColor: lColor]]]

submorph in this case was an instance of IndentingListItemMorph where

In that class I added the missing method that invokes an existing and similar method with a default value of 1.

drawLinesOn: aCanvas lineColor: lineColor
self drawLinesOn: aCanvas lineColor: lineColor indentThreshold: 1.

Help browser now opens with no errors.

tty

marcel.taeumel

Re: FYI Squeak5.0 latest update: #15987

Hi Timothy,

which time stamp does SimpleHierarchicalListMorph >> drawLinesOn: have in your image? It seems rather old to me. The current version is mt 4/22/2016 10:52 :

SimpleHierarchicalListMorph >> drawLinesOn: aCanvas

| lColor |
lColor := self lineColor.
aCanvas
transformBy: scroller transform
clippingTo: scroller innerBounds
during:[:clippedCanvas |
scroller submorphsDo: [ :submorph |
(submorph visible and: [(submorph isExpanded
or: [clippedCanvas isVisible: submorph fullBounds] )
or: [ submorph nextSibling notNil and: [clippedCanvas isVisible: submorph nextSibling fullBounds]]])
ifTrue: [submorph drawLinesOn: clippedCanvas lineColor: lColor indentThreshold: 0] ] ]
smoothing: scroller smoothing.

Best, Marcel

tty

Re: FYI Squeak5.0 latest update: #15987

Hi Timothy,

which time stamp does SimpleHierarchicalListMorph >> drawLinesOn: have in
your image? It seems rather old to me. The current version is mt 4/22/2016
10:52 :

Bingo.

I installed the BabyIDE and that set it back to TRee 3/25/2008

I will revert now.

thanks!

---- On Fri, 27 May 2016 10:12:12 -0400 marcel.taeumel <[hidden email]> wrote ----

SimpleHierarchicalListMorph >> drawLinesOn: aCanvas

    | lColor |
    lColor := self lineColor.
    aCanvas
        transformBy: scroller transform
        clippingTo: scroller innerBounds
        during:[:clippedCanvas |
            scroller submorphsDo: [ :submorph |
                (submorph visible and: [(submorph isExpanded
                    or: [clippedCanvas isVisible: submorph fullBounds] )
                    or: [    submorph nextSibling notNil and: [clippedCanvas isVisible:
submorph nextSibling fullBounds]]])
                         ifTrue: [submorph drawLinesOn: clippedCanvas lineColor: lColor
indentThreshold: 0] ] ]
        smoothing: scroller smoothing.

Best, Marcel