Failed: OpenSmalltalk/opensmalltalk-vm#1542 (Cog - 2238b2e)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Failed: OpenSmalltalk/opensmalltalk-vm#1542 (Cog - 2238b2e)

Travis CI
 

OpenSmalltalk

/

opensmalltalk-vm

branch iconCog

arrow to build time
clock icon10 mins and 46 secs

Eliot Miranda avatarEliot Miranda

CogVM source as per VMMaker.oscog-eem.2493

SmartSyntaxPlugin Slang:
Improve failure guard & result returning interleaving to avoid extra returns
and tests of failed (see fixUpReturnOneStmt:on:). Eliminate the unused
suppressFailureGuards: support and inst vars.

Separate argument validation from argument marshalling to fix the bug Levente
identified in SocketPlugin>>primitiveSocket:connectTo:port:/primitiveSocketConnectToPort.
Because the old scheme interleaved validation and marshalling, marshalling
could be done on invalid objects and cause crashes. See
http://lists.squeakfoundation.org/pipermail/vm-dev/2018-December/029511.html.
Also have teh primitives answer primErrBadArgument if validation fails.

To this end add InterpreterProxy>>isPositiveMachineIntegerObject: &
InterpreterProxy>>isBooleanObject:, bumping up the API version to 1.15.

Update Slang Test Workspace.text for plugin generation.

Want to know about upcoming build environment updates?

Would you like to stay up-to-date with the upcoming Travis CI build environment updates? We set up a mailing list for you!

SIGN UP HERE
book icon

Documentation about Travis CI

<script type="application/ld+json"> { "@context": "http://schema.org", "@type": "EmailMessage", "action": { "@type": "ViewAction", "url": "https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/469830282?utm_medium=notification&amp;utm_source=email", "name": "View Build" }, "description": "View Build #1542 on Travis CI" } </script>