OpenSmalltalk
/
opensmalltalk-vm
|
Cog
|
40 mins and 41 secs
|
Nicolas Cellier
|
Minor patch for making unix SocketPlugin 64bits friendly
IPV4 address are uint32_t, not u_long This is not the same on 64 bits. This has a consequence on alignment of pointer aliasing (u_long might require 8 bytes alignment). This remove a runtime UndefinedBehavior sanitizer message (UBsan) when compiled with CC=clang ./mvm and CFLAGS -fsanitize=undefined. So far, the consequence are void, but let's not insult the future...
Note that I used autotools HAVE_STDINT_H for backward compatibility but we could either drop this compatibility like already done in SSL or Camera plugin... C99 is already 20years behind!
Also avoid converting a pointer (PSP) to (unsigned long) just for printing... We have %p now for that purpose (like already used elsewhere in the same file).
|
|
|
Would you like to stay up-to-date with the upcoming Travis CI build environment updates? We set up a mailing list for you!
SIGN UP HERE
|
|
|
|
<script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"action": {
"@type": "ViewAction",
"url": "https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/589529234?utm_medium=notification&utm_source=email",
"name": "View Build"
},
"description": "View Build #1812 on Travis CI"
}
</script>