Hi Folks,
Ken Dickey and the Cuis team found some... unexpected behaviour in FileDirectory, and just as importantly, have found a fix. Please take a look at the change, and if we're OK with it, some kind soul can push it to Trunk :) There's at least one bug, in that Juan Vuletich found that on Windows opening a FileList causes an infinite recursion. Thanks, frank ---------- Forwarded message ---------- From: Ken Dickey <[hidden email]> Date: 3 June 2014 03:57 Subject: (FileDirectory default directoryContentsFor: '') explore. To: Frank Shearar <[hidden email]> Hi Frank, In case you missed the Cuis thread on this: Attached is my suggested fix for the schizophrenic behavior of (FileDirectory default directoryContentsFor: '') explore. which on Linux gives directory entries with file names and info from my home directory but with directory info from the image launch directory. This is the same behavior on Cuis current and Squeak 4.5. I am not on the Squeak developers' list, but I suspect you will do the proper thing here. ;^) Cheers, -KenD FileDirectory-directoryContentsFor.st (1K) Download Attachment |
The latest version of the fix - and what has gone into Cuis - you can
find here: https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev/commit/fb201fc5033c71f64f2e6ea1717b313f02866a1c frank On 3 June 2014 17:14, Frank Shearar <[hidden email]> wrote: > Hi Folks, > > Ken Dickey and the Cuis team found some... unexpected behaviour in > FileDirectory, and just as importantly, have found a fix. Please take > a look at the change, and if we're OK with it, some kind soul can push > it to Trunk :) > > There's at least one bug, in that Juan Vuletich found that on Windows > opening a FileList causes an infinite recursion. > > Thanks, > > frank > > > ---------- Forwarded message ---------- > From: Ken Dickey <[hidden email]> > Date: 3 June 2014 03:57 > Subject: (FileDirectory default directoryContentsFor: '') explore. > To: Frank Shearar <[hidden email]> > > > Hi Frank, > > In case you missed the Cuis thread on this: > > Attached is my suggested fix for the schizophrenic behavior of > > (FileDirectory default directoryContentsFor: '') explore. > > which on Linux gives directory entries with file names and info from > my home directory but with directory info from the image launch > directory. > > This is the same behavior on Cuis current and Squeak 4.5. > > I am not on the Squeak developers' list, but I suspect you will do the > proper thing here. ;^) > > Cheers, > -KenD |
How does one go about seeing just the change that was made instead of
the entire methods? On Wed, Jun 4, 2014 at 10:59 AM, Frank Shearar <[hidden email]> wrote: > The latest version of the fix - and what has gone into Cuis - you can > find here: https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev/commit/fb201fc5033c71f64f2e6ea1717b313f02866a1c > > frank > > On 3 June 2014 17:14, Frank Shearar <[hidden email]> wrote: >> Hi Folks, >> >> Ken Dickey and the Cuis team found some... unexpected behaviour in >> FileDirectory, and just as importantly, have found a fix. Please take >> a look at the change, and if we're OK with it, some kind soul can push >> it to Trunk :) >> >> There's at least one bug, in that Juan Vuletich found that on Windows >> opening a FileList causes an infinite recursion. >> >> Thanks, >> >> frank >> >> >> ---------- Forwarded message ---------- >> From: Ken Dickey <[hidden email]> >> Date: 3 June 2014 03:57 >> Subject: (FileDirectory default directoryContentsFor: '') explore. >> To: Frank Shearar <[hidden email]> >> >> >> Hi Frank, >> >> In case you missed the Cuis thread on this: >> >> Attached is my suggested fix for the schizophrenic behavior of >> >> (FileDirectory default directoryContentsFor: '') explore. >> >> which on Linux gives directory entries with file names and info from >> my home directory but with directory info from the image launch >> directory. >> >> This is the same behavior on Cuis current and Squeak 4.5. >> >> I am not on the Squeak developers' list, but I suspect you will do the >> proper thing here. ;^) >> >> Cheers, >> -KenD > |
Unfortunately one can't, because this commit contains the addition of
complete (changeset) files. I think the quickest way to see the change would be to filein those files, annoyingly. (I actually hadn't noticed that the commit was just the addition of files :/) frank On 4 June 2014 20:15, Chris Muller <[hidden email]> wrote: > How does one go about seeing just the change that was made instead of > the entire methods? > > On Wed, Jun 4, 2014 at 10:59 AM, Frank Shearar <[hidden email]> wrote: >> The latest version of the fix - and what has gone into Cuis - you can >> find here: https://github.com/Cuis-Smalltalk/Cuis-Smalltalk-Dev/commit/fb201fc5033c71f64f2e6ea1717b313f02866a1c >> >> frank >> >> On 3 June 2014 17:14, Frank Shearar <[hidden email]> wrote: >>> Hi Folks, >>> >>> Ken Dickey and the Cuis team found some... unexpected behaviour in >>> FileDirectory, and just as importantly, have found a fix. Please take >>> a look at the change, and if we're OK with it, some kind soul can push >>> it to Trunk :) >>> >>> There's at least one bug, in that Juan Vuletich found that on Windows >>> opening a FileList causes an infinite recursion. >>> >>> Thanks, >>> >>> frank >>> >>> >>> ---------- Forwarded message ---------- >>> From: Ken Dickey <[hidden email]> >>> Date: 3 June 2014 03:57 >>> Subject: (FileDirectory default directoryContentsFor: '') explore. >>> To: Frank Shearar <[hidden email]> >>> >>> >>> Hi Frank, >>> >>> In case you missed the Cuis thread on this: >>> >>> Attached is my suggested fix for the schizophrenic behavior of >>> >>> (FileDirectory default directoryContentsFor: '') explore. >>> >>> which on Linux gives directory entries with file names and info from >>> my home directory but with directory info from the image launch >>> directory. >>> >>> This is the same behavior on Cuis current and Squeak 4.5. >>> >>> I am not on the Squeak developers' list, but I suspect you will do the >>> proper thing here. ;^) >>> >>> Cheers, >>> -KenD >> > |
Free forum by Nabble | Edit this page |