Smalltalk › Squeak › Squeak VM

Fwd: squeak-vm-4.10.2.2614 bug report

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

5 messages Options

Ian Piumarta

Fwd: squeak-vm-4.10.2.2614 bug report

FYI. This looks like a case of "x min: x" or "x max: x" somewhere in BitBlt.

Begin forwarded message:

> Date: December 10, 2013 08:35:49 PST
> Subject: squeak-vm-4.10.2.2614 bug report
>
> Hello there,
>
> I just ran the static analyser cppcheck over the source
> code of squeak-vm-4.10.2.2614. It said many things,
> including
>
> [/home/dcb/rpmbuild/BUILD/Squeak-4.10.2.2614-src-no-mp3/unix/src/vm/intplugins/BitBltPlugin/BitBltPlugin.c:2573] -> [/home/dcb/rpmbuild/BUILD/Squeak-4.10.2.2614-src-no-mp3/unix/src/vm/intplugins/BitBltPlugin/BitBltPlugin.c:2573]: (style) Same expression on both sides of '<'.
>
> Source code is
>
> b = (((sy < sy) ? sy : sy)) + bbH;
>
> Regards
>
> David Binderman

Eliot Miranda-2

Re: Fwd: squeak-vm-4.10.2.2614 bug report

tis in lockSurfaces:

"Otherwise use overlapping area"

l := sx min: dx. r := (sx max: dx) + bbW.

t := sy min: dy. b := (sy max: sy) + bbH.

sourceBits := self cCode:'fn(sourceHandle, &sourcePitch, l, t, r-l, b-t)'.

I'll change it to

"Otherwise use overlapping area"

l := sx min: dx. r := (sx max: dx) + bbW.

t := sy min: dy. b := (sy max: dy) + bbH.

sourceBits := self cCode:'fn(sourceHandle, &sourcePitch, l, t, r-l, b-t)'.

On Tue, Dec 10, 2013 at 10:48 AM, Ian Piumarta <[hidden email]> wrote:

FYI. This looks like a case of "x min: x" or "x max: x" somewhere in BitBlt.

Begin forwarded message:

> Date: December 10, 2013 08:35:49 PST
> Subject: squeak-vm-4.10.2.2614 bug report
>
> Hello there,
>
> I just ran the static analyser cppcheck over the source
> code of squeak-vm-4.10.2.2614. It said many things,
> including
>
> [/home/dcb/rpmbuild/BUILD/Squeak-4.10.2.2614-src-no-mp3/unix/src/vm/intplugins/BitBltPlugin/BitBltPlugin.c:2573] -> [/home/dcb/rpmbuild/BUILD/Squeak-4.10.2.2614-src-no-mp3/unix/src/vm/intplugins/BitBltPlugin/BitBltPlugin.c:2573]: (style) Same expression on both sides of '<'.
>
> Source code is
>
> b = (((sy < sy) ? sy : sy)) + bbH;
>
> Regards
>
> David Binderman

--
best,

Eliot

Eliot Miranda-2

Re: Fwd: squeak-vm-4.10.2.2614 bug report

The attached will be in the Cog branch. Cam someone put it in VMMaker?

On Tue, Dec 10, 2013 at 10:58 AM, Eliot Miranda <[hidden email]> wrote:

tis in lockSurfaces:

"Otherwise use overlapping area"

l := sx min: dx. r := (sx max: dx) + bbW.

t := sy min: dy. b := (sy max: sy) + bbH.
sourceBits := self cCode:'fn(sourceHandle, &sourcePitch, l, t, r-l, b-t)'.

I'll change it to

"Otherwise use overlapping area"
l := sx min: dx. r := (sx max: dx) + bbW.

t := sy min: dy. b := (sy max: dy) + bbH.
sourceBits := self cCode:'fn(sourceHandle, &sourcePitch, l, t, r-l, b-t)'.

On Tue, Dec 10, 2013 at 10:48 AM, Ian Piumarta <[hidden email]> wrote:

FYI. This looks like a case of "x min: x" or "x max: x" somewhere in BitBlt.

Begin forwarded message:

> Date: December 10, 2013 08:35:49 PST
> Subject: squeak-vm-4.10.2.2614 bug report
>
> Hello there,
>
> I just ran the static analyser cppcheck over the source
> code of squeak-vm-4.10.2.2614. It said many things,
> including
>
> [/home/dcb/rpmbuild/BUILD/Squeak-4.10.2.2614-src-no-mp3/unix/src/vm/intplugins/BitBltPlugin/BitBltPlugin.c:2573] -> [/home/dcb/rpmbuild/BUILD/Squeak-4.10.2.2614-src-no-mp3/unix/src/vm/intplugins/BitBltPlugin/BitBltPlugin.c:2573]: (style) Same expression on both sides of '<'.
>
> Source code is
>
> b = (((sy < sy) ? sy : sy)) + bbH;
>
> Regards
>
> David Binderman

--
best,
Eliot

--
best,

Eliot

BitBltSimulation-lockSurfaces.st (5K) Download Attachment

tty

Thanks

Thanks all for your patience and help. It really helps when people offer direction on where to look.

Because of that, I am now on Contexts/Closures with Squeak4.5 and Squeak4.0 side by side and I can
follow along with the lesson at http://www.mirandabanda.org/cogblog/category/cog/page/14/ and know what the heck I am looking at.

It sounds silly, but being able to finally see the utility of 'explore' vs 'inspect' feels like making the jump from application developer to systems developer.

cheers.

tty

David T. Lewis

Re: Fwd: squeak-vm-4.10.2.2614 bug report

In reply to this post by Eliot Miranda-2

On Tue, Dec 10, 2013 at 10:59:44AM -0800, Eliot Miranda wrote:
>
> The attached will be in the Cog branch. Cam someone put it in VMMaker?
>

Done. Thanks Eliot.

Ian, sources are updated in trunk/src

Dave

>
> On Tue, Dec 10, 2013 at 10:58 AM, Eliot Miranda <[hidden email]>wrote:
>
> > tis in lockSurfaces:
> >
> >
> > "Otherwise use overlapping area"
> > l := sx min: dx. r := (sx max: dx) + bbW.
> > t := sy min: dy. b := (sy max: sy) + bbH.
> > sourceBits := self cCode:'fn(sourceHandle, &sourcePitch, l, t, r-l, b-t)'.
> >
> > I'll change it to
> >
> > "Otherwise use overlapping area"
> > l := sx min: dx. r := (sx max: dx) + bbW.
> > t := sy min: dy. b := (sy max: dy) + bbH.
> > sourceBits := self cCode:'fn(sourceHandle, &sourcePitch, l, t, r-l, b-t)'.
> >
> >
> > On Tue, Dec 10, 2013 at 10:48 AM, Ian Piumarta <[hidden email]>wrote:
> >
> >>
> >> FYI. This looks like a case of "x min: x" or "x max: x" somewhere in
> >> BitBlt.
> >>
> >> Begin forwarded message:
> >>
> >> > Date: December 10, 2013 08:35:49 PST
> >> > Subject: squeak-vm-4.10.2.2614 bug report
> >> >
> >> > Hello there,
> >> >
> >> > I just ran the static analyser cppcheck over the source
> >> > code of squeak-vm-4.10.2.2614. It said many things,
> >> > including
> >> >
> >> >
> >> [/home/dcb/rpmbuild/BUILD/Squeak-4.10.2.2614-src-no-mp3/unix/src/vm/intplugins/BitBltPlugin/BitBltPlugin.c:2573]
> >> ->
> >> [/home/dcb/rpmbuild/BUILD/Squeak-4.10.2.2614-src-no-mp3/unix/src/vm/intplugins/BitBltPlugin/BitBltPlugin.c:2573]:
> >> (style) Same expression on both sides of '<'.
> >> >
> >> > Source code is
> >> >
> >> > b = (((sy < sy) ? sy : sy)) + bbH;
> >> >
> >> > Regards
> >> >
> >> > David Binderman
> >>
> >>
> >
> >
> > --
> > best,
> > Eliot
> >
>
>
>
> --
> best,
> Eliot