Getting from GitBrowser to the System Browser

Hi,

Loading the repository packages with Git will only load the packages
that belong to Roassal, but not its dependencies (other third-party
packages) if any. To get the dependencies, Metacello is used.
(Moreover the Metacello baseline could indicate that some packages are
only relevant for Pharo version x and others for Pharo version y, or
others for Squeak version z. I suppose that is something Tom has been
modifying for his *-Squeak package.)

So I would recommend: first install the software via Metacello, then
start using Git on the loaded packages. It does not really matter
whether you initialize the Git project before or after loading with
Metacello. That is because currently the Clone action does not load
the packages into the image (you would still have to "Checkout
objects" after cloning). I should probably change that in the future.
If you Add the repository instead of Clone, nothing will be loaded at
first either.

After you have both loaded the code via Metacello and set up the Git
repository, check whether there are any differences between your image
and what is on the active branch (the one with the green dot) by
pushing the Commit button or right-clicking the top commit or active
branch and choosing "Compare with working copy".

If there are differences and if that is because a different branch or
commit was used in the Metacello load, you have some options to fix
the situation:
1) Identify the correct branch that you installed via Metacello. Then
shift+right-click on the branch and choose "Make this the current
branch". This will change the active branch, but not make any changes
to the loaded classes (similar to Reparent in Monticello).
2) If there is no branch, identify the commit that matches what you
installed, find it in the commit list, right-click on it and choose
"Create new branch at this commit". Then proceed with option 1.
3) Overwrite the loaded classes with the state of the active branch:
right-click on the top commit and choose "Checkout objects".

If you do not use Metacello, you must collect the dependencies
manually and load them with Git or Monticello in the correct order. To
find the dependencies, you would read the baseline(s) and thus follow
the dependency graph.

Kind regards,
Jakob

Am So., 4. Okt. 2020 um 14:34 Uhr schrieb gettimothy <[hidden email]>:

>
> Hi folks,
>
> backing up from the specifics and looking at the "correct" way to go about this so we are all on the same page.
>
> Could you please check my assumptions as this Git stuff in squeak is new to me.
>
>
> If we have the Git, why do we need the Metacello? Can/should we do all the work in the Git and then when it is done, do the Metacello?
>
>
> Assuming "doing all the work in Git" is the way to go...
>
> Is just "working through the baseline" and getting things in the system a good approach?
>
> Thoughts?
>
> thx
>
> tty
>

It looks like Jakob beat me by a couple of seconds :D

Concerning the MCStReader error, have a look at this Inbox commit to fix it locally in your image for the moment :)

http://forum.world.st/The-Inbox-Monticello-tobe-729-mcz-td5122924.html

On Sun, Oct 4, 2020 at 3:14 PM Tom Beckmann <[hidden email]> wrote:

Hi timothy,

first, on the Array>>\ error, this is likely because you somehow ended up with the master instead of the squeak branch of squeak-tonel. I would recommend to manually unload all three tonel packages using the Monticello Browser and then running:

Metacello new
     repository: 'github://squeak-smalltalk/squeak-tonel:squeak';
     baseline: 'Tonel';
     load.

On Metacello vs Git and the general workflow:

- from my understanding, it is generally recommendable to first install a package using Metacello as it takes care to resolve and install third-party dependencies you may not want to care about

- Metacello is, however, end-user oriented if you will; the sources are stored in a github-cache folder, which only exists for caching purposes. My usual workflow is thus, after installing the desired package once using Metacello, to clone the main repo (the repo that I actually care about) again using the GitBrowser and do a checkout on the most recent commit on master; this should leave things unchanged provided that Metacello also installed the version from the master branch

- You can then work in your image and adapt things as needed; when you have a working increment, you can use the GitBrowser again to create commits and push them Github, typically to a fork that belongs to you and then place a pull request

You can skip Metacello if you clone all dependencies using the GitBrowser and install them one after the other in the right order. If you look at the many dependencies of for example Roassal [1], it will however be pretty obvious why you would usually want to have Metacello automate this for you.

Hope this helps you to get started. Please feel free to ask again if I left something unanswered or if you feel like the workflow should be easier in some way. Maybe there is something we can improve :)

Best,

Tom

[1] https://github.com/tom95/Roassal3/blob/master/src/BaselineOfRoassal3/BaselineOfRoassal3.class.st#L64

On Sun, Oct 4, 2020 at 2:34 PM gettimothy via Squeak-dev <[hidden email]> wrote:

Hi folks,

backing up from the specifics and looking at the "correct" way to go about this so we are all on the same page.

Could you please check my assumptions as this Git stuff in squeak is new to me.

If we have the Git, why do we need the Metacello? Can/should we do all the work in the Git and then when it is done, do the Metacello?

Assuming "doing all the work in Git" is the way to go...

Is just "working through the baseline" and getting things in the system a good approach?

Thoughts?

thx

tty

Hi Tom,

Still having problems loading Roassal3 via Metacello

Here are my steps:

pristine image

Preference Wizard last page install git, refactor etc.

Installer ensureRecentMetacello

SquitAddRemote >>remoteName

^ remoteName ifNil: [String empty] ifNotNil: [remoteName asString]

Manually unload all three tonel packages using the Monticello Browser

MonticelloTonel-Core

MonticelloTonel-FileSystem

MonticelloTonel-Tests

and then running:

Metacello new

     repository: 'github://squeak-smalltalk/squeak-tonel:squeak';

     baseline: 'Tonel';

     load.

Metacello new

    baseline: 'Roassal3';

    repository: 'github://tom95/Roassal3';

    load.

GoferRepositoryError: UndefinedObject>>directoryFromPath:relativeTo:

from MetacelloFetchingMCSPecLoader >> linearLoadPackageSpec: gover:


this call here:     

references := self

        retryingResolvePackageSpecReferences: packageSpec

        gofer: gofer. "look up mcz file"

Transcript shows:

...RETRY->BaselineOfRoassal3

...RETRY->BaselineOfRoassal3

gofer repository error: 'GoferRepositoryError: UndefinedObject>>directoryFromPath:relativeTo:'...ignoring

...FAILED->BaselineOfRoassal3

I am on 9.0 alpha...should I try a 5.3 image?

cheers.

---- On Sun, 04 Oct 2020 09:17:54 -0400 Tom Beckmann <[hidden email]> wrote ----

It looks like Jakob beat me by a couple of seconds :D

Concerning the MCStReader error, have a look at this Inbox commit to fix it locally in your image for the moment :)

http://forum.world.st/The-Inbox-Monticello-tobe-729-mcz-td5122924.html

On Sun, Oct 4, 2020 at 3:14 PM Tom Beckmann <[hidden email]> wrote:

Hi timothy,

first, on the Array>>\ error, this is likely because you somehow ended up with the master instead of the squeak branch of squeak-tonel. I would recommend to manually unload all three tonel packages using the Monticello Browser and then running:

Metacello new
     repository: 'github://squeak-smalltalk/squeak-tonel:squeak';
     baseline: 'Tonel';
     load.

On Metacello vs Git and the general workflow:

- from my understanding, it is generally recommendable to first install a package using Metacello as it takes care to resolve and install third-party dependencies you may not want to care about

- Metacello is, however, end-user oriented if you will; the sources are stored in a github-cache folder, which only exists for caching purposes. My usual workflow is thus, after installing the desired package once using Metacello, to clone the main repo (the repo that I actually care about) again using the GitBrowser and do a checkout on the most recent commit on master; this should leave things unchanged provided that Metacello also installed the version from the master branch

- You can then work in your image and adapt things as needed; when you have a working increment, you can use the GitBrowser again to create commits and push them Github, typically to a fork that belongs to you and then place a pull request

You can skip Metacello if you clone all dependencies using the GitBrowser and install them one after the other in the right order. If you look at the many dependencies of for example Roassal [1], it will however be pretty obvious why you would usually want to have Metacello automate this for you.

Hope this helps you to get started. Please feel free to ask again if I left something unanswered or if you feel like the workflow should be easier in some way. Maybe there is something we can improve :)

Best,

Tom

[1] https://github.com/tom95/Roassal3/blob/master/src/BaselineOfRoassal3/BaselineOfRoassal3.class.st#L64

On Sun, Oct 4, 2020 at 2:34 PM gettimothy via Squeak-dev <[hidden email]> wrote:

Hi folks,

backing up from the specifics and looking at the "correct" way to go about this so we are all on the same page.

Could you please check my assumptions as this Git stuff in squeak is new to me.

If we have the Git, why do we need the Metacello? Can/should we do all the work in the Git and then when it is done, do the Metacello?

Assuming "doing all the work in Git" is the way to go...

Is just "working through the baseline" and getting things in the system a good approach?

Thoughts?

thx

tty

A couple of things.

TonelFileUtils install

is not being automatically run . this populates the Current class instance variable needed or the TonelFilueUtils > current class side call.

Then, in 

TonelRepository >> directoryFromFileName: aString

"Answer the reference to the directory represented by the 'file name'."

^ self fileUtils

directoryFromPath: (self class directoryNameFromFileName: aString)

relativeTo: self directory

is throwing an SubclassResponsibility signal because 

TonelFileUtils class >> directoryFromPath: directoryPath relativeTo: aDirectory    self subclassResponsibility

What I presume we want is a TonelFileSystemUtils...

so....in 

TonelFileUtils class >> install    Current := self

make it:

TonelFileUtils class >>install    Current := TonelFileSystemUtils