Help: Etoys package changes vs trunk

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Help: Etoys package changes vs trunk

K K Subbu
Hi,

On a fresh copy of 6.0alpha-19537-64bit, I see the following changes
between Etoys package and the trunk:
---
D TextMorphEditor>>select
D TextMorphEditor>>selectionInterval:
----
Because of these changes, I am unable to save a fix to MonthMorph (see
attached) to Inbox.

How can I sync up with the trunk for these changes?

Regards .. Subbu



monfix.1.cs (679 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Help: Etoys package changes vs trunk

Christoph Thiede

Hi Subbu,


thanks for the interesting bug report! TextMorphEditor is located in the 51Deprecated package. If I am not mistaken, Squeak 6.0 should not any longer contain these packages. See Squeak-Version-mt.5252.

However, the deprecated class TextMorphEditor contained EToys extension methods. These were removed locally in your image via the postload script of the above commit, but not removed from the Trunk's latest Monticello version.

I just fixed this apparent accident in EToys-ct.389 (inbox).


Apart from that, you can certainly hide these changes from your inbox commit by right-clicking them in the Monticello browser and choosing "ignore". :-)


Best,

Christoph


Von: Squeak-dev <[hidden email]> im Auftrag von K K Subbu <[hidden email]>
Gesendet: Sonntag, 5. April 2020 20:28:41
An: The general-purpose Squeak developers list
Betreff: [squeak-dev] Help: Etoys package changes vs trunk
 
Hi,

On a fresh copy of 6.0alpha-19537-64bit, I see the following changes
between Etoys package and the trunk:
---
D       TextMorphEditor>>select
D       TextMorphEditor>>selectionInterval:
----
Because of these changes, I am unable to save a fix to MonthMorph (see
attached) to Inbox.

How can I sync up with the trunk for these changes?

Regards .. Subbu


Carpe Squeak!
Reply | Threaded
Open this post in threaded view
|

Re: Help: Etoys package changes vs trunk

K K Subbu
On 06/04/20 12:45 AM, Thiede, Christoph wrote:
>
> Apart from that, you can certainly hide these changes from your inbox
> commit by right-clicking them in the Monticello browser and choosing
> "ignore". :-)

Thanks for this tip. I wasn't sure about the difference between
ignore(i) and "remove from current changeset".

I uploaded the patch to Inbox. MonthMorph is quite a useful morph to
have around while talking about dates and schedules. We could use the
clock in the main docking bar as a button to openInHand.

Regards .. Subbu

Reply | Threaded
Open this post in threaded view
|

Re: Help: Etoys package changes vs trunk

Christoph Thiede

I wasn't sure about the difference between ignore(i) and "remove from current changeset".


"Ignore" will hide the selected change from the version you are going to save/upload.

"Remove from current changeset" does what its name says: The change will be removed from your current changeset (which you can watch and edit by opening a change sorter in the apps menu). However, the change will be included in the new version you are going to save.

I hope I could tell you anything new :-)


MonthMorph is quite a useful morph to have around while talking about dates and schedules. We could use the clock in the main docking bar as a button to openInHand.


Sounds interesting! :D Personally, I would prefer #openInWindow, and its default position should be just next to the clock morph (as you might know it from Windows). I'm looking forward to your next inbox commits!


Best,

Christoph


Von: Squeak-dev <[hidden email]> im Auftrag von K K Subbu <[hidden email]>
Gesendet: Montag, 6. April 2020 06:35:04
An: [hidden email]
Betreff: Re: [squeak-dev] Help: Etoys package changes vs trunk
 
On 06/04/20 12:45 AM, Thiede, Christoph wrote:
>
> Apart from that, you can certainly hide these changes from your inbox
> commit by right-clicking them in the Monticello browser and choosing
> "ignore". :-)

Thanks for this tip. I wasn't sure about the difference between
ignore(i) and "remove from current changeset".

I uploaded the patch to Inbox. MonthMorph is quite a useful morph to
have around while talking about dates and schedules. We could use the
clock in the main docking bar as a button to openInHand.

Regards .. Subbu



Carpe Squeak!