Help: inbox repo in MC browser

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Help: inbox repo in MC browser

K K Subbu
All,

While updating http://wiki.squeak.org/squeak/3279 on how to contribute
to squeak, I realized that the procedure could be simplified if Inbox is
already part of MC repo in a released image. However, I couldn't submit
a patch for this because it looks like the repos are initialized from an
external file at the time of building the release image :-(.

I see methods like isTrunk and isInbox in the code. The trunk repo is
part of the built-in list but not inbox. Is there any reason why it was
left out? Is it possible to include it in the next release?

Thanks .. Subbu

Reply | Threaded
Open this post in threaded view
|

Re: Help: inbox repo in MC browser

Hannes Hirzel
On 6/29/18, K K Subbu <[hidden email]> wrote:
> All,
>
> While updating http://wiki.squeak.org/squeak/3279 on how to contribute
> to squeak, I realized that the procedure could be simplified if Inbox is
> already part of MC repo in a released image.
+1

> However, I couldn't submit
> a patch for this because it looks like the repos are initialized from an
> external file at the time of building the release image :-(.

Where did you find that information?

That external file must be accessible somewhere...

What about

ReleaseBuilder
addAdditionalRepositories

        MCRepositoryGroup default addRepository: self inboxRepository.

        #(
                'http://www.squeaksource.com/MetacelloRepository'
                'http://www.hpi.uni-potsdam.de/hirschfeld/squeaksource/MetacelloRepository'
                        ) collect: [:url |
                                MCRepositoryGroup default addRepository: (MCHttpRepository
                                        location: url
                                        user: 'squeak'
                                        password: 'squeak')].






> I see methods like isTrunk and isInbox in the code. The trunk repo is
> part of the built-in list but not inbox. Is there any reason why it was
> left out? Is it possible to include it in the next release?
>
> Thanks .. Subbu
>
>

Reply | Threaded
Open this post in threaded view
|

Re: Help: inbox repo in MC browser

Hannes Hirzel
Alternatively just have this content
    http://wiki.squeak.org/squeak/6545
available in the help system

On 6/29/18, H. Hirzel <[hidden email]> wrote:

> On 6/29/18, K K Subbu <[hidden email]> wrote:
>> All,
>>
>> While updating http://wiki.squeak.org/squeak/3279 on how to contribute
>> to squeak, I realized that the procedure could be simplified if Inbox is
>> already part of MC repo in a released image.
> +1
>
>> However, I couldn't submit
>> a patch for this because it looks like the repos are initialized from an
>> external file at the time of building the release image :-(.
>
> Where did you find that information?
>
> That external file must be accessible somewhere...
>
> What about
>
> ReleaseBuilder
> addAdditionalRepositories
>
> MCRepositoryGroup default addRepository: self inboxRepository.
>
> #(
> 'http://www.squeaksource.com/MetacelloRepository'
> 'http://www.hpi.uni-potsdam.de/hirschfeld/squeaksource/MetacelloRepository'
> ) collect: [:url |
> MCRepositoryGroup default addRepository: (MCHttpRepository
> location: url
> user: 'squeak'
> password: 'squeak')].
>
>
>
>
>
>
>> I see methods like isTrunk and isInbox in the code. The trunk repo is
>> part of the built-in list but not inbox. Is there any reason why it was
>> left out? Is it possible to include it in the next release?
>>
>> Thanks .. Subbu
>>
>>
>

Reply | Threaded
Open this post in threaded view
|

Re: Help: inbox repo in MC browser

Levente Uzonyi
In reply to this post by K K Subbu
It used to be part of the release up to version 4.5, as it is a crucial
part of the development process[1], but for some reason it has been
removed...

Levente

[1]: https://squeak.org/development_process/

On Fri, 29 Jun 2018, K K Subbu wrote:

> All,
>
> While updating http://wiki.squeak.org/squeak/3279 on how to contribute
> to squeak, I realized that the procedure could be simplified if Inbox is
> already part of MC repo in a released image. However, I couldn't submit
> a patch for this because it looks like the repos are initialized from an
> external file at the time of building the release image :-(.
>
> I see methods like isTrunk and isInbox in the code. The trunk repo is
> part of the built-in list but not inbox. Is there any reason why it was
> left out? Is it possible to include it in the next release?
>
> Thanks .. Subbu
>
>

Reply | Threaded
Open this post in threaded view
|

Re: Help: inbox repo in MC browser

K K Subbu
In reply to this post by Hannes Hirzel
On Friday 29 June 2018 06:01 PM, H. Hirzel wrote:
>> However, I couldn't submit
>> a patch for this because it looks like the repos are initialized from an
>> external file at the time of building the release image:-(.
> Where did you find that information?

By tracing the addRepository: senders. If I inspect the singleton
MCRepositoryGroup default, I only see squeak50 and trunk.

> ReleaseBuilder
> addAdditionalRepositories
>
> MCRepositoryGroup default addRepository: self inboxRepository.

This method is not invoked for alpha (see class method doNextStep). So I
am guessing that repos were manually added at build time.

Regards .. Subbu

Reply | Threaded
Open this post in threaded view
|

Re: Help: inbox repo in MC browser

K K Subbu
In reply to this post by Levente Uzonyi
What could have been the compelling reason to exclude inbox in alpha
releases? I would assume inbox would be critical to receive a flood of
changesets during early stages of a release.

If this is an oversight and not a deliberate exclusion, what would be
the best way to restore the inbox repo?

* In Code - restore trunk and inbox in the initialize methods (being
critical to the operation of the image)?

* In global state - just upload an empty changeset with a postscript to
add it back?

Regards .. Subbu

On Friday 29 June 2018 07:25 PM, Levente Uzonyi wrote:

> It used to be part of the release up to version 4.5, as it is a crucial
> part of the development process[1], but for some reason it has been
> removed...
>
> Levente
>
> [1]: https://squeak.org/development_process/
>
> On Fri, 29 Jun 2018, K K Subbu wrote:
>
>> All,
>>
>> While updating http://wiki.squeak.org/squeak/3279 on how to contribute
>> to squeak, I realized that the procedure could be simplified if Inbox
>> is already part of MC repo in a released image. However, I couldn't
>> submit a patch for this because it looks like the repos are
>> initialized from an external file at the time of building the release
>> image :-(.
>>
>> I see methods like isTrunk and isInbox in the code. The trunk repo is
>> part of the built-in list but not inbox. Is there any reason why it
>> was left out? Is it possible to include it in the next release?
>>
>> Thanks .. Subbu
>>
>>
>