How to get PRs reviewed?
Locked
 
|
I have a couple of PRs and would like to make some progress in getting reviewed, revised and included. Please see a summary of the changes. https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/386 Update external software to not build known vulnerable software. This is also aligning the ./configure && make cycles. And in general the same build script should work for Win32, Unix and Mac as the third-parties buildsystem handles the differences already. We should be able to remove some of the redundancy https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/393: Fix CLI argument. --pollpip actually takes an argument but it is not documented. I fixed this for Mac and Unix. https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/394: Remove unused variables in the serial plugin for Macos and Unix. https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/395: Add a --quiet option for the VM. Pillar, ectstatic or other CLI applications compete with the VM on stderr (e.g. the pthread priority warning). Add an option to make the VM quiet (and in the future to send this somewhere else). If there is support I will extend struct VirtualMachine so that plugins can use the right stderr as well. I also have some spring cleaning if there is interest: * NPAPI is unsupported/dead. I propose the removal of npsqueak and the plugin code paths * Removal of "zzz" directories as we have a SCM now. cheers holger |
|
|
> On 7. May 2019, at 15:22, Holger Freyther <[hidden email]> wrote: Is this thing on? Do my socks have the right color... > I have a couple of PRs and would like to make some progress in getting reviewed, revised and included. Please see a summary of the changes. > > > https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/386 > Update external software to not build known vulnerable software. This is also aligning the ./configure && make cycles. > And in general the same build script should work for Win32, Unix and Mac as the third-parties buildsystem handles the differences already. We should be able to remove some of the redundancy > > > https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/393: > Fix CLI argument. --pollpip actually takes an argument but it is not documented. I fixed this for Mac and Unix. > > > https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/394: > Remove unused variables in the serial plugin for Macos and Unix. > > > https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/395: > Add a --quiet option for the VM. Pillar, ectstatic or other CLI applications compete with the VM on stderr (e.g. the pthread priority warning). Add an option to make the VM quiet (and in the future to send this somewhere else). > > If there is support I will extend struct VirtualMachine so that plugins can use the right stderr as well. > > > > I also have some spring cleaning if there is interest: > > * NPAPI is unsupported/dead. I propose the removal of npsqueak and the plugin code paths > * Removal of "zzz" directories as we have a SCM now. > > > cheers > holger |
|
|
I can't tell you about your socks, but your messages do arrive on the mailing list. ;-) Holger Freyther <[hidden email]> schrieb am Mi., 15. Mai 2019, 12:32:
|
|
On Wed, May 15, 2019 at 1:30 PM Jakob Reschke <[hidden email]> wrote:
Hi Holger, Sorry for the silence. I was hoping one of key contributors (or code base owners) would get back to you. I'm guessing they have the same problem I have: not enough time for reviewing. Anyway, I see two options how we can proceed: 1. wait even more...or 2. we give you permissions to the code base. This way, you could continue to open PRs and if there are no objections, you could merge them yourself. Any objections to options #2? Fabio
|
«
Return to Squeak VM
|
1 view|%1 views
| Free forum by Nabble | Edit this page |